Need unittest to verify internal/external manifests in sync. |
|||||
Issue descriptionWe have presubmit hooks to verify that internal and external manifests are in sync with each other, but not unittests. If people ignore the repo-hooks tests, the CLs go through the CQ just fine.
,
Oct 10 2016
Alternatively, we could auto-submit changes to the internal manifest when external_full.xml is updated and/or vice-versa.
,
Oct 12 2016
Ningning, if you get some time can you take a look at this?
,
Oct 12 2016
Probably the easiest solution is to add a chromite unittest, but it probably needs to just skip if it can't find both manifest directories. However, are we okay with a chromite unittest for non-chromite code?
,
Oct 12 2016
,
Oct 15 2016
Here's another CL that caused problems this would have caught. https://chrome-internal-review.googlesource.com/#/c/294456/
,
Mar 10 2018
This bug has not been touched in over a year. It is probably no longer relevant. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dgarr...@chromium.org
, Oct 10 2016