New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654518 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Chromium Dash Feedback - commits by username?

Project Member Reported by s...@chromium.org, Oct 10 2016

Issue description

https://chromiumdash.appspot.com/commits looks beautiful and I've definitely needed in the past to figure out which release my changes landed in, and this looks really awesome and helpful. But signing in with my chromium account is kind of a hassle, I try to keep @google.com and @chromium.org accounts isolated in different Chrome profiles.

Also, it'd be super useful to get this same information for any commit, some that may not have been your own.

So I'm hoping you could add the ability to specify a given username so I could look at someone else's CLs and what milestone they landed in. Showing your own commits seems like a reasonable default, but having it be the only mode I feels like it's missing some pretty reasonable use cases.

If this is already planned, feel free to ignore.
 
This is planned!  But I don't have a tracking bug, so I'm happy to leave this open to serve that purpose.

Re: Chromium / Google accounts, I'll be dropping the @google.com requirement as soon as we get the OK to make this publicly accessible, so hopefully that pain is alleviated soon.

Re: looking up other users' commits, I actually implemented that functionality while I was developing the tool - however, I had a hard time getting Polymer's routing mechanisms to work well with supporting both a specified (e.g. passed) and a non-specified (e.g. implied via sign-in state) username.  I also had a hard time figuring out what the UI surface should look like to be able to view another user's commits.

I'll try to figure out the former, but would love suggestions for the latter if you have 'em.

Also, in the interim - you can manually force look up a commit regardless of who landed it, e.g.  if you want to see details for commit 1b13fb748260bd09d0e9872fb3fbe09a5208d451 then you can simply craft a URL like https://chromiumdash.appspot.com/commit/1b13fb748260bd09d0e9872fb3fbe09a5208d451 and it'll show you.

Thanks for the feedback, I appreciate it!
 Issue 655639  has been merged into this issue.
Labels: Stable-Blocking
Status: Fixed (was: Unassigned)
I am super stoked to report that we've finished work on this feature in our staging instance - you can see a demo at https://chromiumdash-staging.googleplex.com/commits.

I will be marking this bug as fixed, but please re-open if you have any feedback on the design, or if you encounter any issues.  Otherwise, you will see this functionality appear on the non-staging server once we transition from serving from our old code, to the new updated codebase (likely within ~1 month).

Comment 5 by s...@chromium.org, Aug 18 2017

Wooo! Thanks!

Comment 6 by s...@chromium.org, Aug 18 2017

Status: Available (was: Fixed)
Actually, re-opening, I'm sorry, I have two problems.

1. I cannot figure out a way to enter a query param that's resolve to searching for a particular person's commits. Would be really convenient to be able to send a link to a person's commits. I've sent chromiumdash links to particular commits many times over the last month to various people. While linking to a user's commits is probably less useful than linking to a particular commit, it seems potentially useful to me.

2. Now there's nothing showing by default when you first land on the Commits page. Is it possible to display the most recent n commits before any search/filter criteria are applied?
Cc: pras...@chromium.org
+prasadv@ to see feedback here.

Re: 1, did you hit the dropdown to enter queries specifically?  That should walk you through it.  Hovering over the search icon will also give instructions if you want to freehand it.  If you enter "user:amineer@chromium.org" you should see my commits.  We'd like to support super plaintext searching (e.g. just typing "amineer@chromium.org" and having the same effect) we  just don't have time to implement that well :(  Re: not being able to link to the search specifically, that's a KI and we're planning to address it before launching to the public.

Re: 2, yeah, we should do that.  FWIW if you log into the page it will pop your commits on first load so we're hoping most folks upon using the tool for a bit will never come to an empty page, but agree having *something* load initially would be nice.

Comment 8 by s...@chromium.org, Aug 21 2017

Sorry my #1 point wasn't very clear. Linking to a particular search string would 100% solve my use case.

Feel free to close this if these are both being tracked elsewhere.
Status: Fixed (was: Available)
The ability to link has been discussed at length, but hadn't yet created a tracking bug for it - so I've done that with  issue 757559 .

Closing this per c#8 - thanks for all your feedback, please let us know if you have any more, it's appreciated!

Sign in to add a comment