New issue
Advanced search Search tips

Issue 654507 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Should not show download button for HLS stream

Project Member Reported by qin...@chromium.org, Oct 10 2016

Issue description

We are seeing download button for HLS streams, but downloading the m3u8 file is pointless.
 
Cc: mlamouri@chromium.org
Components: -Internals>Media Blink>Media>Controls
Labels: M-55
Status: Started (was: Unconfirmed)
Labels: Merge-Request-55
Labels: -Merge-Request-55 Merge-Approved-55 OS-Android
Guessing this is OS-Android, but please be sure to mark OSes in the future for merge requests, that's how we process them.

Approved for M55 branch 2883.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b38a3f37f9578807bf73661f084f23f0812f32

commit 07b38a3f37f9578807bf73661f084f23f0812f32
Author: Min Qin <qinmin@chromium.org>
Date: Tue Oct 11 19:53:55 2016

Don't show download button for HLS streams

Downloading the m3u8 file isn't useful to user.

TBR=mlamouri@chromium.org
BUG= 654507 

Review-Url: https://codereview.chromium.org/2400293003
Cr-Commit-Position: refs/heads/master@{#424291}
(cherry picked from commit e43859889b1cac0f6ba7d1855cb8e7753c8f89ba)

Review URL: https://codereview.chromium.org/2411043002 .

Cr-Commit-Position: refs/branch-heads/2883@{#42}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/07b38a3f37f9578807bf73661f084f23f0812f32/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/07b38a3f37f9578807bf73661f084f23f0812f32/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/07b38a3f37f9578807bf73661f084f23f0812f32/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Status: Fixed (was: Started)
Thanks! :)
verified in M56-56.0.2889.0
Status: Verified (was: Fixed)
Verified in M55-55.0.2883.18 build
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b38a3f37f9578807bf73661f084f23f0812f32

commit 07b38a3f37f9578807bf73661f084f23f0812f32
Author: Min Qin <qinmin@chromium.org>
Date: Tue Oct 11 19:53:55 2016

Don't show download button for HLS streams

Downloading the m3u8 file isn't useful to user.

TBR=mlamouri@chromium.org
BUG= 654507 

Review-Url: https://codereview.chromium.org/2400293003
Cr-Commit-Position: refs/heads/master@{#424291}
(cherry picked from commit e43859889b1cac0f6ba7d1855cb8e7753c8f89ba)

Review URL: https://codereview.chromium.org/2411043002 .

Cr-Commit-Position: refs/branch-heads/2883@{#42}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/07b38a3f37f9578807bf73661f084f23f0812f32/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/07b38a3f37f9578807bf73661f084f23f0812f32/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/07b38a3f37f9578807bf73661f084f23f0812f32/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Comment 10 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 11 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6920f2e6be77a44ee16b052b45b2c4228854ae0

commit b6920f2e6be77a44ee16b052b45b2c4228854ae0
Author: johnme <johnme@chromium.org>
Date: Tue Feb 21 22:17:06 2017

Media Controls: Remove download button for infinite streams

Specifically, removes the download button for media with infinite
duration, since there is no clear end at which to finish the download.

Also adds tests for the download button being hidden for empty URLs and
HLS streams, and fixes the test for the download button being hidden
when hideDownloadUI setting is disabled by making its video non-local.

BUG= 691561 , 654507 ,650738

Review-Url: https://codereview.chromium.org/2710713003
Cr-Commit-Position: refs/heads/master@{#451852}

[rename] https://crrev.com/b6920f2e6be77a44ee16b052b45b2c4228854ae0/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-not-displayed-hide-download-ui.html
[modify] https://crrev.com/b6920f2e6be77a44ee16b052b45b2c4228854ae0/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/b6920f2e6be77a44ee16b052b45b2c4228854ae0/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

Sign in to add a comment