New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654502 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

UseCounterTest failing on asan-clang-phone

Project Member Reported by ssid@chromium.org, Oct 10 2016

Issue description

Links to failed build:
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone/builds/1111



Logs:
I 2568.358s run_tests_on_device(0694f579003c05c7)  [ RUN      ] UseCounterTest.RecordingFeatures
I 2568.358s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:42: Failure
I 2568.359s run_tests_on_device(0694f579003c05c7)  Expected: (static_cast<base::HistogramBase*>(__null)) != (histogram), actual: NULL vs NULL
I 2568.359s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.359s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:42: Failure
I 2568.359s run_tests_on_device(0694f579003c05c7)  Expected: (static_cast<base::HistogramBase*>(__null)) != (histogram), actual: NULL vs NULL
I 2568.359s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.359s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:59: Failure
I 2568.359s run_tests_on_device(0694f579003c05c7)  Expected: (static_cast<base::HistogramBase*>(__null)) != (histogram), actual: NULL vs NULL
I 2568.359s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.359s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:59: Failure
I 2568.359s run_tests_on_device(0694f579003c05c7)  Expected: (static_cast<base::HistogramBase*>(__null)) != (histogram), actual: NULL vs NULL
I 2568.359s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.359s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:79: Failure
I 2568.359s run_tests_on_device(0694f579003c05c7)  Value of: 0
I 2568.359s run_tests_on_device(0694f579003c05c7)  Expected: count
I 2568.359s run_tests_on_device(0694f579003c05c7)  Which is: 2
I 2568.360s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.360s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:59: Failure
I 2568.360s run_tests_on_device(0694f579003c05c7)  Expected: (static_cast<base::HistogramBase*>(__null)) != (histogram), actual: NULL vs NULL
I 2568.360s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.360s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:59: Failure
I 2568.360s run_tests_on_device(0694f579003c05c7)  Expected: (static_cast<base::HistogramBase*>(__null)) != (histogram), actual: NULL vs NULL
I 2568.360s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.360s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:59: Failure
I 2568.360s run_tests_on_device(0694f579003c05c7)  Expected: (static_cast<base::HistogramBase*>(__null)) != (histogram), actual: NULL vs NULL
I 2568.360s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.360s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:79: Failure
I 2568.360s run_tests_on_device(0694f579003c05c7)  Value of: 0
I 2568.360s run_tests_on_device(0694f579003c05c7)  Expected: count
I 2568.360s run_tests_on_device(0694f579003c05c7)  Which is: 3
I 2568.360s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.360s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:59: Failure
I 2568.361s run_tests_on_device(0694f579003c05c7)  Expected: (static_cast<base::HistogramBase*>(__null)) != (histogram), actual: NULL vs NULL
I 2568.361s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.361s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:79: Failure
I 2568.361s run_tests_on_device(0694f579003c05c7)  Value of: 0
I 2568.361s run_tests_on_device(0694f579003c05c7)  Expected: count
I 2568.361s run_tests_on_device(0694f579003c05c7)  Which is: 4
I 2568.361s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.361s run_tests_on_device(0694f579003c05c7)  [  FAILED  ] UseCounterTest.RecordingFeatures (6 ms)
I 2568.361s run_tests_on_device(0694f579003c05c7)  [ RUN      ] UseCounterTest.InspectorDisablesMeasurement
I 2568.361s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:42: Failure
I 2568.361s run_tests_on_device(0694f579003c05c7)  Expected: (static_cast<base::HistogramBase*>(__null)) != (histogram), actual: NULL vs NULL
I 2568.361s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.Features" does not exist.
I 2568.361s run_tests_on_device(0694f579003c05c7)  ../../base/test/histogram_tester.cc:42: Failure
I 2568.361s run_tests_on_device(0694f579003c05c7)  Expected: (static_cast<base::HistogramBase*>(__null)) != (histogram), actual: NULL vs NULL
I 2568.361s run_tests_on_device(0694f579003c05c7)  Histogram "WebCore.UseCounter_TEST.CSSProperties" does not exist.
I 2568.361s run_tests_on_device(0694f579003c05c7)  [  FAILED  ] UseCounterTest.InspectorDisablesMeasurement (1 ms)
I 2568.362s run_tests_on_device(0694f579003c05c7)  [----------] 2 tests from UseCounterTest (7 ms total)



I am not sure if this is the exact range since bot was failing due to build errors that time.

Full blame list:
https://chromium.googlesource.com/chromium/src/+log/5264ac775e58852ece697a6e26117d72181c4f41..b770266d26fc09ab8fb746562d008c5d436e4784?pretty=oneline

cc-ing seemingly relevant folks.

Suspected CLs:
commit dd1a7ad9f71c9e1d990f651f8f1cc15c0130f1e1
Author: dcheng <dcheng@chromium.org>
Date:   Mon Sep 26 09:56:00 2016 -0700

    Adjust CSS property maximum tracking to be more clang-format friendly.
    
    BUG= 649969 
    
    Review-Url: https://codereview.chromium.org/2368103003
    Cr-Commit-Position: refs/heads/master@{#420911}

commit 239fdac4d03219287e6f8aef8e7f372f615e2a2b
Author: mkwst <mkwst@chromium.org>
Date:   Mon Sep 26 08:44:04 2016 -0700

    Add usage counters to XSSAuditor.
    
    BUG= 642747 
    
    Review-Url: https://codereview.chromium.org/2330353007
    Cr-Commit-Position: refs/heads/master@{#420892}

 

Comment 1 by ssid@chromium.org, Oct 10 2016

Cc: rtoy@chromium.org billorr@chromium.org
Owner: rbyers@chromium.org
Seems WebCore.UseCounter_TEST has been added recently-ish (1 month ago) by rbyers@ here: https://codereview.chromium.org/2290733002

Assigning to him for triage/investigation.
Status: Assigned (was: Untriaged)
Owner: lunalu@chromium.org
luna@ can you take a look at this at some point?  I suspect there's some generic non-determinism somewhere in the UseCounterTest on Android.  Perhaps same root cause as  issue 667913 .

Comment 5 by lunalu@chromium.org, Apr 27 2017

Status: Started (was: Assigned)
I am trying to find this in Flakiness Dashboard, what is the builder of the tests (I couldn't find any builder named "asan-clang")

Comment 6 by lunalu@chromium.org, Apr 28 2017

I cannot reproduce it on Nexus 4 (lolipop). I suspect the bug is fixed?

Also "WebCore.UseCounter_TEST.Features" is now replaced by "Blink.UseCounter.Features". So the previous errors no longer exist. 

Comment 7 by rbyers@chromium.org, Apr 28 2017

Note that the ASAN bots are special - they add instrumentation (Address Sanitizer) which can slow things down and be more likely to provoke race conditions / timeouts.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/285ad523ac8e142089580e9b2669926d6f9e46d8

commit 285ad523ac8e142089580e9b2669926d6f9e46d8
Author: lunalu <lunalu@chromium.org>
Date: Fri Apr 28 19:42:27 2017

Re-enable UseCounterTests on Android

Tests re-enabled are:
UseCounterTest.RecordingFeatures, UseCounterTest.SVGImageContextFeatures,
UseCounterTest.InspectorDisablesMeasurement, UseCounterTest.MutedDocuments

BUG= 667913 , 654502 

Review-Url: https://codereview.chromium.org/2847173002
Cr-Commit-Position: refs/heads/master@{#468097}

[modify] https://crrev.com/285ad523ac8e142089580e9b2669926d6f9e46d8/third_party/WebKit/Source/core/frame/UseCounterTest.cpp

Status: Fixed (was: Started)
Owner: loonyb...@chromium.org

Sign in to add a comment