Issue metadata
Sign in to add a comment
|
Remove IMAGE, TEXT, IMAGE+TEXT, AUDIO result types. |
||||||||||||||||||||||||
Issue descriptionThis was proposed in blink-dev@ and in the blink infra meeting; the advantage would be that the JSON result format would be simplified and more similar for layout test results and other test results. Erik, do you know what the first steps might be?
,
Oct 11 2016
Excellent--
Also, remember that if people still want to keep showing more detail on the test-results UI but we still want to simplify the test result types, we could add additional fields to the per-test results dict to specify what type of mismatch there was.
This could parallel the current optional fields that we have now called "is_missing_audio", "is_missing_text", "is_missing_video", which add more detail for the single test result "MISSING".
So for example, we could theoretically make it so that layout test results look like this:
"tests": {
"foo": {
"bar": {
"test-a.html": {
"expected": "PASS",
"actual": "MISSING",
"is_unexpected": true,
"is_missing_audio": true
},
"test-b.html": {
"expected": "FAIL",
"actual": "PASS",
"is_unexpected": true
},
"test-c.html": {
"expected": "PASS",
"actual": "FAIL",
"is_unexpected": true,
"is_text_mismatch": true,
"is_video_mismatch": true
}
}
}
}
IF the goal of this change is to simplify the list of test result types, but not necessarily to simplify the test-results UI, then this might be a reasonable option. What do you think?
,
Oct 11 2016
Part of the motivation for the removal of application-specific statuses is to simplify the dashboard UI code and the concepts we expose to users viewing test history, so ideally we wouldn't just be moving the source of custom stuff to different fields. This is something we can revisit later, though. It should be solved in a way that would allow other teams to have their own custom statuses if we do.
,
Jan 9 2017
,
Jan 9 2017
Remaining work on this bug is: 2) Fold types into each other on upload so json is stored with new statuses. 3) Change clients to upload simplified types. Making available for now since I likely won't work on this for a while.
,
Jun 23 2017
,
Jun 25 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 28 2018
,
Jun 28 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by estaab@chromium.org
, Oct 11 2016