Cronet should expose median HTTP RTT, median transport layer RTT and the median throughput to the embedders. These values can be computed from NQE.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfcbdf56a8e6a7d21d71ffead1c27cfa64a0da3a commit dfcbdf56a8e6a7d21d71ffead1c27cfa64a0da3a Author: tbansal <tbansal@chromium.org> Date: Fri Oct 14 01:32:41 2016 Add Network Quality observer to NQE. Network quality (HTTP RTT, transport RTT, downstream throughput) is computed every time effective connection type is computed. The observer is notified of a change in the network quality only if the effective connection type also changed since the last notification. BUG= 654498 Review-Url: https://codereview.chromium.org/2406763003 Cr-Commit-Position: refs/heads/master@{#425230} [modify] https://crrev.com/dfcbdf56a8e6a7d21d71ffead1c27cfa64a0da3a/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/dfcbdf56a8e6a7d21d71ffead1c27cfa64a0da3a/net/nqe/network_quality_estimator.h [modify] https://crrev.com/dfcbdf56a8e6a7d21d71ffead1c27cfa64a0da3a/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/dfcbdf56a8e6a7d21d71ffead1c27cfa64a0da3a/net/nqe/network_quality_estimator_test_util.h [modify] https://crrev.com/dfcbdf56a8e6a7d21d71ffead1c27cfa64a0da3a/net/nqe/network_quality_estimator_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbd3adb57de9b1802723ddb1f27081ffd87eba73 commit dbd3adb57de9b1802723ddb1f27081ffd87eba73 Author: tbansal <tbansal@chromium.org> Date: Thu Oct 20 17:19:19 2016 Expose RTT and throughput estimates from Cronet The estimates are computed by the network quality estimator (NQE) and are pushed to CronetUrlRequestContext. Embedders can query for the estimates by calling appropriate methods on CronetEngine. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet BUG= 654498 Review-Url: https://chromiumcodereview.appspot.com/2417643007 Cr-Commit-Position: refs/heads/master@{#426517} [modify] https://crrev.com/dbd3adb57de9b1802723ddb1f27081ffd87eba73/components/cronet/android/BUILD.gn [modify] https://crrev.com/dbd3adb57de9b1802723ddb1f27081ffd87eba73/components/cronet/android/api/src/org/chromium/net/CronetEngine.java [modify] https://crrev.com/dbd3adb57de9b1802723ddb1f27081ffd87eba73/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java [modify] https://crrev.com/dbd3adb57de9b1802723ddb1f27081ffd87eba73/components/cronet/android/cronet_url_request_context_adapter.cc [modify] https://crrev.com/dbd3adb57de9b1802723ddb1f27081ffd87eba73/components/cronet/android/cronet_url_request_context_adapter.h [modify] https://crrev.com/dbd3adb57de9b1802723ddb1f27081ffd87eba73/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java [modify] https://crrev.com/dbd3adb57de9b1802723ddb1f27081ffd87eba73/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java [modify] https://crrev.com/dbd3adb57de9b1802723ddb1f27081ffd87eba73/net/nqe/network_quality.cc [modify] https://crrev.com/dbd3adb57de9b1802723ddb1f27081ffd87eba73/net/nqe/network_quality.h [modify] https://crrev.com/dbd3adb57de9b1802723ddb1f27081ffd87eba73/net/nqe/network_quality_estimator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8ec19e9790339b41d4000db65fec00205f81a51 commit d8ec19e9790339b41d4000db65fec00205f81a51 Author: tbansal <tbansal@chromium.org> Date: Thu Oct 20 17:36:01 2016 Revert of Expose RTT and throughput estimates from Cronet (patchset #7 id:240001 of https://codereview.chromium.org/2417643007/ ) Reason for revert: Reverting this due to trybot failures: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM64%20Builder%20%28dbg%29/builds/40129 Original issue's description: > Expose RTT and throughput estimates from Cronet > > The estimates are computed by the network quality estimator > (NQE) and are pushed to CronetUrlRequestContext. > > Embedders can query for the estimates by calling > appropriate methods on CronetEngine. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet > > BUG= 654498 TBR=ryansturm@chromium.org,mgersh@chromium.org,xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 654498 Review-Url: https://chromiumcodereview.appspot.com/2433923005 Cr-Commit-Position: refs/heads/master@{#426522} [modify] https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51/components/cronet/android/BUILD.gn [modify] https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51/components/cronet/android/api/src/org/chromium/net/CronetEngine.java [modify] https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java [modify] https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51/components/cronet/android/cronet_url_request_context_adapter.cc [modify] https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51/components/cronet/android/cronet_url_request_context_adapter.h [modify] https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java [modify] https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java [modify] https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51/net/nqe/network_quality.cc [modify] https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51/net/nqe/network_quality.h [modify] https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51/net/nqe/network_quality_estimator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/618e25ceda758e085c89f50458571a508c23edb3 commit 618e25ceda758e085c89f50458571a508c23edb3 Author: tbansal <tbansal@chromium.org> Date: Thu Oct 20 22:06:27 2016 Expose RTT and throughput estimates from Cronet The estimates are computed by the network quality estimator (NQE) and are pushed to CronetUrlRequestContext. Embedders can query for the estimates by calling appropriate methods on CronetEngine. This CL is a reland of https://codereview.chromium.org/2417643007/. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet BUG= 654498 Review-Url: https://chromiumcodereview.appspot.com/2439833002 Cr-Commit-Position: refs/heads/master@{#426614} [modify] https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3/components/cronet/android/BUILD.gn [modify] https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3/components/cronet/android/api/src/org/chromium/net/CronetEngine.java [modify] https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java [modify] https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3/components/cronet/android/cronet_url_request_context_adapter.cc [modify] https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3/components/cronet/android/cronet_url_request_context_adapter.h [modify] https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java [modify] https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java [modify] https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3/net/nqe/network_quality.cc [modify] https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3/net/nqe/network_quality.h [modify] https://crrev.com/618e25ceda758e085c89f50458571a508c23edb3/net/nqe/network_quality_estimator.cc
Comment 1 by tbansal@chromium.org
, Oct 10 2016