Enable developers to contribute to Chrome Devtools frontend without compiling |
||||
Issue descriptionThe Chrome DevTools frontend is a webapp (built with JS) and can be hacked on without compiling using our development server. However, in order to run devtools layout tests, developers currently need to compile content_shell. For external developers without access to goma, this might take hours and is burdensome. The plan is to upload precompiled content shell for each desktop OS (Windows, Mac, and Linux) and create a script to fetch the appropriate revision's content shell.
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40c3352d7c5bab8791d9f2d357d40d7b99394f35 commit 40c3352d7c5bab8791d9f2d357d40d7b99394f35 Author: chenwilliam <chenwilliam@chromium.org> Date: Tue Oct 11 19:40:44 2016 DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG= 654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Review-Url: https://codereview.chromium.org/2383043003 Cr-Original-Commit-Position: refs/heads/master@{#423195} Cr-Commit-Position: refs/heads/master@{#424514} [modify] https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35/chrome/tools/build/linux/FILES.cfg [modify] https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35/chrome/tools/build/mac/FILES.cfg [modify] https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35/chrome/tools/build/win/FILES.cfg
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/943069059d70dff482b4f539a45da4aa28488d64 commit 943069059d70dff482b4f539a45da4aa28488d64 Author: chenwilliam <chenwilliam@chromium.org> Date: Tue Oct 11 22:41:20 2016 Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ ) Reason for revert: Need to revert this b/c this CL is getting reverted: https://codereview.chromium.org/2407183003/ Original issue's description: > DevTools: archive content shell > > Creates an archive of the content shell for each desktop platform. > This will enable external contributors to use a precompiled > content shell to run devtools layout tests (and possibly others). > > The original patch broke the chrome archive because the FILES.cfg parser > couldn't support archiving the same file in multiple archives. > I've updated the parser logic in this CL: > > https://codereview.chromium.org/2402423002/ > > BUG= 654486 > > Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf > Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 > Cr-Original-Commit-Position: refs/heads/master@{#423195} > Cr-Commit-Position: refs/heads/master@{#424514} TBR=kerz@chromium.org,kerz@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 654486 Review-Url: https://codereview.chromium.org/2412763002 Cr-Commit-Position: refs/heads/master@{#424577} [modify] https://crrev.com/943069059d70dff482b4f539a45da4aa28488d64/chrome/tools/build/linux/FILES.cfg [modify] https://crrev.com/943069059d70dff482b4f539a45da4aa28488d64/chrome/tools/build/mac/FILES.cfg [modify] https://crrev.com/943069059d70dff482b4f539a45da4aa28488d64/chrome/tools/build/win/FILES.cfg
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/346ca76f9663a759d1caa23c04beaca19be8932f commit 346ca76f9663a759d1caa23c04beaca19be8932f Author: chenwilliam <chenwilliam@chromium.org> Date: Tue Oct 11 23:16:29 2016 Enable saving the same file in multiple archives Earlier I submitted a CL to archive content shell and I ran into an issue where the current FILES.cfg parser doesn't allow listing the same file for multiple archives. I opted to allow multiple entries of the same file in FILES.cfg rather than making the 'archive' property a list because this allows more configurability (e.g. for icudtl.dat, we only need to archive it for content shell for dev builds but for the main archive we archive it for dev and official builds). BUG= 654486 Committed: https://chromium.googlesource.com/chromium/tools/build/+/47c03a95aef64407f6d9bb5db7509bdca9be47f4 Review-Url: https://codereview.chromium.org/2402423002 [modify] https://crrev.com/346ca76f9663a759d1caa23c04beaca19be8932f/scripts/common/archive_utils.py [modify] https://crrev.com/346ca76f9663a759d1caa23c04beaca19be8932f/scripts/common/archive_utils_unittest.py
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42fed477dcd99e0df2ef6415fbfcb10dfd3d2ac9 commit 42fed477dcd99e0df2ef6415fbfcb10dfd3d2ac9 Author: chenwilliam <chenwilliam@chromium.org> Date: Wed Oct 12 17:20:39 2016 DevTools: archive content shell Creates an archive of the content shell for each desktop platform. This will enable external contributors to use a precompiled content shell to run devtools layout tests (and possibly others). The original patch broke the chrome archive because the FILES.cfg parser couldn't support archiving the same file in multiple archives. I've updated the parser logic in this CL: https://codereview.chromium.org/2402423002/ BUG= 654486 Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf Committed: https://crrev.com/40c3352d7c5bab8791d9f2d357d40d7b99394f35 Review-Url: https://codereview.chromium.org/2383043003 Cr-Original-Original-Commit-Position: refs/heads/master@{#423195} Cr-Original-Commit-Position: refs/heads/master@{#424514} Cr-Commit-Position: refs/heads/master@{#424771} [modify] https://crrev.com/42fed477dcd99e0df2ef6415fbfcb10dfd3d2ac9/chrome/tools/build/linux/FILES.cfg [modify] https://crrev.com/42fed477dcd99e0df2ef6415fbfcb10dfd3d2ac9/chrome/tools/build/mac/FILES.cfg [modify] https://crrev.com/42fed477dcd99e0df2ef6415fbfcb10dfd3d2ac9/chrome/tools/build/win/FILES.cfg
,
Oct 13 2016
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/605fd97ead89705d29fa86c7b9885db159a35f8a commit 605fd97ead89705d29fa86c7b9885db159a35f8a Author: chenwilliam <chenwilliam@chromium.org> Date: Tue Oct 18 19:36:23 2016 DevTools: add "npm test" to run tests by fetching content shells Running "npm test" from /devtools fetches an uploaded content shell (which is cached) and runs devtools layout tests. This allows developers, especially external contributors, to run our tests without compiling. API: * "npm test" - builds devtools and run all inspector layout tests (primary command) * "npm test -- -f --child-processes=16" - pass in additional flags to the test harness * "npm test -- inspector/sources inspector/console" - run specific tests * "npm test -- inspector/cookie-resource-match.html --debug-devtools" - debug a specific test (non-bundled & minified) * "npm run test:build" - only builds devtools (in debug mode) * "npm run test:run" - only runs devtools tests This currently works w/ a full-checkout, but I plan on working to enable running devtools layout tests w/ only a frontend checkout. BUG= 654486 Review-Url: https://codereview.chromium.org/2413563002 Cr-Commit-Position: refs/heads/master@{#426024} [modify] https://crrev.com/605fd97ead89705d29fa86c7b9885db159a35f8a/third_party/WebKit/Source/devtools/.gitignore [modify] https://crrev.com/605fd97ead89705d29fa86c7b9885db159a35f8a/third_party/WebKit/Source/devtools/package.json [add] https://crrev.com/605fd97ead89705d29fa86c7b9885db159a35f8a/third_party/WebKit/Source/devtools/scripts/npm_test.js [add] https://crrev.com/605fd97ead89705d29fa86c7b9885db159a35f8a/third_party/WebKit/Source/devtools/scripts/unzip.py [modify] https://crrev.com/605fd97ead89705d29fa86c7b9885db159a35f8a/third_party/WebKit/Source/devtools/scripts/utils.js
,
Nov 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b57bb537043ed5d20edcc5f58c9a21575c03076b commit b57bb537043ed5d20edcc5f58c9a21575c03076b Author: chenwilliam <chenwilliam@chromium.org> Date: Tue Nov 01 19:46:52 2016 DevTools: Automagically detect user compiled content shell in npm test This should provide a seamless workflow if you're using: * full chromium checkout - uses your compiled content shell (from out/Release) if possible, otherwise it falls back to fetching a content shell from the cloud. It will also compile devtools front-end so it can run tests in release mode. * front-end github checkout - always uses a pre-compiled content shell fetched from the cloud This deprecates the run_inspector_tests.sh which will be replaced by "npm test". I've also added documentation on `npm test` in the README. BUG= 654486 Review-Url: https://codereview.chromium.org/2462153003 Cr-Commit-Position: refs/heads/master@{#429076} [modify] https://crrev.com/b57bb537043ed5d20edcc5f58c9a21575c03076b/third_party/WebKit/Source/devtools/readme.md [modify] https://crrev.com/b57bb537043ed5d20edcc5f58c9a21575c03076b/third_party/WebKit/Source/devtools/scripts/npm_test.js [modify] https://crrev.com/b57bb537043ed5d20edcc5f58c9a21575c03076b/third_party/WebKit/Source/devtools/scripts/run_inspector_tests.sh
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/827a6e34277fa42b81d5fc0f6f7b79e4d017cd7b commit 827a6e34277fa42b81d5fc0f6f7b79e4d017cd7b Author: chenwilliam <chenwilliam@chromium.org> Date: Mon Nov 14 23:09:11 2016 DevTools: add custom-devtools-frontend flag for content shell layout tests Instead of copying devtools files into the content shell resource folder, I created a new flag that specifies a custom path to devtools. BUG= 654486 Review-Url: https://codereview.chromium.org/2448143004 Cr-Commit-Position: refs/heads/master@{#431949} [modify] https://crrev.com/827a6e34277fa42b81d5fc0f6f7b79e4d017cd7b/content/shell/browser/layout_test/layout_test_devtools_frontend.cc [modify] https://crrev.com/827a6e34277fa42b81d5fc0f6f7b79e4d017cd7b/content/shell/common/layout_test/layout_test_switches.cc [modify] https://crrev.com/827a6e34277fa42b81d5fc0f6f7b79e4d017cd7b/content/shell/common/layout_test/layout_test_switches.h [modify] https://crrev.com/827a6e34277fa42b81d5fc0f6f7b79e4d017cd7b/third_party/WebKit/Source/devtools/.gitignore [modify] https://crrev.com/827a6e34277fa42b81d5fc0f6f7b79e4d017cd7b/third_party/WebKit/Source/devtools/scripts/npm_test.js
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/801aea9fbc24ef5486f799922aa0a7e1c583f8be commit 801aea9fbc24ef5486f799922aa0a7e1c583f8be Author: chenwilliam <chenwilliam@chromium.org> Date: Fri Nov 18 20:12:28 2016 DevTools: fix npm test debugging when using user compiled content shell Previously, I wasn't copying the metadata files when the user compiled their own content shell, which is needed for debugging tests. Also, I've removed the test-only and build-only flags since we no longer need to copy/build devtools now that we're using --custom-devtools-frontend. BUG= 654486 Review-Url: https://codereview.chromium.org/2508413002 Cr-Commit-Position: refs/heads/master@{#433279} [modify] https://crrev.com/801aea9fbc24ef5486f799922aa0a7e1c583f8be/third_party/WebKit/Source/devtools/package.json [modify] https://crrev.com/801aea9fbc24ef5486f799922aa0a7e1c583f8be/third_party/WebKit/Source/devtools/readme.md [modify] https://crrev.com/801aea9fbc24ef5486f799922aa0a7e1c583f8be/third_party/WebKit/Source/devtools/scripts/npm_test.js
,
Dec 1 2016
,
Jan 23 2017
Issue 609986 has been merged into this issue.
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e9aef5888b320166d80c3d7d6ee8a9c12098552 commit 3e9aef5888b320166d80c3d7d6ee8a9c12098552 Author: Pavel Feldman <pfeldman@chromium.org> Date: Mon Oct 09 18:33:57 2017 Content shell: deploy v8 snapshots for content_shell.zip archive to be self-contained. Follow up to r424771: there are two more files we should deploy for v8 to boot in content shell successfully. Bug: 654486 Change-Id: I9968dff10233c91971abcedae225d54c917dd93d Reviewed-on: https://chromium-review.googlesource.com/706348 Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#507422} [modify] https://crrev.com/3e9aef5888b320166d80c3d7d6ee8a9c12098552/chrome/tools/build/linux/FILES.cfg [modify] https://crrev.com/3e9aef5888b320166d80c3d7d6ee8a9c12098552/chrome/tools/build/mac/FILES.cfg [modify] https://crrev.com/3e9aef5888b320166d80c3d7d6ee8a9c12098552/chrome/tools/build/win/FILES.cfg |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Oct 11 2016