Fix the tests for Windows and Mac. Stemmed from http://crbug.com/487344
Assigning to the author of the original change: https://codereview.chromium.org/1811003002
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0b15605b2ad9b78830940519b969f6b3bad80ac commit a0b15605b2ad9b78830940519b969f6b3bad80ac Author: Caleb Rouleau <crouleau@chromium.org> Date: Thu Aug 03 23:46:54 2017 Point to current bug for fixing layout test problems. Bug: 654477 Change-Id: I01e842c3ae227410a0f002ea5383babefbdf432b Reviewed-on: https://chromium-review.googlesource.com/601128 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491879} [modify] https://crrev.com/a0b15605b2ad9b78830940519b969f6b3bad80ac/third_party/WebKit/LayoutTests/TestExpectations
:( Are these tests becoming deprecated because of the new new media controls? Is someone adding layout tests for those? It seems like we generally should be fixing tests before we release new features.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7be4df953a97f8508fb8fe70679031ce3913b52e commit 7be4df953a97f8508fb8fe70679031ce3913b52e Author: liberato@chromium.org <liberato@chromium.org> Date: Mon Mar 12 16:57:24 2018 Rebaseline some video tests. This rebaselines the following tests, which had minor visual differences from their refs: media/audio-controls-rendering.html media/controls-after-reload.html media/controls-layout-direction.html media/controls-styling.html media/controls-styling-strict.html media/controls-without-preload.html media/media-controls-clone.html media/video-controls-rendering.html media/video-display-toggle.html media/video-empty-source.html Change-Id: Ic664381c7d16a85f94724d69fa65cb179ef5ea66 Bug: 612442 , 654477, 821025 Reviewed-on: https://chromium-review.googlesource.com/956227 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#542512} [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/audio-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/audio-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-layout-direction-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.png [delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/audio-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/audio-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-layout-direction-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.png [rename] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/audio-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/audio-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-layout-direction-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.txt [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.png [modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.txt [delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/controls-strict-expected.png [delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/controls-strict-expected.txt [copy] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win7/media/media-controls-clone-expected.txt [delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/video-no-audio-expected.png [delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/video-no-audio-expected.txt
Is there still work needed to be done here?
CJ, go here https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/TestExpectations?q=layouttests/testexpectations&sq=package:chromium&dr and search for the bug number 654477 Those are remaining tasks.
Comment 1 by crouleau@chromium.org
, Aug 3 2017Labels: -Pri-3 Pri-2
Owner: liber...@chromium.org