Recent failed build (internal link):
https://uberchromegw.corp.google.com/i/official.android/builders/official-arm/builds/1253
Error message:
FAILED: obj/components/autofill/content/renderer/renderer/password_generation_agent.o
../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/components/autofill/content/renderer/renderer/password_generation_agent.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_SUPERVISED_USERS=1 -DUSE_PROPRIETARY_CODECS -DVIDEO_HOLE=1 -DSAFE_BROWSING_DB_REMOTE -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -D_FILE_OFFSET_BITS=64 -DNO_UNWIND_TABLES -DANDROID -DHAVE_SYS_UIO_H -DANDROID_NDK_VERSION=r10e -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__GNU_SOURCE=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL -DDISABLE_FFMPEG_VIDEO_DECODERS -DWEBRTC_BUILD_LIBEVENT -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DV8_USE_EXTERNAL_STARTUP_DATA -DPOSIX_AVOID_MMAP -DENABLE_WEBSOCKETS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -I../../third_party/khronos -I../../gpu -I../../third_party/libwebp -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -Igen/components/strings -Igen/components/strings -Igen/components/strings -Igen/components/strings -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/re2/src -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -ffunction-sections -fno-short-enums -finline-limit=64 -march=armv7-a -mfloat-abi=softfp -mthumb -mthumb-interwork -mtune=generic-armv7-a -fno-tree-sra -fno-caller-saves -mfpu=neon -Wall -Werror -Wno-psabi -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Os -fomit-frame-pointer -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=../../third_party/android_tools/ndk/platforms/android-16/arch-arm -fvisibility=hidden -Wunknown-pragmas -Wno-error=unknown-pragmas -Wunknown-pragmas -Wno-error=unknown-pragmas -Wunknown-pragmas -Wno-error=unknown-pragmas -Wunknown-pragmas -Wno-error=unknown-pragmas -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -fno-rtti -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fno-exceptions -c ../../components/autofill/content/renderer/password_generation_agent.cc -o obj/components/autofill/content/renderer/renderer/password_generation_agent.o
../../components/autofill/content/renderer/password_generation_agent.cc: In member function 'virtual void autofill::PasswordGenerationAgent::OnDestruct()':
../../components/autofill/content/renderer/password_generation_agent.cc:193:3: error: 'binding_' was not declared in this scope
binding_.Close();
^
Suspected CL:
commit 2524a5f430bcc8cbc1e8d0c47c5047ba696c7f04
Author: Han Leon <leon.han@intel.com>
Date: Sat Oct 8 10:36:48 2016 +0800
[Autofill] Close mojo interface bindings of autofill/password agent in time.
As for AutofillAgent, Password{Autofill,Generation}Agent, their destructions
are asynchronous with destructions of corresponding render frame.
Thus, even after corresponding render frame has been deleted, they can still
keep alive for some while and still able to receive mojo messages which maybe
lead to use-after-delete access on the render frame.
To solve above problem, this CL closes the mojo interface bindings immediatelly
when render frame got destroyed.
BUG=641156
Review-Url: https://codereview.chromium.org/2320993002
Cr-Commit-Position: refs/heads/master@{#417286}
(cherry picked from commit 7e8c85b79831bb59427ffc5b229bc08470f619ef)
Review URL: https://codereview.chromium.org/2400393003 .
Cr-Commit-Position: refs/branch-heads/2840@{#693}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Comment 1 by leon....@intel.com
, Oct 13 2016Status: Duplicate (was: Untriaged)