Issue metadata
Sign in to add a comment
|
1.7%-4.1% regression in memory.top_10_mobile at 424076:424078 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 10 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8999170427895007488
,
Oct 11 2016
=== Auto-CCing suspected CL author adamk@chromium.org === Hi adamk@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Remove now-unused TailCallExpressionProduction from ExpressionClassifier Author : adamk Commit description: R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2395003002 Cr-Commit-Position: refs/heads/master@{#40053} Commit : 549690f2bfdb785a48e5643aaf76c0fe0470d4ca Date : Thu Oct 06 17:53:39 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@424075 21229260 144104 8 good chromium@424075,v8@549690f2bf 22858521 88959.6 5 bad <-- chromium@424075,v8@4b575dfcef 22909311 287257 5 bad chromium@424075,v8@9d836ec64a 22837222 194907 5 bad chromium@424075,v8@411aa27a47 22764313 106551 5 bad chromium@424075,v8@a78c5ea518 22780697 55060.4 5 bad chromium@424075,v8@55af3c44c9 23517158 736976 5 bad chromium@424076 21503564 151505 5 bad chromium@424077 21598924 94100.5 8 bad Bisect job ran on: android_one_perf_bisect Bug ID: 654474 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile Test Metric: memory:chrome:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/foreground/http_m_youtube_com_results_q_science Relative Change: 1.54% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1702 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999170427895007488 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5831497242640384 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Oct 11 2016
This was nearly a pure dead code deletion (the only thing not deleted was a single bitwise op). I don't think it's possible for it to cause any change in performance, so I suspect this bisect is wrong.
,
Oct 11 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8999076782853825872
,
Oct 11 2016
Thanks for the feedback, reported that bisect as wrong; started another bisect.
,
Oct 12 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Move memory observer off OutputSurface/CompositorFrameSink Author : danakj Commit description: Instead make ContextProviderCommandBuffer be a memory observer, and avoid interfaces inheriting other interfaces. R=ericrk@chromium.org BUG= 606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2408513002 Cr-Commit-Position: refs/heads/master@{#424039} Commit : 2871a8c3516e495b9e9acedfe9c0fd43dc9b7b06 Date : Sat Oct 08 01:55:53 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@422769 80700211 758404 5 good chromium@423471 80692838 756561 5 good chromium@423822 80663347 742215 5 good chromium@423998 80636314 727980 5 good chromium@424020 80598630 715955 5 good chromium@424031 80610099 712589 5 good chromium@424037 80676454 747908 5 good chromium@424038 80666624 743534 5 good chromium@424039 89350144 733539 5 bad <-- chromium@424040 89300173 702607 5 bad chromium@424042 89342771 732282 5 bad chromium@424086 89310003 708693 5 bad chromium@424173 89355059 729855 5 bad Bisect job ran on: android_nexus7_perf_bisect Bug ID: 654474 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile Test Metric: memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/foreground/http_www_amazon_com_gp_aw_s_k_nexus Relative Change: 10.72% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/3388 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999076782853825872 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5028518210043904 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by qyears...@chromium.org
, Oct 10 2016