Need to add new Cronet APIs before removing old ones |
|||||||
Issue descriptionVersion: ToT OS: Android This CL removes several Cronet APIs: https://codereview.chromium.org/2339223002/ Including: 1. CronetEngine.createRequest() 2. UrlRequest.Builder.Builder() While it also adds some alternatives: 1. Mock UrlRequest.Builder (as it's non-final now) 2. CronetEngine.newUrlRequestBuilder() We need to give Cronet embedders time to update to the new APIs by providing some overlap where the new alternatives are available before the old APIs are removed. This overlap allows gradual migration, rather than massive forced migration.
,
Oct 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4480e95462fa0a4a59f7ba517a5fde5262aa8801 commit 4480e95462fa0a4a59f7ba517a5fde5262aa8801 Author: pauljensen <pauljensen@chromium.org> Date: Mon Oct 10 15:33:28 2016 [Cronet] Add new API methods before removing old ones To allow embedders to update to the new API piecemeal, rather than forcing an all-at-once update: 1. Allow mocking of UrlRequest.Builder by making non-final. This allows embedders to prepare for removal of CronetEngine.createRequest(). 2. Add CronetEngine.newUrlRequestBuilder() R=kapishnikov BUG= 654432 Review-Url: https://codereview.chromium.org/2402753002 Cr-Commit-Position: refs/heads/master@{#424154} [modify] https://crrev.com/4480e95462fa0a4a59f7ba517a5fde5262aa8801/components/cronet/android/api/src/org/chromium/net/CronetEngine.java [modify] https://crrev.com/4480e95462fa0a4a59f7ba517a5fde5262aa8801/components/cronet/android/api/src/org/chromium/net/UrlRequest.java
,
Oct 10 2016
This should have no effect on Chrome and is important for Cronet embedders (who receive releases from the Chrome dev channel). To have the desired benefits it needs to get into tomorrow's dev channel release (cut at 4pm today AFAIK).
,
Oct 10 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94b92e7ee8b2a5a266ba40298abb801119632fd8 commit 94b92e7ee8b2a5a266ba40298abb801119632fd8 Author: Paul Jensen <pauljensen@google.com> Date: Mon Oct 10 15:53:41 2016 [Cronet] Add new API methods before removing old ones To allow embedders to update to the new API piecemeal, rather than forcing an all-at-once update: 1. Allow mocking of UrlRequest.Builder by making non-final. This allows embedders to prepare for removal of CronetEngine.createRequest(). 2. Add CronetEngine.newUrlRequestBuilder() R=kapishnikov BUG= 654432 Review-Url: https://codereview.chromium.org/2402753002 Cr-Commit-Position: refs/heads/master@{#424154} (cherry picked from commit 4480e95462fa0a4a59f7ba517a5fde5262aa8801) Review URL: https://codereview.chromium.org/2403053002 . Cr-Commit-Position: refs/branch-heads/2883@{#13} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/94b92e7ee8b2a5a266ba40298abb801119632fd8/components/cronet/android/api/src/org/chromium/net/CronetEngine.java [modify] https://crrev.com/94b92e7ee8b2a5a266ba40298abb801119632fd8/components/cronet/android/api/src/org/chromium/net/UrlRequest.java
,
Oct 10 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94b92e7ee8b2a5a266ba40298abb801119632fd8 commit 94b92e7ee8b2a5a266ba40298abb801119632fd8 Author: Paul Jensen <pauljensen@google.com> Date: Mon Oct 10 15:53:41 2016 [Cronet] Add new API methods before removing old ones To allow embedders to update to the new API piecemeal, rather than forcing an all-at-once update: 1. Allow mocking of UrlRequest.Builder by making non-final. This allows embedders to prepare for removal of CronetEngine.createRequest(). 2. Add CronetEngine.newUrlRequestBuilder() R=kapishnikov BUG= 654432 Review-Url: https://codereview.chromium.org/2402753002 Cr-Commit-Position: refs/heads/master@{#424154} (cherry picked from commit 4480e95462fa0a4a59f7ba517a5fde5262aa8801) Review URL: https://codereview.chromium.org/2403053002 . Cr-Commit-Position: refs/branch-heads/2883@{#13} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/94b92e7ee8b2a5a266ba40298abb801119632fd8/components/cronet/android/api/src/org/chromium/net/CronetEngine.java [modify] https://crrev.com/94b92e7ee8b2a5a266ba40298abb801119632fd8/components/cronet/android/api/src/org/chromium/net/UrlRequest.java
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pauljensen@chromium.org
, Oct 10 2016