Issue 654431 link

Starred by 3 users

Issue metadata

Status:	Verified
Owner:	phweiss@chromium.org
Closed:	Oct 2016
Cc:	tnagel@chromium.org █ binzhao@chromium.org
Components:	Enterprise
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
M-55 Hotlist-Merge-Approved merge-merged-2883

Create Policy to control ARC status reporting

Project Member Reported by phweiss@chromium.org, Oct 10 2016

Issue description

Original bug at b/31084348

A CL implementing Status reporting for ARC++ landed in M55 (https://codereview.chromium.org/2383763002/), but the follow-up CL that creates the controlling policy and browser-tests have not landed yet, and branch already happened. This CL tracks landing the second CL and the merging back to 55.

This feature was promised in M55 to Google SecOps for ARC++ dogfooding.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6

commit 9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6
Author: phweiss <phweiss@chromium.org>
Date: Thu Oct 13 14:52:07 2016

Create policy ReportArcStatus

It controls that a status blob generated by CloudDPC is uploaded
with the Chrome OS reporting system as part of the session status.

TEST=browsertest
BUG= 654431 
BUG=b/31084348

Review-Url: https://codereview.chromium.org/2396103002
Cr-Commit-Position: refs/heads/master@{#425029}

[modify] https://crrev.com/9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6/chrome/common/pref_names.cc
[modify] https://crrev.com/9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6/chrome/common/pref_names.h
[modify] https://crrev.com/9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6/components/policy/resources/policy_templates.json
[modify] https://crrev.com/9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6/tools/metrics/histograms/histograms.xml

Comment 2 by phweiss@chromium.org, Oct 13 2016

Labels: Merge-Request-55

Comment 3 by dimu@chromium.org, Oct 14 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 4 by tnagel@chromium.org, Oct 17 2016

Cc: tnagel@chromium.org binzhao@chromium.org

Bin suggested to rename to ReportArcStatusEnabled for consistency with the existing boolean policies.  I'd guess that it should be still possible to back-merge the name change.  What do you think?

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2016

Labels: -merge-approved-55 merge-merged-2883

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2268457950bc718cc8b4c50e4207895906f48c1c

commit 2268457950bc718cc8b4c50e4207895906f48c1c
Author: phweiss <phweiss@chromium.org>
Date: Tue Oct 18 09:53:35 2016

Create policy ReportArcStatus

It controls that a status blob generated by CloudDPC is uploaded
with the Chrome OS reporting system as part of the session status.

TBR=phweiss
TEST=browsertest
BUG= 654431 
BUG=b/31084348
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2396103002
Cr-Commit-Position: refs/heads/master@{#425029}
(merged from 9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6)

Review-Url: https://codereview.chromium.org/2414393002
Cr-Commit-Position: refs/branch-heads/2883@{#171}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/common/pref_names.cc
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/common/pref_names.h
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/components/policy/resources/policy_templates.json
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f62f4b50cfdecbede2ba427719906b84d93e1dd9

commit f62f4b50cfdecbede2ba427719906b84d93e1dd9
Author: phweiss <phweiss@chromium.org>
Date: Tue Oct 18 12:14:21 2016

Rename policy ReportArcStatus to ReportArcStatusEnabled

for consistency with other boolean policies.

BUG= 654431 

Review-Url: https://codereview.chromium.org/2425683004
Cr-Commit-Position: refs/heads/master@{#425943}

[modify] https://crrev.com/f62f4b50cfdecbede2ba427719906b84d93e1dd9/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/f62f4b50cfdecbede2ba427719906b84d93e1dd9/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/f62f4b50cfdecbede2ba427719906b84d93e1dd9/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/f62f4b50cfdecbede2ba427719906b84d93e1dd9/chrome/common/pref_names.cc
[modify] https://crrev.com/f62f4b50cfdecbede2ba427719906b84d93e1dd9/chrome/common/pref_names.h
[modify] https://crrev.com/f62f4b50cfdecbede2ba427719906b84d93e1dd9/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/f62f4b50cfdecbede2ba427719906b84d93e1dd9/components/policy/resources/policy_templates.json

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9

commit 2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Tue Oct 18 12:22:40 2016

Rename policy ReportArcStatus to ReportArcStatusEnabled

for consistency with other boolean policies.

(Drovering on behalf of phweiss@.)

BUG= 654431 

Review-Url: https://codereview.chromium.org/2425683004
Cr-Commit-Position: refs/heads/master@{#425943}
(cherry picked from commit f62f4b50cfdecbede2ba427719906b84d93e1dd9)

Review URL: https://codereview.chromium.org/2425233002 .

Cr-Commit-Position: refs/branch-heads/2883@{#172}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/common/pref_names.cc
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/common/pref_names.h
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/components/policy/resources/policy_templates.json

Comment 8 by phweiss@chromium.org, Oct 18 2016

Status: Fixed (was: Started)

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2268457950bc718cc8b4c50e4207895906f48c1c

commit 2268457950bc718cc8b4c50e4207895906f48c1c
Author: phweiss <phweiss@chromium.org>
Date: Tue Oct 18 09:53:35 2016

Create policy ReportArcStatus

It controls that a status blob generated by CloudDPC is uploaded
with the Chrome OS reporting system as part of the session status.

TBR=phweiss
TEST=browsertest
BUG= 654431 
BUG=b/31084348
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2396103002
Cr-Commit-Position: refs/heads/master@{#425029}
(merged from 9e31a6f21150d74e3b677e7b8d01af1d6b3dcad6)

Review-Url: https://codereview.chromium.org/2414393002
Cr-Commit-Position: refs/branch-heads/2883@{#171}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/common/pref_names.cc
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/common/pref_names.h
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/components/policy/resources/policy_templates.json
[modify] https://crrev.com/2268457950bc718cc8b4c50e4207895906f48c1c/tools/metrics/histograms/histograms.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9

commit 2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Tue Oct 18 12:22:40 2016

Rename policy ReportArcStatus to ReportArcStatusEnabled

for consistency with other boolean policies.

(Drovering on behalf of phweiss@.)

BUG= 654431 

Review-Url: https://codereview.chromium.org/2425683004
Cr-Commit-Position: refs/heads/master@{#425943}
(cherry picked from commit f62f4b50cfdecbede2ba427719906b84d93e1dd9)

Review URL: https://codereview.chromium.org/2425233002 .

Cr-Commit-Position: refs/branch-heads/2883@{#172}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/common/pref_names.cc
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/common/pref_names.h
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/2cf31468e2d3f56ae086aeb8b5b7b162ff08d3f9/components/policy/resources/policy_templates.json

Comment 11 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 12 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840

[Automated comment] removing mislabelled merge-merged-2840

Comment 13 by rookrishna@chromium.org, Mar 1 2017

Status: Verified (was: Fixed)

►

Issue 654431 link

Issue metadata

Create Policy to control ARC status reporting

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 13 2016

Comment 1 Deleted

Comment 2 by phweiss@chromium.org, Oct 13 2016

Comment 2 Deleted

Comment 3 by dimu@chromium.org, Oct 14 2016

Comment 3 Deleted

Comment 4 by tnagel@chromium.org, Oct 17 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Oct 18 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Oct 18 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Oct 18 2016

Comment 7 Deleted

Comment 8 by phweiss@chromium.org, Oct 18 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Comment 10 Deleted

Comment 11 by dimu@google.com, Nov 4 2016

Comment 11 Deleted

Comment 12 by dimu@google.com, Nov 4 2016

Comment 12 Deleted

Comment 13 by rookrishna@chromium.org, Mar 1 2017

Comment 13 Deleted

Sign in to add a comment