Issue metadata
Sign in to add a comment
|
New test ResourceTest.ProhibitAddRemoveClientInScope fails in official builds |
||||||||||||||||||||
Issue descriptionResourceTest.ProhibitAddRemoveClientInScope is a death test that checks the assertion string. In official builds, assertion strings are compiled out, so the test fails there. See bug 644768 for a similar bug recently. One possible fix is to not check for the string in official builds, but if possible maybe we can prevent using a death test in the first place, since those tend to be slow and flaky anyways.
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae00c62ebebe09617a893da5f920ac735e3fbb3c commit ae00c62ebebe09617a893da5f920ac735e3fbb3c Author: shaochuan <shaochuan@chromium.org> Date: Tue Oct 11 14:40:33 2016 Remove ResourceTest.ProhibitAddRemoveClientInScope unit test Remove this unit test for now, we'll have tests for actual usage of ProhibitAddRemoveClientInScope. Also reverting changes for unit tests in d9143c64. BUG= 654424 Review-Url: https://codereview.chromium.org/2410753002 Cr-Commit-Position: refs/heads/master@{#424421} [modify] https://crrev.com/ae00c62ebebe09617a893da5f920ac735e3fbb3c/third_party/WebKit/Source/core/fetch/MockResourceClients.h [modify] https://crrev.com/ae00c62ebebe09617a893da5f920ac735e3fbb3c/third_party/WebKit/Source/core/fetch/ResourceTest.cpp
,
Nov 1 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by shaochuan@chromium.org
, Oct 11 2016