New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654419 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Revisit SdchManager Latency experiment

Project Member Reported by xunji...@chromium.org, Oct 10 2016

Issue description

In the new SdchSourceStream (https://codereview.chromium.org/2368433002/), I omitted the part where filter sets sdch_manager->SetAllowLatencyExperiment(url_, true).

What's the latency experiment? is it safe to omit this in the new code?


 
*sigh*  Thanks for catching this.

The latency experiment is an ongoing 1% holdback of SDCH requests to evaluate SDCH's performance.  It's only enabled for a specific URL (domain?) once a successful SDCH fetch has been done from that URL (domain?).  If you take a look at ~URLRequestHttpJob you'll see that RecordPacketStats is called with an argument indicating which group the job is in.

While I have no strong attachment to the latency experiment, it is active information that's being reported back via UMA, and if we're going to kill it, we should remove all code related to it and mark the relevant histograms obsolete.  Until that point, I think we should keep it going.  Given that your CL is a refactor CL, I think it needs to retain the information for the latency experiment, and this bug can track removing it at some point in the future.  

WDYT?


Status: Available (was: Untriaged)
Summary: Revisit SdchManager Latency experiment (was: SdchManager Latency experiment ?)
Ah, I see. That makes sense. Thanks for explaining how the code works! I will upload a new patch right away to add back sdch_manager->SetAllowLatencyExperiment(url_, true) part. I will leave this bug open so we can revisit this part of the code.
Status: Archived (was: Available)
I am archiving this bug.
SDCH has been disabled in Chrome since M59. For more details please see  Issue 690070  and blink-dev@ thread https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/nQl0ORHy7sw/HNpR96sqAgAJ.

Sign in to add a comment