New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 654411 link

Starred by 2 users
Status: Fixed
Owner:
█ avayvod@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
dalecur...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

org.chromium.chrome.browser.video.VideoTest fails on low-end devices

Project Member Reported by bauerb@chromium.org, Oct 10 2016 
Since https://codereview.chromium.org/2344353003, org.chromium.chrome.browser.video.VideoTest fails (https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/4047):

[FAIL] org.chromium.chrome.browser.video.VideoTest#testLoadMediaUrl:
java.util.concurrent.TimeoutException: waitForCallback timed out!
  at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:184)
  at org.chromium.chrome.test.util.browser.TabTitleObserver.waitForTitleUpdate(TabTitleObserver.java:50)
  at org.chromium.chrome.browser.video.VideoTest.testLoadMediaUrl(VideoTest.java:42)
  at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
  at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
  at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
  at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
  at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
  at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
  at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
  at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

I think the canplaythrough event doesn't fire on low-end devices, because preloading the movie was disabled in https://codereview.chromium.org/2344353003. I'm going to disable the test on low-end for now, but it would be nice to get the test coverage back. I guess we could just try listening to canplay instead? Given that the video is served from a local file server, I wouldn't expect it to buffer for long enough to hit the timeout.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5132e53026df83d874c6c724dca2dd07e5edf628

commit 5132e53026df83d874c6c724dca2dd07e5edf628
Author: bauerb <bauerb@chromium.org>
Date: Mon Oct 10 14:00:28 2016

Disable VideoTest.testLoadMediaUrl on low-end devices.

TBR=dalecurtis@chromium.org

BUG= 654411 

Review-Url: https://codereview.chromium.org/2405833002
Cr-Commit-Position: refs/heads/master@{#424142}

[modify] https://crrev.com/5132e53026df83d874c6c724dca2dd07e5edf628/chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java

Comment 2 by dalecur...@chromium.org, Oct 18 2016 

Test should just call load() when preload=none.

Comment 3 by dalecur...@chromium.org, Oct 18 2016

Cc: dalecur...@chromium.org
Owner: avayvod@chromium.org
avayod@ seems to be working on these.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ed0f1a962c25e882be130015ba53e7ab14993b

commit 56ed0f1a962c25e882be130015ba53e7ab14993b
Author: avayvod <avayvod@chromium.org>
Date: Wed Oct 19 15:13:03 2016

[Android, Media, Test] Fix VideoTest.java on low-end devices

Call load() on the media element to overcome the forced preload=none on low-end devices.

BUG= 654411 
TEST=run the test locally on a low-end device

Review-Url: https://chromiumcodereview.appspot.com/2425293003
Cr-Commit-Position: refs/heads/master@{#426195}

[modify] https://crrev.com/56ed0f1a962c25e882be130015ba53e7ab14993b/chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java
[modify] https://crrev.com/56ed0f1a962c25e882be130015ba53e7ab14993b/chrome/test/data/android/media/video-play.html

Comment 5 by avayvod@chromium.org, Dec 1 2016

Status: Fixed (was: Assigned)
I think this was fixed by #c4

Comment 6 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled
►

Sign in to add a comment