New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654407 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Print selection is missing some contents / pages

Reported by alex131...@gmail.com, Oct 10 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36

Example URL:
https://reflets.info/le-monde-selon-telegram/

Steps to reproduce the problem:
1. Open the URL
2. Select the content of the article, from "Par Jef Mathiot 6 octobre 2016" to "Excellent conseil."
3. Right-click > Print // Sandwich menu > Print
4. Destination is PDF
5. Ensure "Print selection" is checked

What is the expected behavior?
The preview display the ~9 pages with all selected content, so is the resulting PDF.

What went wrong?
The preview displays only 4 pages, stopping to "et impose l’utilisation du DC auquel l’utilisateur est associé.", so is the resulting PDF.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 53.0.2785.143 x64  Channel: stable
OS Version: 10.0 x64
Flash Version:
 
Components: Internals>Printing
Labels: -Type-Compat -Arch-x86_64 OS-Chrome OS-Linux OS-Mac Type-Bug
Status: Available (was: Unconfirmed)
I suspect either there's some limits to how much text can be selected, or the selected text simply didn't render correctly.
Components: Blink
Took a quick look. The code PrepareFrameAndViewForPrint::CopySelection() is copying all the selected text. It then escape the text and append it to: data:text/html;charset=utf-8, to make a long data: URL. Then it creates a new blink::WebView, sets that as the WebFrame, and tell it to load the data: URL. I have no idea what happens after that inside of Blink though.

Comment 3 by kojii@chromium.org, Mar 10 2017

Components: -Blink UI>Browser>PrintPreview
Components: -UI>Browser>PrintPreview Blink>Loader
Uh, this is definitely a printing + Blink integration issue and I need help from the Blink side to help understand what's wrong. So here's another wild stab at setting the Blink component.

Comment 5 by kojii@chromium.org, Mar 11 2017

Cc: nainar@chromium.org
Components: Blink>CSS

Comment 6 by kojii@chromium.org, Mar 11 2017

Cc: kojii@chromium.org
nainar@, any idea what's happening here? If this isn't related with your work, I'll try other labels, please let me know.

Comment 7 by nainar@chromium.org, Mar 13 2017

Components: -Blink>CSS
I have zero expertise in loading code, sorry. thestig@ could you provide function calls on the Chromium side of things? I can possibly take it from there to explore. Definitely not CSS though. 

Comment 8 by kojii@chromium.org, Mar 13 2017

Components: Blink>Paint
Sorry, I thought PrintBrowser is in your team.

It looks like  issue 699841  was for paint, is this something paint can look into?
Cc: wkorman@chromium.org
Labels: PaintTeamTriaged-20170313 BugSource-User
Blink paint is responsible for generating the paint command stream. Skia generates the pdf.

I mentioned the code in comment 2. Please take a look at PrepareFrameAndViewForPrint::CopySelection().
Cc: -wkorman@chromium.org
Owner: wkorman@chromium.org
Status: Assigned (was: Available)
I have some familiarity here, will look soon.
wkorman: Thank you for taking a look. Some of that code dates back to 2009, so it's "just the way we've always done it" which may not make perfect sense in 2017.
Owner: ----
Status: Available (was: Assigned)
Unfortunately have not been able to get to this. Unassigning self as not clear will be able to look soon.
Project Member

Comment 14 by sheriffbot@chromium.org, May 14 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
The page seems to be behind a paywall now. Closing the bug due to the absence of a way to test/verify.

Sign in to add a comment