New issue
Advanced search Search tips

Issue 654406 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 564674



Sign in to add a comment

Remove kEnablePasswordChangeSupport and clean-up components/autofill/content/renderer/form_autofill_util.cc

Project Member Reported by vabr@chromium.org, Oct 10 2016

Issue description

password_manager::features::kEnablePasswordChangeSupport is no longer used since r414350, we should remove it completely.

Also, in components/autofill/content/renderer/form_autofill_util.cc,  IsFormVisible still contains code excluded from OS_ANDROID. This code can potentially lead to Chrome understanding more submission events as success (by returning false). The code was not used on Android when Android did not have the "Update password?" prompt, to protect users from rewriting a good credential by some misunderstood other content. Now that Android has the update prompt, there is no need for running different checks on Android, and we should remove the non-Android #ifdefs.
 

Comment 1 by vabr@chromium.org, Oct 10 2016

Labels: Hotlist-GoodFirstBug

Comment 3 by vabr@chromium.org, Oct 12 2016

Status: Fixed (was: Available)
https://codereview.chromium.org/2409123002/ just landed. Sadly the BUG= annotation got lost during editing the description, so it won't be posted here automatically. The commit is: https://chromium.googlesource.com/chromium/src/+/3a03743c7be2c81af3390823488db30fa7c1dd29

Thanks for landing this, peary2@.

Sign in to add a comment