New issue
Advanced search Search tips

Issue 654393 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove special handling of non-200 response in SdchPolicyDelegate::OnDictionaryIdError()

Project Member Reported by xunji...@chromium.org, Oct 10 2016

Issue description

This is filed in response to a review comment in https://codereview.chromium.org/2368433002.


The server might send Content-Encoding: sdch with a non-200 body, but it seems like there's no reason that the non-200 body would lead to a corrupt dictionary id.

The special handling of "if (context_->GetResponseCode() != 200)" in SdchPolicyDelegate::OnDictionaryIdError() should be removed. It is kept in the CL above to retain the old behavior, but it's likely not needed.
 
Components: Internals>Network>SDCH
Status: Archived (was: Available)
SDCH has been disabled in Chrome since M59. For more details please see
Issue 690070 and blink-dev@ thread linked there.

The code is removed in  Issue 762686 .

Archiving this bug.

Sign in to add a comment