New issue
Advanced search Search tips

Issue 654355 link

Starred by 2 users
Status: Fixed
Owner:
sullivan@chromium.org
Closed: Oct 2016
Cc:
sullivan@chromium.org
u...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove v8 alerts for heap spaces

Project Member Reported by u...@chromium.org, Oct 10 2016 
We see that alerts for heap spaces are not useful. Could you please remove the following alerts for
v8.browsing*, v8.infinite_scroll_tbmv2, v8.mobile_infinite_scroll_tbmv2, memory.long_running_idle_gmail* benchmarks:
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:code_space:allocated_objects_size_avg
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:code_space:allocated_objects_size_max
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:code_space:effective_size_avg
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:large_object_space:allocated_objects_size_avg
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:large_object_space:allocated_objects_size_max
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:large_object_space:effective_size_avg
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:large_object_space:effective_size_max
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:allocated_objects_size_avg
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:allocated_objects_size_max
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:effective_size_avg
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:effective_size_max
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:new_space:allocated_objects_size_avg
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:new_space:allocated_objects_size_max
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:new_space:effective_size_avg
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:new_space:effective_size_max
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:old_space:allocated_objects_size_avg
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:old_space:allocated_objects_size_max
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:old_space:effective_size_avg
   - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:old_space:effective_size_max

Note that we would like to retain the alerts for the top level heap (v8:heap:{effective*,allocated}).

Comment 1 by nedngu...@google.com, Oct 10 2016

Owner: aiolos@chromium.org
Kari: can you help triaging this request?

Comment 2 by u...@chromium.org, Oct 20 2016 

gentle ping

Comment 3 by sullivan@chromium.org, Oct 27 2016

Owner: sullivan@chromium.org
Status: Fixed (was: Untriaged)
Just to confirm, we are now monitoring:
*/*/*/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg
*/*/*/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_max
*/*/*/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg
*/*/*/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_max

Note that we're also working on making it possible for tests to configure what is monitored, so that this doesn't require an admin to change.

Comment 4 by u...@chromium.org, Oct 28 2016 

Thanks a lot, Annie!

> Note that we're also working on making it possible for tests to configure what is monitored, so that this doesn't require an admin to change.
Looking forward to it :)
►

Sign in to add a comment