Issue metadata
Sign in to add a comment
|
Regression: On restarting browser, Chromium icon is seen in infobar instead of Chrome icon.
Reported by
vvishwak...@etouch.net,
Oct 10 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 55.0.2883.6 (Official Build) 7baa26fcf5c0933d5718c621debbd5d380696639-refs/branch-heads/2883@{#11} (64-bit) OS: Mac (10.10.5, 10.11.4), Linux (14.04 LTS) Precondition: Set Firefox as the default browser. What steps will reproduce the problem? 1) Launch chrome, in omnibox type chrome://restart, to restart the browser. 2) Observe the infowar when browser restarts. On infobar, Chromium icon is seen on left side. On infobar, Chrome icon is seen on left side. This is a Regression issue broken in M-55, below is the bisect info Manual bisect: Good build: 55.0.2881.0 Bad build: 55.0.2882.0 Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/fe50203c3961eedce90e4b3d10c75acfa6552758..626bdde804d615c4582b5c1a78bd8929f83b1ab9?pretty=fuller&n=10000 Suspecting: r423212 Note: Issue is not seen on Windows OS.
,
Oct 11 2016
ainslie@ - do we really intend to display a blue Chrome icon here?
,
Oct 11 2016
+sgabriel
,
Oct 11 2016
re: the choice about using normal colorful chrome logo vs. the blue one I defer to bettes@
,
Oct 11 2016
Yes, we had a long discussion about this last time it came up, and this was the direction from UI.
,
Oct 11 2016
I see that part of that discussion came from the default dialog infobar being yellow, and that being a problem with the full-color and orange app icons. I'm not sure the decision to go with a blue Chrome icon was the best for the world we have today.
,
Nov 28 2016
,
Nov 28 2016
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e33fc4517af8fe393a45ae3987b81a246e6ac160 commit e33fc4517af8fe393a45ae3987b81a246e6ac160 Author: shrike <shrike@chromium.org> Date: Tue Nov 29 02:34:17 2016 Restore default browser infobar icon to full-color Chrome icon. Earlier this year the default browser infobar icon was changed to a stylized blue Chrome icon. This cl, per rpop@, reverts the icon to its original full-color version. R=sky@chromium.org BUG= 654340 Review-Url: https://codereview.chromium.org/2537453004 Cr-Commit-Position: refs/heads/master@{#434839} [modify] https://crrev.com/e33fc4517af8fe393a45ae3987b81a246e6ac160/chrome/browser/ui/startup/default_browser_infobar_delegate.cc [modify] https://crrev.com/e33fc4517af8fe393a45ae3987b81a246e6ac160/chrome/browser/ui/startup/default_browser_infobar_delegate.h
,
Nov 30 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by est...@chromium.org
, Oct 10 2016