Regression : Focus is not displayed properly on checkbox in cast overlay.
Reported by
yfulgaon...@etouch.net,
Oct 10 2016
|
|||||||||
Issue descriptionChrome Version : 55.0.2883.6 (Official Build) 7baa26fcf5c0933d5718c621debbd5d380696639-refs/branch-heads/2883@{#11} (32/64-bit) OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS) Preconditions : 1. Freshly install chrome browser. 2. Please sign-in to chrome using an account which does not have any synced data. What steps will reproduce the problem? 1. Launch chrome, open wrench menu and select ‘Cast’ option. (Cast overlay is seen) 2. In cast overlay, press Tab key twice and observe the focus on ‘Enable casting to cloud-based..’ checkbox. Actual : Focus is not displayed properly on checkbox in cast overlay. Expected : Focus should be properly displayed on checkbox in cast overlay. This is a regression issue broken in ‘M-55’, below is the Manual Regression and Change log URL. Good build : 55.0.2853.0 Bad build : 55.0.2854.2 Change log URL : https://chromium.googlesource.com/chromium/src/+log/55.0.2853.0..55.0.2854.0?pretty=fuller&n=10000 (Unable to narrow down the range using tool as ‘sign-in’ to chrome feature is not available in chromium builds, hence providing suspect from change log) Suspecting: r 416866 or 416960 ? from CL @dbeam : Please help to re-assign if your change is not the cause for this issue.
,
Oct 10 2016
Working on a fix [1], with which the focus shadow will look like in this attached image. I made it slightly smaller than the original so that it doesn't overlap with the adjacent text. [1] https://codereview.chromium.org/2403213002/
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/079426cf1940176c4a9307e3ef1b60e34135ea03 commit 079426cf1940176c4a9307e3ef1b60e34135ea03 Author: takumif <takumif@chromium.org> Date: Tue Oct 11 02:55:41 2016 Fix the size of the focus shadow on a checkbox in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. I've uploaded a screenshot of the checkbox with this fix to the bug thread. [1] https://codereview.chromium.org/2314283002 BUG= 654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2403213002 Cr-Commit-Position: refs/heads/master@{#424355} [modify] https://crrev.com/079426cf1940176c4a9307e3ef1b60e34135ea03/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
,
Oct 11 2016
I'd like to request a merge to M55.
,
Oct 12 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1384aee35f6a67a8111d2c23a5657706fc0dfdbc commit 1384aee35f6a67a8111d2c23a5657706fc0dfdbc Author: Derek Cheng <imcheng@chromium.org> Date: Wed Oct 12 18:41:34 2016 Fix the size of the focus shadow on a checkbox in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. I've uploaded a screenshot of the checkbox with this fix to the bug thread. [1] https://codereview.chromium.org/2314283002 BUG= 654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2403213002 Cr-Commit-Position: refs/heads/master@{#424355} (cherry picked from commit 079426cf1940176c4a9307e3ef1b60e34135ea03) Review URL: https://codereview.chromium.org/2412493007 . Cr-Commit-Position: refs/branch-heads/2883@{#69} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1384aee35f6a67a8111d2c23a5657706fc0dfdbc/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
,
Oct 12 2016
,
Oct 13 2016
Tested the issue on windows 7 ,Mac 10.11.4 & Linux Ubuntu 14.04 using chrome version 55.0.2883.11 with the steps mentioned in comment #0.Fix is working fine & Focus displayed properly on checkbox in cast overlay. Please find the attached screenshot for the same. Adding TE-Verified labels.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1384aee35f6a67a8111d2c23a5657706fc0dfdbc commit 1384aee35f6a67a8111d2c23a5657706fc0dfdbc Author: Derek Cheng <imcheng@chromium.org> Date: Wed Oct 12 18:41:34 2016 Fix the size of the focus shadow on a checkbox in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. I've uploaded a screenshot of the checkbox with this fix to the bug thread. [1] https://codereview.chromium.org/2314283002 BUG= 654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2403213002 Cr-Commit-Position: refs/heads/master@{#424355} (cherry picked from commit 079426cf1940176c4a9307e3ef1b60e34135ea03) Review URL: https://codereview.chromium.org/2412493007 . Cr-Commit-Position: refs/branch-heads/2883@{#69} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1384aee35f6a67a8111d2c23a5657706fc0dfdbc/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sko...@chromium.org
, Oct 10 2016Owner: taku...@chromium.org