New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 654323 link

Starred by 3 users
Status: Duplicate
Merged: issue 710225
Owner:
dpa...@chromium.org
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
dbeam@chromium.org
█ scottchen@chromium.org
tbuck...@chromium.org
█ tkonch...@chromium.org
esprehn@chromium.org
█ ranjitkan@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: [MD Settings]Spacing issue issuer is seen between text and LHS border on drop-down list.

Reported by dchau...@etouch.net, Oct 10 2016 
Chrome Version: 55.0.2883.6 (Official Build)7baa26fcf5c0933d5718c621debbd5d380696639-refs/branch-heads/2883@{#11} 32/64-bit.
OS: Windows(7,8,10).

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome;//md-settings page.
2. Click to open any drop-down list or 'Page zoom' drop down list under 'Appearance' section and observe.

Spacing is not proper between zoom level and LHS border of drop down list and looks weird.
Spacing should be proper between zoom level and LHS border of drop down list.

This is a regression issue, broken in M-55 series, will soon update other info.

Comment 1 by dchau...@etouch.net, Oct 10 2016

Cc: ranjitkan@chromium.org tkonch...@chromium.org nyerramilli@chromium.org
Components: UI>Settings
Labels: hasbisect OS-Linux
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Below is manual regression range and bisect info for the above issue.

Good build: 55.0.2880.0
Bad build: 55.0.2881.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/e512d0ade4defa8e154ae5f82e683d9aac31c3d7..2673b44190275c1faaea0cc90222e8a3ff95479c?pretty=fuller&n=10

Suspecting: r422955

Note; This issue is not seen on 'Mac' OS.

Kindly review the attached screen-cast for reference.
Actual Screenshot.png
12.2 KB View Download
Actual behavior.mp4
869 KB View Download

Comment 2 by dpa...@chromium.org, Oct 10 2016

Cc: dbeam@chromium.org
Labels: -Pri-1 Proj-MaterialDesign-WebUI Pri-2
Status: WontFix (was: Assigned)

Comment 3 by dpa...@chromium.org, Oct 10 2016

Status: Assigned (was: WontFix)

Comment 4 by dbeam@chromium.org, Oct 11 2016

Cc: esprehn@chromium.org
is there any CSS customization we can do here?

Comment 5 by dpa...@chromium.org, Oct 11 2016 

We can add padding on the <select>, but that adds the padding both for the click target and for the expanded <option>s.

Comment 6 by dpa...@chromium.org, Oct 11 2016 

See an example 10px padding attached.
select_padding.png
95.5 KB View Download

Comment 7 by dbeam@chromium.org, Oct 11 2016 

fwiw: we can probably think of a fancy way to clip off some left padding on the <select> control/anchor and still show the menu with extra start padding

Comment 8 by derat@chromium.org, Oct 21 2016

Cc: steve...@chromium.org dpa...@chromium.org tbuck...@chromium.org
 Issue 658281  has been merged into this issue.

Comment 9 by dbeam@chromium.org, Jan 30 2017

Cc: -dpa...@chromium.org scottchen@chromium.org
Labels: -M-55 Hotlist-MD-Settings-General

Comment 10 by dpa...@chromium.org, Mar 8 2017 

@dbeam: I briefly tried a few things to get the padding only on the expanded options without success. Also I noticed that we already add a padding (both collapsed and expanded) for settings-dropdown-menu, see [1], which is  the same approach shown at comment#6. How about we just add the padding to all our <select>s instead. Personally I find the padding on the collapsed state, not so bad, compared to no padding at all.

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/controls/settings_dropdown_menu.html?q=settings_Dropdown&l=19-21

Comment 11 by dpa...@chromium.org, Mar 8 2017 

BTW, I am also just noticing that in settings-dropdown-menu, we should be using -webkit-padding-start, not -webkit-margin-start. The latter breaks the way the MD underline looks.
select_margin_breaks_underline.png
28.0 KB View Download

Comment 12 by dpa...@chromium.org, Apr 11 2017

Mergedinto: 710225
Status: Duplicate (was: Assigned)
►

Sign in to add a comment