New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654312 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Failed steps failed compile: Win (32, 64 & Pgo), Mac & Linux beta on official.desktop builder for build 54.0.2840.54

Project Member Reported by ranjitkan@chromium.org, Oct 10 2016

Issue description

Link to Build:
-------------
https://uberchromegw.corp.google.com/i/official.desktop/builders/win/builds/1148
https://uberchromegw.corp.google.com/i/official.desktop/builders/win64/builds/1136
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/1140
https://uberchromegw.corp.google.com/i/official.desktop/builders/precise64/builds/1142
https://uberchromegw.corp.google.com/i/official.desktop/builders/win-pgo/builds/531
https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-pgo/builds/378

Link to Log Path:
------------------
https://uberchromegw.corp.google.com/i/official.desktop/builders/win/builds/1148/steps/compile/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop/builders/win64/builds/1136/steps/compile/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/1140/steps/compile/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop/builders/precise64/builds/1142/steps/compile/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop/builders/win-pgo/builds/531/steps/Compile%3A%20Instrumentation%20phase./logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-pgo/builds/378/steps/Compile%3A%20Instrumentation%20phase./logs/stdio

Error from the log:
--------------------
FAILED: obj/components/autofill/content/renderer/renderer/password_generation_agent.obj 
ninja -t msvc -e environment.x86 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/components/autofill/content/renderer/renderer/password_generation_agent.obj.rsp /c ../../components/autofill/content/renderer/password_generation_agent.cc /Foobj/components/autofill/content/renderer/renderer/password_generation_agent.obj /Fd"obj/components/autofill/content/renderer/renderer_cc.pdb"
c:\b\build\slave\win\build\src\components\autofill\content\renderer\password_generation_agent.cc(193): error C2065: 'binding_': undeclared identifier
c:\b\build\slave\win\build\src\components\autofill\content\renderer\password_generation_agent.cc(193): error C2228: left of '.Close' must have class/struct/union
c:\b\build\slave\win\build\src\components\autofill\content\renderer\password_generation_agent.cc(193): note: type is 'unknown-type'
[28993/40158] CXX obj/components/autofill/content/renderer/renderer/password_autofill_agent.obj
FAILED: obj/components/autofill/content/renderer/renderer/password_autofill_agent.obj 
ninja -t msvc -e environment.x86 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/components/autofill/content/renderer/renderer/password_autofill_agent.obj.rsp /c ../../components/autofill/content/renderer/password_autofill_agent.cc /Foobj/components/autofill/content/renderer/renderer/password_autofill_agent.obj /Fd"obj/components/autofill/content/renderer/renderer_cc.pdb"
c:\b\build\slave\win\build\src\components\autofill\content\renderer\password_autofill_agent.cc(1156): error C2065: 'binding_': undeclared identifier
c:\b\build\slave\win\build\src\components\autofill\content\renderer\password_autofill_agent.cc(1156): error C2228: left of '.Close' must have class/struct/union
c:\b\build\slave\win\build\src\components\autofill\content\renderer\password_autofill_agent.cc(1156): note: type is 'unknown-type'
[28994/40158] CXX obj/chrome/test/test_support/testing_browser_process.obj
[28995/40158] CXX obj/chrome/utility/utility/importer.obj
[28996/40158] CXX obj/chrome/utility/utility/importer_creator.obj
[28997/40158] CXX obj/components/autofill/content/renderer/renderer/renderer_save_password_progress_logger.obj
[28998/40158] CXX obj/components/constrained_window/constrained_window/constrained_window_views.obj
[28999/40158] CXX obj/chrome/utility/utility/nss_decryptor.obj
[29000/40158] CXX obj/chrome/test/test_support/test_browser_window_aura.obj
[29001/40158] CXX obj/chrome/test/test_support/dialog_test_browser_window.obj
[29002/40158] CXX obj/components/autofill/content/browser/browser/fingerprint.obj
[29003/40158] CXX obj/chrome/utility/utility/image_writer_handler.obj
[29004/40158] CXX obj/chrome/utility/utility/pmp_column_reader.obj
[29005/40158] CXX obj/chrome/utility/utility/picasa_album_table_reader.obj
[29006/40158] CXX obj/components/browser_sync/browser/browser/profile_sync_components_factory_impl.obj
[29007/40158] CXX obj/chrome/utility/utility/picasa_albums_indexer.obj
[29008/40158] CXX obj/chrome/utility/utility/iapps_xml_utils.obj
[29009/40158] CXX obj/components/autofill/content/browser/browser/content_autofill_driver_factory.obj
[29010/40158] CXX obj/chrome/utility/utility/image_writer.obj
[29011/40158] CXX obj/chrome/utility/utility/itunes_library_parser.obj
[29012/40158] CXX obj/components/autofill/content/renderer/renderer/autofill_agent.obj
[29013/40158] CXX obj/components/browser_sync/browser/test_support/profile_sync_service_mock.obj
[29014/40158] CXX obj/chrome/utility/utility/firefox_importer.obj
[29015/40158] CXX obj/components/autofill/content/browser/browser/content_autofill_driver.obj
[29016/40158] CXX obj/components/autofill/content/common/common/autofill_message_generator.obj
[29017/40158] CXX obj/chrome/utility/utility/profile_import_handler.obj
[29018/40158] CXX obj/chrome/utility/utility/ie_importer_win.obj
[29019/40158] CXX obj/components/app_modal/app_modal/javascript_app_modal_dialog_views.obj
[29020/40158] CXX obj/components/browser_sync/browser/browser/profile_sync_service.obj
[29021/40158] CXX obj/chrome/utility/utility/extensions_handler.obj
[29022/40158] CXX obj/chrome/test/test_support/testing_profile.obj
[29023/40158] CXX obj/components/browser_sync/browser/test_support/abstract_profile_sync_service_test.obj
[29024/40158] CXX obj/chrome/test/media_router/media_router_browsertests/media_router_integration_ui_browsertest.obj
[29025/40158] CXX obj/components/browser_sync/browser/test_support/profile_sync_test_util.obj
ninja: build stopped: subcommand failed.

C:\b\build\scripts\slave\gsutil.bat cp file://c:\users\chrome~1\appdata\local\temp\tmpcvfkyi gs://chrome-goma-log/2016/10/09/win-13-m0/ninja_log.win-13-m0.chrome-bot.20161008-183205.3824.gz

C:\b\build\slave\win\build\src>set HOME=C:\Users\chrome-bot 

C:\b\build\slave\win\build\src>call python C:\b\build\scripts\slave\..\..\..\depot_tools\gsutil.py -- cp file://c:\users\chrome~1\appdata\local\temp\tmpcvfkyi gs://chrome-goma-log/2016/10/09/win-13-m0/ninja_log.win-13-m0.chrome-bot.20161008-183205.3824.gz 
Copying file://c:\users\chrome~1\appdata\local\temp\tmpcvfkyi [Content-Type=application/octet-stream]...
Copied log file to gs://chrome-goma-log/2016/10/09/win-13-m0/ninja_log.win-13-m0.chrome-bot.20161008-183205.3824.gz
Visualization at http://chromium-build-stats.appspot.com/ninja_log/2016/10/09/win-13-m0/ninja_log.win-13-m0.chrome-bot.20161008-183205.3824.gz
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 0 B/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 72 KiB/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 144 KiB/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 216 KiB/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 288 KiB/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 360 KiB/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 432 KiB/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 504 KiB/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 576 KiB/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 648 KiB/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 720 KiB/749.56 KiB    
Uploading   ...log.win-13-m0.chrome-bot.20161008-183205.3824.gz: 749.56 KiB/749.56 KiB    

Change Log: https://chromium.googlesource.com/chromium/src/+log/54.0.2840.53..54.0.2840.54?pretty=fuller&n=10000

From the code suspecting change #414607 could be the possible culprit.

Change URL: https://chromium.googlesource.com/chromium/src/+/2524a5f430bcc8cbc1e8d0c47c5047ba696c7f04
Review-Url: https://codereview.chromium.org/2320993002
Review URL: https://codereview.chromium.org/2400393003 

@vabr - Assigning to you, request you to please take a look into it, as the following CL was reviewed by you. Please help us to reassign if not with respect to this changes.
 

Comment 1 by leon....@intel.com, Oct 10 2016

Hi, I've landed the fix CL: https://codereview.chromium.org/2406773002 . Although the CL is still open, it's been landed in fact. I don't know why and I've described such case at issue 641156.

I should have been more carefully when doing cherry-pick, sorry for the trouble..

Comment 2 by gov...@chromium.org, Oct 10 2016

Cc: ligim...@chromium.org bustamante@chromium.org

Comment 3 by vabr@chromium.org, Oct 10 2016

Cc: vabr@chromium.org
Owner: leon....@intel.com
Status: Fixed (was: Assigned)
Confirming that the fix mentioned in #1 indeed landed on 2840: https://chromium.googlesource.com/chromium/src.git/+/ce5066548c74c635d3c0477b1a42269a550550f7 and the builders look compiling OK now.

Closing as fixed with leon.han as owner for now, because they made and landed the fix. Please re-open and feel free to assign to me if you see the failure again.

Comment 4 Deleted

Cc: loyso@chromium.org nek...@chromium.org treib@chromium.org alph@chromium.org
Mergedinto: 654178
Status: Duplicate (was: Fixed)
Cc: -vabr@chromium.org

Sign in to add a comment