New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654300 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Login pod flashes white rectangle and user name on startup, logout

Project Member Reported by jamescook@chromium.org, Oct 9 2016

Issue description

Google Chrome	55.0.2878.0 (Official Build) dev (64-bit)
Revision	0
Platform	8861.0.0 (Official Build) dev-channel samus
ARC	3320697

1. Boot device, watch closely
2. At the login screen you'll see a white rectangle with the user's name ("John Sample") for a few frames, which will be replaced with the login pod "Password" field.

This is a regression, but I'm not sure how recent.

 
Owner: jdufault@chromium.org
Status: Assigned (was: Untriaged)
jdufault@ I know you'd looked at speeding up loading for lock screen. This seems unlikely to be related, but I'm wondering if you have ideas here?
Cc: jdufault@chromium.org alemate@chromium.org
Owner: sammiequon@chromium.org
Assigning to sammiequon@ who has been making the vast majority of changes in this code for the past few months.

My best guess is that pod rendering is somehow getting blocked until polymer finishes loading.

cc alemate@ if he has any ideas.
Cc: achuith@chromium.org
 Issue 654711  has been merged into this issue.
Components: UI>Shell>StartScreen
Labels: M-55 ReleaseBlock-Stable
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a77a4ddde837ba57fca3195127cd4f1ad8f96eab

commit a77a4ddde837ba57fca3195127cd4f1ad8f96eab
Author: sammiequon <sammiequon@chromium.org>
Date: Mon Oct 24 21:18:22 2016

cros: Fixed 3 bugs for pin unlock.

User name would flash on startup before the rest of the user pod. Pin keyboard would show up for users with disabled keyboards and the easy unlock icon would clash with the re-authentication icon. I hide the easy unlock icon whenever the re-authentication icon is shown.

BUG= 655221,  654300 , 655308
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2427073002
Cr-Commit-Position: refs/heads/master@{#427152}

[modify] https://crrev.com/a77a4ddde837ba57fca3195127cd4f1ad8f96eab/chrome/browser/resources/chromeos/login/lock.js
[modify] https://crrev.com/a77a4ddde837ba57fca3195127cd4f1ad8f96eab/ui/login/account_picker/screen_account_picker.js
[modify] https://crrev.com/a77a4ddde837ba57fca3195127cd4f1ad8f96eab/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/a77a4ddde837ba57fca3195127cd4f1ad8f96eab/ui/login/account_picker/user_pod_template.html

Labels: Merge-Request-55
Labels: -Merge-Request-55 Merge-Approved-55
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/276b05086f2b3aafe37af09fe3d5a054abee8d05

commit 276b05086f2b3aafe37af09fe3d5a054abee8d05
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Oct 27 18:22:07 2016

cros: Fixed 3 bugs for pin unlock.

User name would flash on startup before the rest of the user pod. Pin keyboard would show up for users with disabled keyboards and the easy unlock icon would clash with the re-authentication icon. I hide the easy unlock icon whenever the re-authentication icon is shown.

BUG= 655221,  654300 , 655308
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2427073002
Cr-Commit-Position: refs/heads/master@{#427152}
(cherry picked from commit a77a4ddde837ba57fca3195127cd4f1ad8f96eab)

Review URL: https://codereview.chromium.org/2458763002 .

Cr-Commit-Position: refs/branch-heads/2883@{#341}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/276b05086f2b3aafe37af09fe3d5a054abee8d05/chrome/browser/resources/chromeos/login/lock.js
[modify] https://crrev.com/276b05086f2b3aafe37af09fe3d5a054abee8d05/ui/login/account_picker/screen_account_picker.js
[modify] https://crrev.com/276b05086f2b3aafe37af09fe3d5a054abee8d05/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/276b05086f2b3aafe37af09fe3d5a054abee8d05/ui/login/account_picker/user_pod_template.html

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/276b05086f2b3aafe37af09fe3d5a054abee8d05

commit 276b05086f2b3aafe37af09fe3d5a054abee8d05
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Oct 27 18:22:07 2016

cros: Fixed 3 bugs for pin unlock.

User name would flash on startup before the rest of the user pod. Pin keyboard would show up for users with disabled keyboards and the easy unlock icon would clash with the re-authentication icon. I hide the easy unlock icon whenever the re-authentication icon is shown.

BUG= 655221,  654300 , 655308
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2427073002
Cr-Commit-Position: refs/heads/master@{#427152}
(cherry picked from commit a77a4ddde837ba57fca3195127cd4f1ad8f96eab)

Review URL: https://codereview.chromium.org/2458763002 .

Cr-Commit-Position: refs/branch-heads/2883@{#341}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/276b05086f2b3aafe37af09fe3d5a054abee8d05/chrome/browser/resources/chromeos/login/lock.js
[modify] https://crrev.com/276b05086f2b3aafe37af09fe3d5a054abee8d05/ui/login/account_picker/screen_account_picker.js
[modify] https://crrev.com/276b05086f2b3aafe37af09fe3d5a054abee8d05/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/276b05086f2b3aafe37af09fe3d5a054abee8d05/ui/login/account_picker/user_pod_template.html

Status: Fixed (was: Started)
Should we merge to M54 too?

This bug reproduces on 54.0.2840.79 (official)
8743.76.0 stable-channel peppy

Comment 14 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 15 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Cc: dhadd...@chromium.org sdantul...@chromium.org rookrishna@chromium.org
 Issue 633412  has been merged into this issue.
Status: Verified (was: Fixed)
55.0.2883.54/8872.54.0

Sign in to add a comment