New issue
Advanced search Search tips

Issue 654283 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Compile failure on xenial (missing bluetooth_low_energy.h)

Project Member Reported by robho...@gmail.com, Oct 9 2016

Issue description

[robert@mwenge WebKit (master)]$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.1 LTS
Release:        16.04
Codename:       xenial


[robert@mwenge WebKit (master)]$ ninja -C ../../out/Release chrome
ninja: Entering directory `../../out/Release'
[23/6748] CXX obj/extensions/browser/guest_view/extension_options/extension_options/extension_options_guest.o
FAILED: obj/extensions/browser/guest_view/extension_options/extension_options/extension_options_guest.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/extensions/browser/guest_view/extension_options/extension_options/extension_options_guest.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=282487-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUSING_V8_SHARED -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos -I../../gpu -I../../third_party/libwebp -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/mesa/src/include -I../../third_party/libwebm/source -I../../third_party/opus/src/include -Igen -I../../third_party/ced/src -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/home/robert/Dev/blink/src=. -pthread -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -fno-ident -fdata-sections -ffunction-sections -g0 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wno-unused-function -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../extensions/browser/guest_view/extension_options/extension_options_guest.cc -o obj/extensions/browser/guest_view/extension_options/extension_options/extension_options_guest.o
In file included from ../../extensions/browser/guest_view/extension_options/extension_options_guest.cc:19:
In file included from ../../extensions/browser/api/extensions_api_client.h:12:
In file included from ../../extensions/browser/api/declarative_content/content_rules_registry.h:12:
../../extensions/browser/api/declarative/rules_registry.h:24:10: fatal error: 'extensions/common/api/events.h' file not found
#include "extensions/common/api/events.h"
         ^
1 error generated.
[28/6748] CXX obj/components/autofill/core/browser/proto/proto/server.pb.o
ninja: build stopped: subcommand failed.

 

Comment 1 by robho...@gmail.com, Oct 9 2016

Components: -Blink>DOM>Events Platform>Extensions>API
If you try building again, does it work? extensions/common/api/events.h is a generated file, so it's probably due to some missing dependency + bad luck, rather than being a xenial-specific bug.

Comment 3 by robho...@gmail.com, Oct 10 2016

It's been happening for a week or two now - about four builds in a row. I zapped the folder a couple of times too.
Cc: thomasanderson@chromium.org
Building on xenial works for me.  What's in your out/Release/args.gn?

Comment 5 by robho...@gmail.com, Oct 11 2016

Here you go:

# Build arguments go here. Examples:
is_component_build = true
is_debug = false
enable_nacl = false
dcheck_always_on = true
symbol_level = 0
# See "gn args <out_dir> --list" for available build arguments.


Comment 6 by robho...@gmail.com, Oct 12 2016

It alternates with failing to find this file:

[robert@mwenge WebKit (master)]$ time ninja -C ../../out/Release chrome
ninja: Entering directory `../../out/Release'
[16/9373] CXX obj/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy/bluetooth_api_advertisement.o
FAILED: obj/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy/bluetooth_api_advertisement.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy/bluetooth_api_advertisement.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=283753-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/home/robert/Dev/blink/src=. -pthread -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -fno-ident -fdata-sections -ffunction-sections -g0 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../extensions/browser/api/bluetooth_low_energy/bluetooth_api_advertisement.cc -o obj/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy/bluetooth_api_advertisement.o
In file included from ../../extensions/browser/api/bluetooth_low_energy/bluetooth_api_advertisement.cc:5:
In file included from ../../extensions/browser/api/bluetooth_low_energy/bluetooth_api_advertisement.h:14:
../../extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h:29:10: fatal error: 'extensions/common/api/bluetooth_low_energy.h' file not found
#include "extensions/common/api/bluetooth_low_energy.h"
         ^
1 error generated.
[19/9373] CXX obj/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy/bluetooth_low_energy_event_router.o
FAILED: obj/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy/bluetooth_low_energy_event_router.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy/bluetooth_low_energy_event_router.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=283753-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/home/robert/Dev/blink/src=. -pthread -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -fno-ident -fdata-sections -ffunction-sections -g0 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc -o obj/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy/bluetooth_low_energy_event_router.o
In file included from ../../extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc:5:
../../extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h:29:10: fatal error: 'extensions/common/api/bluetooth_low_energy.h' file not found
#include "extensions/common/api/bluetooth_low_energy.h"
         ^
1 error generated.
[21/9373] CXX obj/components/about_handler/about_handler/about_protocol_handler.o
ninja: build stopped: subcommand failed.

real    0m4.454s
user    0m9.956s
sys     0m0.980s
[robert@mwenge WebKit (master)]$ find ../../out/Release -iname bluetooth_low_energy.h
[robert@mwenge WebKit (master)]$ 

Labels: TE-NeedsTraigeHelp

Comment 8 by robho...@gmail.com, Oct 12 2016

OK, I can avoid the compile failure if I do:

ninja -C ../../out/Release chrome; ninja -C ../../out/Release blink_tests;

on a clean build dir.

However if I do:

ninja -C ../../out/Release blink_tests; ninja -C ../../out/Release chrome;

it fails.

So it looks like it's not possible to build chrome in the same directory as a blink_tests build?

Comment 9 by robho...@gmail.com, Oct 12 2016

Components: -Platform>Extensions>API
Labels: -TE-NeedsTraigeHelp TE-NeedsTriageHelp
Cc: st...@chromium.org

Comment 11 by st...@chromium.org, Oct 29 2016

Looks like another instance of crbug.com/655123

Components: Build
Labels: Build-Tools-GN
Cc: -st...@chromium.org
Owner: st...@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Compile failure on xenial (missing bluetooth_low_energy.h) (was: Compile failure on xenial)
I've encountered the errors in #c6 as well. On Mac.

"enable_nacl = false" seems to be a common element.

This probably regressed in r421700. But it seems to be fixed (on Mac).


A remaining problem might be that

bluetooth_low_energy_event_router.h has #include "extensions/common/api/bluetooth_low_energy.h"

and

bluetooth_low_energy_apitest.cc has #include "extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h"


bluetooth_low_energy_apitest is Linux/ChromeOS only (intended?):
    if (is_chromeos || (is_linux && use_dbus)) {
      sources += [ "../browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc" ]
    }


But it means browser_tests probably needs a harder dependency on the file that generates bluetooth_low_energy.h . Maybe it does now have this.

A nicer approach might be to forward declare enough in bluetooth_low_energy_event_router.h so it doesn't need the bluetooth_low_energy.h #include, but I dunno how feasible that is.

Owner: r...@chromium.org
Owner: jhawkins@chromium.org
Bluetooth -> jhawkins@

Sign in to add a comment