Issue metadata
Sign in to add a comment
|
Native Mac Page Info: Permission labels overlap dropdowns in languages with long strings |
|||||||||||||||||||||||||||||
Issue descriptionVersion: Version 56.0.2885.0 canary (64-bit) OS: Mac OS 10.11.6 What steps will reproduce the problem? (1) visit google.com (2) click on the Page Info Button (3) What is the expected output? No overlappings. What do you see instead? There are overlappings. Please use labels and text to provide additional information. Screenshots are attached. This is a regression. But in Chrome Stable it is also broken. There you do not see the selector after long descriptions.
,
Oct 10 2016
Tested in chrome canary #56.0.2886.0 on Mac 10.12 and able to reproduce the issue. Below are the Bisect Details: ============= Good Build: 55.0.2856.0(417772) Bad Build: 55.0.2857.0(417845) Bisect URL: =========== You are probably looking for a change made after 417827 (known good), but no later than 417828 (first known bad). CHANGE LOG URL: https://chromium.googlesource.com/chromium/src/+log/539b00c243870d602bd89bbcdcf425d65553c1f5..f9714c66fa583e02eebe807ac5b82d01813efbd4 Note : Not able to reproduce the issue in Win 10.0,ubuntu 14.04 @lgarron Request to look in to this. Thank you.
,
Oct 11 2016
This is working as intended. We had to make an engineering tradeoff, and decided that the new behaviour wasn't substantially more broken than the current situation. There is no quick fix, since we don't have a mechanism like the Views hierarchy to handle automatic layout/sizing decisions, but I'll leave it as available in case someone (maybe me) has time to pick it up and improve it.
,
Oct 11 2016
,
Oct 11 2016
I think this looks much worse than before. pinkerton@ - what is your opinion? If this cannot be fixed without a lot of effort let's just revert to the old dialog on the Mac and ship a corrected one in MacViews.
,
Oct 11 2016
,
Oct 11 2016
> If this cannot be fixed without a lot of effort let's just revert to the old dialog on the Mac and ship a corrected one in MacViews. What's the status with MacViews? I noticed the experiment has ended, but one reason we didn't want to put too much effort into this is because MacViews might obsolete it. Note that there is a simple solution that works for most languages: make the dialogue wider. But 1) I don't know if there is a good blanket "wide enough" value that doesn't look ridiculously wide. 2) I don't know if the code is robust enough to handle dynamic sizing based on actual string widths.
,
Oct 11 2016
Hmm, thought of another option: Emulate the old behaviour for rows that are too wide.
,
Oct 11 2016
MacViews is still a work-in-progress. It's not an option for shipping this in M55 (or M56), but it/Harmony will be required to work correctly when wide strings throw off the original layout.
,
Oct 11 2016
+ellyjones I think the new way is worse than the old way as you cannot even read the value when it's overlapping. That's the entire point of this page info bubble: information! Emulating the old behavior for rows that are too wide is a reasonable fallback. Elly can discuss the state of this bubble in MacViews, but as Jayson says, it won't be m55 or m56.
,
Oct 14 2016
,
Oct 19 2016
,
Oct 19 2016
Everyone: Just to confirm, the the old behaviour is sufficient to remove the ReleaseBlock-Stable, right?
,
Oct 19 2016
Are you talking about switching back to the old UI or fixing the new UI to conform to the old behavior?
,
Oct 19 2016
re#14: we will detect these scenarios, and in only these scenarios, will fix the new UI to conform to the old behavior. Does that sound reasonable?
,
Oct 19 2016
Is the plan to ship the new Mac UI but fall back to the old UI when the strings are too long, or to fix the new Mac UI so that it works with long strings?
,
Oct 19 2016
The former (ship the new Mac UI but fall back to the old UI when the strings are too long), unless there's an alternate proposal that won't be super complex to implement.
,
Oct 20 2016
,
Oct 20 2016
It sounds like an OK solution.
,
Oct 25 2016
Gentle Ping.!, Can we have an update on the fix. Issue is marked with a Stable blocker and M55 is already in Beta. Thanks.!
,
Oct 26 2016
lgarron@ - can we get an ETA for the fix?
,
Oct 26 2016
**** Bulk edit - please ignore if not applicable **** A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
,
Oct 26 2016
Next week? I have some other high-priority stuff.
,
Oct 27 2016
If fix is landed and merged to M55 by next week will be great.
,
Oct 31 2016
Just to update issue still seen on Mac 10.11.6 using 56.0.2905.0.
,
Oct 31 2016
**** Bulk edit - please ignore if not applicable **** A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
,
Nov 2 2016
So, it actually turned out to be easier to truncate the labels, as suggested by Max [1]. shrike@: Does this look okay to you? [1] https://crbug.com/512442#c58
,
Nov 3 2016
Changing status to signal that this is in progress: https://codereview.chromium.org/2471253003
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d4e9096b9e299a1d910c2647c6328f30110b0c2 commit 4d4e9096b9e299a1d910c2647c6328f30110b0c2 Author: lgarron <lgarron@chromium.org> Date: Thu Nov 03 19:14:11 2016 Page Info (native Mac): truncate permission labels and add tooltip. BUG= 654268 TEST=Try the following on Mac twice, once with Chrome set to German, once with it set to Arabic (change this in `System Preferences.app` > `Language & Region` > Add to `Preferred languages:` and drag to top). 1) Visit google.com and click on the lock icon in the omnibox to open Page Info 2) Verify that the last permission (MIDI, with a keyboard icon) has a label is truncated using an ellipsis (note: Hebrew is an RTL language, so the ellipsis for it should be on the left) 3) Hover over the label, and check that it shows a full version of the truncated string. Review-Url: https://codereview.chromium.org/2471253003 Cr-Commit-Position: refs/heads/master@{#429665} [modify] https://crrev.com/4d4e9096b9e299a1d910c2647c6328f30110b0c2/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
,
Nov 3 2016
I checked with lgarron@ and he says they are read out correctly.
,
Nov 3 2016
How does the truncated label work with VoiceOver/a11y tools? We should ensure that the label are fully readable for those who can't use the tooltip.
,
Nov 3 2016
pinkerton: VoiceOver will read the full text. Note on the TEST=: Arabic actually doesn't overflow. However, Hebrew instead of Arabic should work.
,
Nov 3 2016
Great, thanks!
,
Nov 3 2016
This has *not* landed on Canary yet, but tagging this with a merge request. (Advice about an appropriate merge schedule for this would be appreciated.)
,
Nov 4 2016
Hello lgarron@: I am seeing, that the Page Info Bubble is no longer aligned under the lock. I am using a non-retina Macbook Air. Not sure, if this is caused by your latest change? Please see the screenshot. Should I open a separat report for this issue? Thanks.
,
Nov 4 2016
I did a bisect: https://chromium.googlesource.com/chromium/src/+log/192ccd60638f4cfa0b4b0ea89c896bb323c57871..75863c4176f633730b0388893f46ccafaad4cc88 Your change is unrelated. It seems this one is the culprit https://chromium.googlesource.com/chromium/src/+/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c I'll open a new report for this.
,
Nov 4 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16886bfae4dff4896be1047f580b19aa2a08e14f commit 16886bfae4dff4896be1047f580b19aa2a08e14f Author: Lucas Garron <lgarron@chromium.org> Date: Fri Nov 04 20:50:20 2016 Page Info (native Mac): truncate permission labels and add tooltip. BUG= 654268 TEST=Try the following on Mac twice, once with Chrome set to German, once with it set to Hebrew (change this in `System Preferences.app` > `Language & Region` > Add to `Preferred languages:` and drag to top). 1) Visit google.com and click on the lock icon in the omnibox to open Page Info 2) Verify that the last permission (MIDI, with a keyboard icon) has a label is truncated using an ellipsis (note: Hebrew is an RTL language, so the ellipsis for it should be on the left) 3) Hover over the label, and check that it shows a full version of the truncated string. Review-Url: https://codereview.chromium.org/2471253003 Cr-Commit-Position: refs/heads/master@{#429665} (cherry picked from commit 4d4e9096b9e299a1d910c2647c6328f30110b0c2) Review URL: https://codereview.chromium.org/2473313005 . Cr-Commit-Position: refs/branch-heads/2883@{#462} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/16886bfae4dff4896be1047f580b19aa2a08e14f/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
,
Nov 9 2016
|
||||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||||
Comment 1 by tapted@chromium.org
, Oct 10 2016Status: Assigned (was: Untriaged)