New issue
Advanced search Search tips

Issue 654251 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebAPK crashes on first run

Project Member Reported by pkotw...@chromium.org, Oct 9 2016

Issue description

Repro steps:
1) Add the following command line options to the Chrome command line
  --check-for-web-manifest-update-on-startup
  --webapk-server-url="https://www.google.com/nonexistant"
2) Launch a WebAPK for the first time
3) Wait 5 minutes

Expected:
The WebAPK launches in fullscreen and does not crash
Actual:
The WebAPK launches in fullscreen and crashes less than 60 seconds after being launched
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ba820fdf3fd1c56cc1796a995be3a103c1704f9

commit 7ba820fdf3fd1c56cc1796a995be3a103c1704f9
Author: pkotwicz <pkotwicz@chromium.org>
Date: Wed Oct 12 19:05:37 2016

Fix crash on WebAPK startup

This CL fixes a crash in WebApkUpdateManager#onBuiltWebApk() on startup when
updating the WebAPK fails. When updating the WebAPK fails,
WebApkInstaller::OnFailure() calls the callback with an empty package name. This
causes an empty package name to be incorrectly  used to construct the WebAPK id
in WebApkUpdateManager#onBuiltWebApk()

BUG= 654251 

Review-Url: https://codereview.chromium.org/2409453002
Cr-Commit-Position: refs/heads/master@{#424811}

[modify] https://crrev.com/7ba820fdf3fd1c56cc1796a995be3a103c1704f9/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
[modify] https://crrev.com/7ba820fdf3fd1c56cc1796a995be3a103c1704f9/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/7ba820fdf3fd1c56cc1796a995be3a103c1704f9/chrome/browser/android/webapk/webapk_update_manager.cc
[modify] https://crrev.com/7ba820fdf3fd1c56cc1796a995be3a103c1704f9/chrome/browser/android/webapk/webapk_update_manager.h

Status: Fixed (was: Started)
Test steps for test team

1) Uninstall any currently installed "test WebAPKs" (APKs with yellow hexagon)
2) Enable WebAPKs by following steps in https://docs.google.com/a/google.com/document/d/1gHZ1YXO7QRZO6hgt11uqItNpl5WrZBJYxPYAnuJphXU/edit?usp=sharing
3) "Force Stop" Chrome
4) In Chrome for Android, navigate to https://webapk-test.appspot.com/generated.html?name=Simple%20Update%20Test&short_name=Simple%20Update%20Test&scope=%2F&display=standalone&orientation=&start_url=&theme_color=purple&background_color=teal&icons=icon_hexagon_256&update=true&update_name=Updated&update_short_name=Updated&update_scope=%2F&update_display=standalone&update_orientation=&update_start_url=&update_theme_color=purple&update_background_color=teal&update_icons=icon_hexagon_256&seed=845

Tip: You can navigate "Chrome for Android" to a long URL by using chrome://inspect on the desktop and selecting the "Devices" tab

4) If a "Reset" button is visible on the web page, press it. (Do not press the 
5) Select "Add to Home screen" from the app menu. An infobar will show briefly. Press the "Install" button when asked to install the "Simple Update Test" APK
6) Launch the newly created APK.
7) Press the "Update" button on the Web Page
8) "Force Stop" chrome
9) Change the command line by running
build/android/adb_chrome_public_command_line --enable-features="WebApks" --check-for-web-manifest-update-on-startup --enable-webapk
8) Relaunch the APK
9) Wait for 5 minutes. Check that there is no crash
Cc: pkotw...@chromium.org
 Issue 658881  has been merged into this issue.

Sign in to add a comment