New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654248 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Voice input feature available only in the first clicking voice input icon

Project Member Reported by zhan...@chromium.org, Oct 9 2016

Issue description

Version 55.0.2882.0 canary
Platform 8878 clapper
Firmware Google_Clapper.5216.199.7

 
REPRO STEPS
1.Checked <Show input options in the shelf> 
2.Open opt-in menu in shelf 
3.Click voice input icon, will see the mic icon in layout 
4.Hide layout then click voice input icon again


ACTUAL RESULTS
Only display last layout (HW layout or main vk layout) ,no shown mic icon again in the layout

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9abb3ee29957feee6fa1eacb407238fbc9b48a6e

commit 9abb3ee29957feee6fa1eacb407238fbc9b48a6e
Author: azurewei <azurewei@chromium.org>
Date: Wed Oct 26 08:38:17 2016

Override keyset with the IME layout info.

For system IME extension, the default input view url is:
chrome-extension://${extension_id}/inputview.html#id=us.compact.qwerty&language=en-US&passwordLayout=us.compact.qwerty&name=keyboard_us
To show the keyboard with emoji/handwriting keyset directly, we used to override the default input view url as "id=emoji/hwt" directly.

While, the keyboard needs to know the default keyset to get the right 'back to main layout' behavior.

Thus, we override the url as id=${keyset}.emoji/hwt to pass the default keyset and specific keyset info together.

Reload the keyset to notify the hash changed when hide keyboard. Thus the VK will get the onhashchange event when
show with from clicking voice button for many times.

BUG= 654247 ,  654248 
TEST=InputMethodManagerImplTest.Override*

Review-Url: https://codereview.chromium.org/2436723002
Cr-Commit-Position: refs/heads/master@{#427637}

[modify] https://crrev.com/9abb3ee29957feee6fa1eacb407238fbc9b48a6e/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/9abb3ee29957feee6fa1eacb407238fbc9b48a6e/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 8949.0.0  clapper 

Sign in to add a comment