Clicking emoji & voice input icon show incorrect after clicking hw icon |
|||
Issue descriptionVersion 55.0.2882.0 canary Platform 8878 clapper Firmware Google_Clapper.5216.199.7 REPRO STEPS 1.Checked <Show input options in the shelf> 2.Open opt-in menu in shelf 3.Click hw icon ,then click emoji or voice input icon again ACTUAL RESULTS All of them will display handwriting layout with clicking emoji or voice input icon Note: 1.In emoji panel, click <back to main layout> button, with display emoji panel ,not main keyboard
,
Oct 25 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/b246ab015b6b1ecd682ff6bda1f7eb9d8b01df57 commit b246ab015b6b1ecd682ff6bda1f7eb9d8b01df57 Author: azurewei <azurewei@chromium.org> Date: Tue Oct 25 01:28:56 2016
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9abb3ee29957feee6fa1eacb407238fbc9b48a6e commit 9abb3ee29957feee6fa1eacb407238fbc9b48a6e Author: azurewei <azurewei@chromium.org> Date: Wed Oct 26 08:38:17 2016 Override keyset with the IME layout info. For system IME extension, the default input view url is: chrome-extension://${extension_id}/inputview.html#id=us.compact.qwerty&language=en-US&passwordLayout=us.compact.qwerty&name=keyboard_us To show the keyboard with emoji/handwriting keyset directly, we used to override the default input view url as "id=emoji/hwt" directly. While, the keyboard needs to know the default keyset to get the right 'back to main layout' behavior. Thus, we override the url as id=${keyset}.emoji/hwt to pass the default keyset and specific keyset info together. Reload the keyset to notify the hash changed when hide keyboard. Thus the VK will get the onhashchange event when show with from clicking voice button for many times. BUG= 654247 , 654248 TEST=InputMethodManagerImplTest.Override* Review-Url: https://codereview.chromium.org/2436723002 Cr-Commit-Position: refs/heads/master@{#427637} [modify] https://crrev.com/9abb3ee29957feee6fa1eacb407238fbc9b48a6e/chrome/browser/chromeos/input_method/input_method_manager_impl.cc [modify] https://crrev.com/9abb3ee29957feee6fa1eacb407238fbc9b48a6e/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
,
Oct 27 2016
,
Oct 31 2016
Verified in 8949.0.0 clapper |
|||
►
Sign in to add a comment |
|||
Comment 1 by azurewei@chromium.org
, Oct 19 2016