New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654245 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

graphics_Gbm failing in hwtest on all boards: CHECK failed in check_bo() gbmtest.c:122

Project Member Reported by vapier@chromium.org, Oct 9 2016

Issue description

last passing run of the CQ:
https://uberchromegw.corp.google.com/i/chromeos/builders/x86-alex-paladin/builds/25793
https://uberchromegw.corp.google.com/i/chromeos/builders/wolf-tot-paladin/builds/8024

then next build, and every build since, failed:
https://uberchromegw.corp.google.com/i/chromeos/builders/x86-alex-paladin/builds/25794
https://uberchromegw.corp.google.com/i/chromeos/builders/wolf-tot-paladin/builds/8025

10/08 10:54:58.609 DEBUG|        base_utils:0185| Running '/usr/local/autotest/tests/graphics_Gbm/src/gbmtest'
10/08 10:54:58.829 DEBUG|        base_utils:0280| [stdout] CHECK failed in check_bo() gbmtest.c:122
10/08 10:54:58.830 DEBUG|        base_utils:0280| [stdout] CHECK failed in test_import_vgem() gbmtest.c:500
10/08 10:54:58.830 DEBUG|        base_utils:0280| [stdout] CHECK failed in check_bo() gbmtest.c:122
10/08 10:54:58.831 DEBUG|        base_utils:0280| [stdout] CHECK failed in test_import_dmabuf() gbmtest.c:535
10/08 10:54:58.831 DEBUG|        base_utils:0280| [stdout] [  FAILED  ] graphics_Gbm test failed

i'm guessing it's because of these CLs that were chumped for some reason instead of going through the CQ:
https://chromium-review.googlesource.com/387145
https://chromium-review.googlesource.com/387206
https://chromium-review.googlesource.com/387178

since they were chumped, and the bots are all dead, i'm going to revert them all.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/minigbm/+/602bd16a60a01ebb0ce911712256047df18acaa5

commit 602bd16a60a01ebb0ce911712256047df18acaa5
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun Oct 09 02:34:30 2016

Revert "Add new GBM_BO_IMPORT_FD_PLANAR"

This reverts commit bb19d6abec19015eb16fe33d3a4128194f8c7f2f.

This was chumped w/out explanation, and the bots have all been
dead since due to graphics_Gbm check failures.  Reverting in
the hope it'll fix things.  It can reland via the CQ.

BUG= chromium:654245 

Change-Id: I0d88f7731e9e90fffee1485056d787430eb0b850
Reviewed-on: https://chromium-review.googlesource.com/395727
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/602bd16a60a01ebb0ce911712256047df18acaa5/drv.c
[modify] https://crrev.com/602bd16a60a01ebb0ce911712256047df18acaa5/drv.h
[modify] https://crrev.com/602bd16a60a01ebb0ce911712256047df18acaa5/gbm.c
[modify] https://crrev.com/602bd16a60a01ebb0ce911712256047df18acaa5/gbm.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9 2016

Labels: merge-merged-chromeos-2.4.70
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/libdrm/+/aa27777916b561b0dd98a3da99a32dedc49724b8

commit aa27777916b561b0dd98a3da99a32dedc49724b8
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun Oct 09 02:34:37 2016

Revert "Add drmModeAddFB2WithModifiers() which takes format modifiers"

This reverts commit 9f2922a3c355eb5ceee4eb7c1a899ee2373bb116.

This was chumped w/out explanation, and the bots have all been
dead since due to graphics_Gbm check failures.  Reverting in
the hope it'll fix things.  It can reland via the CQ.

BUG= chromium:654245 

Change-Id: I33f604ade1ff4190f996afaadd0edba5f3cc8ebf

[modify] https://crrev.com/aa27777916b561b0dd98a3da99a32dedc49724b8/xf86drmMode.h
[modify] https://crrev.com/aa27777916b561b0dd98a3da99a32dedc49724b8/xf86drmMode.c

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/khronos/+/669e6d72d5e559f30c854e5b4e990d3ccfd98bcf

commit 669e6d72d5e559f30c854e5b4e990d3ccfd98bcf
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun Oct 09 02:34:43 2016

Revert "Add tokens for EGL_EXT_image_dma_buf_import_modifiers"

This reverts commit 1c20cd090b0f32605bb7d4b5bccbca4f32e5eb86.

This was chumped w/out explanation, and the bots have all been
dead since due to graphics_Gbm check failures.  Reverting in
the hope it'll fix things.  It can reland via the CQ.

BUG= chromium:654245 

Change-Id: Ia8e60e66b7a17f56e58d58d681938139aa7a06cc
Reviewed-on: https://chromium-review.googlesource.com/395906
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/669e6d72d5e559f30c854e5b4e990d3ccfd98bcf/include/EGL/eglext.h

Comment 4 by ihf@chromium.org, Oct 9 2016

Cc: ihf@chromium.org
vapier: Thanks for reverting!

hoegsberg: I don't know if this is due to the recent gerrit problems or if you wanted them to go in at the same time. For that you can use CQ-DEPEND with a circular dependency. And just in case, the pre-commit queue only checks a few compiles. No tests run there on hardware yet.
Yes, indeed, thank for cleaning this up. I didn't mean to chump anything, I thought I was following the regular process for landing patches.  I think Gurchetan spotted the problem with the gbm patch, I'll give that a try here and see if Ilja has time to walk me through the proper way of doing this.

Comment 6 by vapier@chromium.org, Oct 10 2016

Labels: -Pri-0 Pri-2
the bots have all gone green, so no need for Pri-0.  feel free to reprioritize/close/etc... the issue as you see fit.
Status: Verified (was: Started)

Sign in to add a comment