New issue
Advanced search Search tips

Issue 654215 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

loading.mobile failure on Android Perf bots

Project Member Reported by zh...@chromium.org, Oct 8 2016

Issue description

Android Nexus5X WebView Perf (3)
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus5X%20WebView%20Perf%20(3)
Android Nexus6 WebView Perf (2)
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf%20(2)
Android Galaxy S5 Perf (3)
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20(3)

First seen:
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus5X%20WebView%20Perf%20%283%29/builds/2188
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf%20%282%29/builds/349
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20%283%29/builds/3471


Overlapped range: 423987 - 423995


MapFunctionError: Cannot read property 'asyncSliceGroup' of undefined
    at prepareTelemetryInternalEventPredicate (/tracing/metrics/system_health/loading_metric.html:187:34)
    at timeToFirstContentfulPaintMetric (/tracing/metrics/system_health/loading_metric.html:232:9)
    at new loadingMetric (/tracing/metrics/system_health/loading_metric.html:425:5)
    at runMetrics (/b/rr/tmpLc5Fli/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:37:14)
    at metricMapFunction (/b/rr/tmpLc5Fli/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:71:18)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:41:7)
    at eval (/b/rr/tmpLc5Fli/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:26:10)
    at mapSingleTraceWithResult (/b/rr/tmpLc5Fli/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/rr/tmpLc5Fli/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:76:18)
[  FAILED  ] /tmp/tmp39aA72.html (1656 ms)
Traceback (most recent call last):
  File "/b/rr/tmpLc5Fli/w/src/third_party/catapult/telemetry/telemetry/value/failure.py", line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: MapFunctionError: Cannot read property 'asyncSliceGroup' of undefined
    at prepareTelemetryInternalEventPredicate (/tracing/metrics/system_health/loading_metric.html:187:34)
    at timeToFirstContentfulPaintMetric (/tracing/metrics/system_health/loading_metric.html:232:9)
    at new loadingMetric (/tracing/metrics/system_health/loading_metric.html:425:5)
    at runMetrics (/b/rr/tmpLc5Fli/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:37:14)
    at metricMapFunction (/b/rr/tmpLc5Fli/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:71:18)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:41:7)
    at eval (/b/rr/tmpLc5Fli/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:26:10)
    at mapSingleTraceWithResult (/b/rr/tmpLc5Fli/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/rr/tmpLc5Fli/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:76:18)


 

Comment 5 by zh...@chromium.org, Oct 8 2016

Cc: ksakamoto@chromium.org
Bisect not working. But looks like this CL is the culprit:
https://codereview.chromium.org/2363343003

Reverting...
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b524efc65e507803ec42e4d73509c420cb715081

commit b524efc65e507803ec42e4d73509c420cb715081
Author: zhenw <zhenw@chromium.org>
Date: Sat Oct 08 17:33:08 2016

Revert of Add loading mobile story set (patchset #6 id:140001 of https://codereview.chromium.org/2363343003/ )

Reason for revert:
Failure on Android Perf bot

BUG= chromium:654215 

Original issue's description:
> Add loading mobile story set
>
> This adds a story set and corresponding benchmark for mobile loading
> performance loading team is interested in.
>
> Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNFCI/edit
>
> BUG=643524
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
>
> Committed: https://crrev.com/31d0a108f1783a04f2b981d668883a43a30ddc32
> Cr-Commit-Position: refs/heads/master@{#423993}

TBR=kouhei@chromium.org,nednguyen@google.com,ksakamoto@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=643524

Review-Url: https://codereview.chromium.org/2409433002
Cr-Commit-Position: refs/heads/master@{#424083}

[modify] https://crrev.com/b524efc65e507803ec42e4d73509c420cb715081/tools/perf/OWNERS
[delete] https://crrev.com/ccd977fa5650bf395c59bbbb0afc81f5dbd3531c/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/b524efc65e507803ec42e4d73509c420cb715081/tools/perf/benchmarks/page_cycler_v2.py
[delete] https://crrev.com/ccd977fa5650bf395c59bbbb0afc81f5dbd3531c/tools/perf/page_sets/data/loading_mobile.json
[delete] https://crrev.com/ccd977fa5650bf395c59bbbb0afc81f5dbd3531c/tools/perf/page_sets/data/loading_mobile_000.wpr.sha1
[delete] https://crrev.com/ccd977fa5650bf395c59bbbb0afc81f5dbd3531c/tools/perf/page_sets/data/loading_mobile_001.wpr.sha1
[delete] https://crrev.com/ccd977fa5650bf395c59bbbb0afc81f5dbd3531c/tools/perf/page_sets/loading_mobile.py

Comment 7 by zh...@chromium.org, Oct 9 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eff0660d223203c7e081c9fbdb7ad0e4cf425d15

commit eff0660d223203c7e081c9fbdb7ad0e4cf425d15
Author: ksakamoto <ksakamoto@chromium.org>
Date: Thu Oct 13 03:47:34 2016

Enable loading.mobile benchmark on Android except reference and webview

Note to sheriffs: If there are failures/crashes on waterfall bots,
please comment out individual pages in tools/perf/page_sets/loading_mobile.py
instead of disabling the whole benchmark.

BUG=643524, 654215 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2409103002
Cr-Commit-Position: refs/heads/master@{#424949}

[modify] https://crrev.com/eff0660d223203c7e081c9fbdb7ad0e4cf425d15/tools/perf/benchmarks/loading.py

Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Apr 11 2017

Owner: ksakamoto@chromium.org

=== Auto-CCing suspected CL author ksakamoto@chromium.org ===

Hi ksakamoto@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : ksakamoto
  Commit : 31d0a108f1783a04f2b981d668883a43a30ddc32
  Date   : Fri Oct 07 22:52:31 2016
  Subject: Add loading mobile story set

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : loading.mobile
  Metric       : timeToFirstContentfulPaint_avg/https___www.google.com_search?q_flower_q_flower+delivery

Revision             Exit Code      N
chromium@423987      1 +- N/A       5      good
chromium@423991      1 +- N/A       5      good
chromium@423992      1 +- N/A       5      good
chromium@423993      0 +- N/A       5      bad       <--
chromium@423995      0 +- N/A       5      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests loading.mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982651789605443392

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5214982285819904


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Sign in to add a comment