New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654190 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Linux App Store Metadata is missing

Reported by mailaend...@gmail.com, Oct 8 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36

Steps to reproduce the problem:
Look for Chromium in an AppStream compatible Linux software store.

What is the expected behavior?
A description with screenshots and categories.

What went wrong?
There are none.

Did this work before? N/A 

Chrome version: 53.0.2785.143  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 23.0 r0

See the attached file and https://people.freedesktop.org/~hughsient/appdata/ for the specifications.
 
chromium-browser.appdata.xml
1.2 KB View Download
See https://build.opensuse.org/request/show/433874 for an integration test.
If you don't mind I will attach another version. This one contains two AppData files, one for Chromium and one for Chrome - the Chrome one should be filled with the information from the common/google-chrome/google-chrome.info file and should reflect the current channel (stable, beta, devel). On the other side the Chromium one should be a general one and it will be reused by distributions that are packaging the Chromium themselves. Please take this as an initial version and please don't hesitate to provide feedback on it and discuss it (also that's the reason why I attached the patch here).
chromium_chrome_appdata_files.patch
6.0 KB Download

Comment 3 by rpop@chromium.org, Jan 26 2017

Owner: rpop@chromium.org
Status: Assigned (was: Unconfirmed)
I'll work on getting text and images reviewed. Taking the bug for now.
Cc: phajdan@google.com phajdan.jr@chromium.org
Also see uploaded https://codereview.chromium.org/2424093003 .
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6807b9a7da70dae9191b93d4ec6157187515078

commit d6807b9a7da70dae9191b93d4ec6157187515078
Author: tomas.popela <tomas.popela@gmail.com>
Date: Wed Mar 08 15:33:42 2017

Include the AppData file for Chrome and Chromium

Add the two AppData files, one for Chromium and one for Chrome. The Chrome one
will be filled with the information from the common/google-chrome/google-chrome.info
file and should reflect the current channel (stable, beta, devel). On the other
side the Chromium one should be a general one and it will be reused by
distributions that are packaging the Chromium themselves.

For AppData specification please see:
https://people.freedesktop.org/~hughsient/appdata/

BUG= 654190 

Review-Url: https://codereview.chromium.org/2424093003
Cr-Commit-Position: refs/heads/master@{#455457}

[modify] https://crrev.com/d6807b9a7da70dae9191b93d4ec6157187515078/chrome/installer/linux/BUILD.gn
[add] https://crrev.com/d6807b9a7da70dae9191b93d4ec6157187515078/chrome/installer/linux/common/chromium-browser/chromium-browser.appdata.xml
[add] https://crrev.com/d6807b9a7da70dae9191b93d4ec6157187515078/chrome/installer/linux/common/google-chrome/google-chrome.appdata.xml.template
[modify] https://crrev.com/d6807b9a7da70dae9191b93d4ec6157187515078/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/d6807b9a7da70dae9191b93d4ec6157187515078/chrome/installer/linux/rpm/chrome.spec.template

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/163d7ed981d080347b05a6ad4d47d0e2418f04e9

commit 163d7ed981d080347b05a6ad4d47d0e2418f04e9
Author: xhwang <xhwang@chromium.org>
Date: Wed Mar 08 17:36:26 2017

Revert of Include the AppData file for Chrome and Chromium (patchset #3 id:40001 of https://codereview.chromium.org/2424093003/ )

Reason for revert:
This is breaking Google Chrome Linux bots:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/16701

Original issue's description:
> Include the AppData file for Chrome and Chromium
>
> Add the two AppData files, one for Chromium and one for Chrome. The Chrome one
> will be filled with the information from the common/google-chrome/google-chrome.info
> file and should reflect the current channel (stable, beta, devel). On the other
> side the Chromium one should be a general one and it will be reused by
> distributions that are packaging the Chromium themselves.
>
> For AppData specification please see:
> https://people.freedesktop.org/~hughsient/appdata/
>
> BUG= 654190 
>
> Review-Url: https://codereview.chromium.org/2424093003
> Cr-Commit-Position: refs/heads/master@{#455457}
> Committed: https://chromium.googlesource.com/chromium/src/+/d6807b9a7da70dae9191b93d4ec6157187515078

TBR=phajdan.jr@chromium.org,tomas.popela@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 654190 

Review-Url: https://codereview.chromium.org/2734783009
Cr-Commit-Position: refs/heads/master@{#455484}

[modify] https://crrev.com/163d7ed981d080347b05a6ad4d47d0e2418f04e9/chrome/installer/linux/BUILD.gn
[delete] https://crrev.com/b4d9808827ba10f059c1486f8ad1f13650afcfbd/chrome/installer/linux/common/chromium-browser/chromium-browser.appdata.xml
[delete] https://crrev.com/b4d9808827ba10f059c1486f8ad1f13650afcfbd/chrome/installer/linux/common/google-chrome/google-chrome.appdata.xml.template
[modify] https://crrev.com/163d7ed981d080347b05a6ad4d47d0e2418f04e9/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/163d7ed981d080347b05a6ad4d47d0e2418f04e9/chrome/installer/linux/rpm/chrome.spec.template

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa17f475b1ccf16ce0d4f89902663f4462396a8

commit caa17f475b1ccf16ce0d4f89902663f4462396a8
Author: tomas.popela <tomas.popela@gmail.com>
Date: Thu Mar 09 13:55:19 2017

Include the AppData file for Chrome and Chromium

Add the two AppData files, one for Chromium and one for Chrome. The Chrome one
will be filled with the information from the common/google-chrome/google-chrome.info
file and should reflect the current channel (stable, beta, devel). On the other
side the Chromium one should be a general one and it will be reused by
distributions that are packaging the Chromium themselves.

For AppData specification please see:
https://people.freedesktop.org/~hughsient/appdata/

BUG= 654190 

Review-Url: https://codereview.chromium.org/2424093003
Cr-Original-Commit-Position: refs/heads/master@{#455457}
Committed: https://chromium.googlesource.com/chromium/src/+/d6807b9a7da70dae9191b93d4ec6157187515078
Review-Url: https://codereview.chromium.org/2424093003
Cr-Commit-Position: refs/heads/master@{#455731}

[modify] https://crrev.com/caa17f475b1ccf16ce0d4f89902663f4462396a8/chrome/installer/linux/BUILD.gn
[add] https://crrev.com/caa17f475b1ccf16ce0d4f89902663f4462396a8/chrome/installer/linux/common/chromium-browser/chromium-browser.appdata.xml
[add] https://crrev.com/caa17f475b1ccf16ce0d4f89902663f4462396a8/chrome/installer/linux/common/google-chrome/google-chrome.appdata.xml.template
[modify] https://crrev.com/caa17f475b1ccf16ce0d4f89902663f4462396a8/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/caa17f475b1ccf16ce0d4f89902663f4462396a8/chrome/installer/linux/rpm/chrome.spec.template

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2e1cecca25608406cfe391ef7f0836e666c6588

commit a2e1cecca25608406cfe391ef7f0836e666c6588
Author: fserb <fserb@chromium.org>
Date: Thu Mar 09 15:55:21 2017

Revert of Include the AppData file for Chrome and Chromium (patchset #4 id:60001 of https://codereview.chromium.org/2424093003/ )

Reason for revert:
This is breaking linux build bot (again), please do not submit before fixing:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/16722

Original issue's description:
> Include the AppData file for Chrome and Chromium
>
> Add the two AppData files, one for Chromium and one for Chrome. The Chrome one
> will be filled with the information from the common/google-chrome/google-chrome.info
> file and should reflect the current channel (stable, beta, devel). On the other
> side the Chromium one should be a general one and it will be reused by
> distributions that are packaging the Chromium themselves.
>
> For AppData specification please see:
> https://people.freedesktop.org/~hughsient/appdata/
>
> BUG= 654190 
>
> Review-Url: https://codereview.chromium.org/2424093003
> Cr-Original-Commit-Position: refs/heads/master@{#455457}
> Committed: https://chromium.googlesource.com/chromium/src/+/d6807b9a7da70dae9191b93d4ec6157187515078
> Review-Url: https://codereview.chromium.org/2424093003
> Cr-Commit-Position: refs/heads/master@{#455731}
> Committed: https://chromium.googlesource.com/chromium/src/+/caa17f475b1ccf16ce0d4f89902663f4462396a8

TBR=phajdan.jr@chromium.org,xhwang@chromium.org,tomas.popela@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 654190 

Review-Url: https://codereview.chromium.org/2738043003
Cr-Commit-Position: refs/heads/master@{#455753}

[modify] https://crrev.com/a2e1cecca25608406cfe391ef7f0836e666c6588/chrome/installer/linux/BUILD.gn
[delete] https://crrev.com/5da0c292e434236e9344a532471123912cdb1fe7/chrome/installer/linux/common/chromium-browser/chromium-browser.appdata.xml
[delete] https://crrev.com/5da0c292e434236e9344a532471123912cdb1fe7/chrome/installer/linux/common/google-chrome/google-chrome.appdata.xml.template
[modify] https://crrev.com/a2e1cecca25608406cfe391ef7f0836e666c6588/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/a2e1cecca25608406cfe391ef7f0836e666c6588/chrome/installer/linux/rpm/chrome.spec.template

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd765c0d5ff5089329188018ac826e0728cad15e

commit dd765c0d5ff5089329188018ac826e0728cad15e
Author: tomas.popela <tomas.popela@gmail.com>
Date: Tue Mar 21 14:44:16 2017

Include the AppData file for Chrome and Chromium

Add the two AppData files, one for Chromium and one for Chrome. The Chrome one
will be filled with the information from the common/google-chrome/google-chrome.info
file and should reflect the current channel (stable, beta, devel). On the other
side the Chromium one should be a general one and it will be reused by
distributions that are packaging the Chromium themselves.

For AppData specification please see:
https://people.freedesktop.org/~hughsient/appdata/

BUG= 654190 

Review-Url: https://codereview.chromium.org/2424093003
Cr-Original-Original-Commit-Position: refs/heads/master@{#455457}
Committed: https://chromium.googlesource.com/chromium/src/+/d6807b9a7da70dae9191b93d4ec6157187515078
Review-Url: https://codereview.chromium.org/2424093003
Cr-Original-Commit-Position: refs/heads/master@{#455731}
Committed: https://chromium.googlesource.com/chromium/src/+/caa17f475b1ccf16ce0d4f89902663f4462396a8
Review-Url: https://codereview.chromium.org/2424093003
Cr-Commit-Position: refs/heads/master@{#458406}

[modify] https://crrev.com/dd765c0d5ff5089329188018ac826e0728cad15e/chrome/installer/linux/BUILD.gn
[add] https://crrev.com/dd765c0d5ff5089329188018ac826e0728cad15e/chrome/installer/linux/common/chromium-browser/chromium-browser.appdata.xml
[add] https://crrev.com/dd765c0d5ff5089329188018ac826e0728cad15e/chrome/installer/linux/common/google-chrome/google-chrome.appdata.xml.template
[modify] https://crrev.com/dd765c0d5ff5089329188018ac826e0728cad15e/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/dd765c0d5ff5089329188018ac826e0728cad15e/chrome/installer/linux/rpm/chrome.spec.template

Comment 10 by rpop@chromium.org, Apr 12 2017

@phajdan, is this done?
Status: Fixed (was: Assigned)

Sign in to add a comment