Issue metadata
Sign in to add a comment
|
DevTools: selecting text in styles sidebar pane |
||||||||||||||||||||||
Issue description
What steps will reproduce the problem?
(1) Open the styles sidebar pane with some css rules ("background: #fff") under a selector header ("body {")
(2) Make a text selection by dragging from inside the css rules and ending in the selector header
(3) Let go of the mouse
What is the expected output?
The selected text remains selected
What do you see instead?
Text selection is lost and instead the cursor is put inside a text prompt to create a new style rule
Bisected to this commit:
https://chromium.googlesource.com/chromium/src/+/5b494767ab26e78c514244b4cf3d1e8fda2c7e77
,
Oct 31 2016
,
Dec 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8da265eb8eb0660119e988f1be6c49e5b7e711d commit d8da265eb8eb0660119e988f1be6c49e5b7e711d Author: einbinder <einbinder@chromium.org> Date: Fri Dec 30 04:31:59 2016 DevTools: Preserve the selection in StylesSideBar more often If a selection crossed between shadow roots, it wouldn't be detected and a new blank property would be added on mouse up. BUG= 654163 Review-Url: https://codereview.chromium.org/2606013002 Cr-Commit-Position: refs/heads/master@{#441018} [modify] https://crrev.com/d8da265eb8eb0660119e988f1be6c49e5b7e711d/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Jan 3 2017
@einbinder, I'm still able to reproduce this after your CL. Is there some other bug that it fixes?
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80e1ad7ddfbd24068d09c367521aaddd46bd7e25 commit 80e1ad7ddfbd24068d09c367521aaddd46bd7e25 Author: einbinder <einbinder@chromium.org> Date: Tue Jan 03 23:28:00 2017 DevTools: Preserve the selection across shadow DOM in StylesSideBar If a selection crossed between shadow roots, it wouldn't be detected and a new blank property would be added on mouse up. The last patch about this was missing a vital exclamation point. BUG= 654163 Review-Url: https://codereview.chromium.org/2609243002 Cr-Commit-Position: refs/heads/master@{#441251} [modify] https://crrev.com/80e1ad7ddfbd24068d09c367521aaddd46bd7e25/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Jan 23 2017
Can we close this bug?
,
Jan 23 2017
Yup. Thanks einbinder@ |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by l...@chromium.org
, Oct 26 2016