New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654153 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

Project Member Reported by lgar...@chromium.org, Oct 8 2016

Issue description

Bug so that I can ask for a merge ofhttps://codereview.chromium.org/2400883002/
 
Labels: -Pri-3 M-55 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Owner: lgar...@chromium.org
Status: Assigned (was: Ss)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ae90d7232f7d5fc9032e13b4d309a9282c4fd22

commit 6ae90d7232f7d5fc9032e13b4d309a9282c4fd22
Author: lgarron <lgarron@chromium.org>
Date: Mon Oct 10 21:13:57 2016

Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

This allows https://codereview.chromium.org/2306673003 to simply call SizeToContents() on the entire WebsiteSettingsPopupView without having to manually re-layout the header.

BUG= 654153 

Review-Url: https://codereview.chromium.org/2400883002
Cr-Commit-Position: refs/heads/master@{#424241}

[modify] https://crrev.com/6ae90d7232f7d5fc9032e13b4d309a9282c4fd22/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Labels: Merge-Request-55

Comment 4 by dimu@chromium.org, Oct 12 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 13 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0af7d0edfddd038461850cbc8957f1fba1686df9

commit 0af7d0edfddd038461850cbc8957f1fba1686df9
Author: Lucas Garron <lgarron@chromium.org>
Date: Thu Oct 13 00:45:10 2016

Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

This allows https://codereview.chromium.org/2306673003 to simply call SizeToContents() on the entire WebsiteSettingsPopupView without having to manually re-layout the header.

BUG= 654153 

Review-Url: https://codereview.chromium.org/2400883002
Cr-Commit-Position: refs/heads/master@{#424241}
(cherry picked from commit 6ae90d7232f7d5fc9032e13b4d309a9282c4fd22)

Review URL: https://codereview.chromium.org/2412363002 .

Cr-Commit-Position: refs/branch-heads/2883@{#81}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/0af7d0edfddd038461850cbc8957f1fba1686df9/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Status: Fixed (was: Assigned)
Cc: nyerramilli@chromium.org
Labels: Needs-Feedback
lgarron@, could you please provide them to verify the issue from Chrome-TE end.
Labels: -Needs-Feedback
I don't have a straightforward way to verify the fix.
The CL rewrites some of the layout logic to work better in edge cases, but I don't have a way on hand to trigger these cases in testing.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0af7d0edfddd038461850cbc8957f1fba1686df9

commit 0af7d0edfddd038461850cbc8957f1fba1686df9
Author: Lucas Garron <lgarron@chromium.org>
Date: Thu Oct 13 00:45:10 2016

Switch PopupHeaderView labels to use the GridLayout for automatic sizing.

This allows https://codereview.chromium.org/2306673003 to simply call SizeToContents() on the entire WebsiteSettingsPopupView without having to manually re-layout the header.

BUG= 654153 

Review-Url: https://codereview.chromium.org/2400883002
Cr-Commit-Position: refs/heads/master@{#424241}
(cherry picked from commit 6ae90d7232f7d5fc9032e13b4d309a9282c4fd22)

Review URL: https://codereview.chromium.org/2412363002 .

Cr-Commit-Position: refs/branch-heads/2883@{#81}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/0af7d0edfddd038461850cbc8957f1fba1686df9/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Comment 10 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 11 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment