Overlay requires a way to append data to the shill Mobile Operator DB |
||||||||
Issue descriptionSee internal bug b/31473462 for background Some kiosk devices use dedicated b2b SIM cards that require model-specific MNO settings (e.g. APN). For these it's more appropriate for device overlay to customize the APN database than require user/policy setting: e.g. if the device has no UI and requires working cellular connection to bootstrap itself.
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a8706e4177877c99e14c205bb69619b77e82082b commit a8706e4177877c99e14c205bb69619b77e82082b Author: Skylar Cook <skylarc@google.com> Date: Fri Oct 07 22:35:17 2016 install proto file during ebuild for use in overlays BUG= chromium:654149 TEST=Existing tests enforce ordering, deploy and connectivity tested. Change-Id: I3972a5b95a27616e866b9bf4bd33e8c0c701b6fd Reviewed-on: https://chromium-review.googlesource.com/395488 Commit-Ready: Jonathan Dixon <joth@chromium.org> Tested-by: Jonathan Dixon <joth@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Jonathan Dixon <joth@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/a8706e4177877c99e14c205bb69619b77e82082b/chromeos-base/shill/shill-9999.ebuild
,
Oct 12 2016
Landed in Canary 8891.0.0, also tested locally to confirm fix on Rialto
,
Oct 12 2016
Just to add for TPM's benefit: the shill changes are a no-op for all other devices except rialto, so should be very safe to merge to the branch.
,
Oct 13 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/975cdc493d98959d771573567367526b39d5c0e6 commit 975cdc493d98959d771573567367526b39d5c0e6 Author: Skylar Cook <skylarc@google.com> Date: Fri Oct 07 22:35:17 2016 install proto file during ebuild for use in overlays BUG= chromium:654149 TEST=Existing tests enforce ordering, deploy and connectivity tested. Change-Id: I3972a5b95a27616e866b9bf4bd33e8c0c701b6fd Reviewed-on: https://chromium-review.googlesource.com/395488 Commit-Ready: Jonathan Dixon <joth@chromium.org> Tested-by: Jonathan Dixon <joth@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Jonathan Dixon <joth@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> (cherry picked from commit a8706e4177877c99e14c205bb69619b77e82082b) Reviewed-on: https://chromium-review.googlesource.com/398319 Commit-Queue: Jonathan Dixon <joth@chromium.org> [modify] https://crrev.com/975cdc493d98959d771573567367526b39d5c0e6/chromeos-base/shill/shill-9999.ebuild
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/975cdc493d98959d771573567367526b39d5c0e6 commit 975cdc493d98959d771573567367526b39d5c0e6 Author: Skylar Cook <skylarc@google.com> Date: Fri Oct 07 22:35:17 2016 install proto file during ebuild for use in overlays BUG= chromium:654149 TEST=Existing tests enforce ordering, deploy and connectivity tested. Change-Id: I3972a5b95a27616e866b9bf4bd33e8c0c701b6fd Reviewed-on: https://chromium-review.googlesource.com/395488 Commit-Ready: Jonathan Dixon <joth@chromium.org> Tested-by: Jonathan Dixon <joth@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Jonathan Dixon <joth@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> (cherry picked from commit a8706e4177877c99e14c205bb69619b77e82082b) Reviewed-on: https://chromium-review.googlesource.com/398319 Commit-Queue: Jonathan Dixon <joth@chromium.org> [modify] https://crrev.com/975cdc493d98959d771573567367526b39d5c0e6/chromeos-base/shill/shill-9999.ebuild
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/113726b43143198337f1951d16b89e6a53420562 commit 113726b43143198337f1951d16b89e6a53420562 Author: Skylar Cook <skylarc@google.com> Date: Thu Sep 29 23:54:09 2016 Load override mobile provider databases if present Allows overlays to install overrides .pbfs in /usr/share/shill/serviceproviders-override.pbf and shill will include them prior to the default (overriding mccmnc APN settings). BUG= chromium:654149 TEST=Existing tests enforce ordering, deploy and connectivity tested. Change-Id: I0824a160524ea88f8d6887eafc2fb1f66edd860d Reviewed-on: https://chromium-review.googlesource.com/395573 Commit-Ready: Jonathan Dixon <joth@chromium.org> Tested-by: Jonathan Dixon <joth@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Jonathan Dixon <joth@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> (cherry picked from commit 65c860a7ed177b298d06aed07cdb5ee6179633a2) [modify] https://crrev.com/113726b43143198337f1951d16b89e6a53420562/cellular/mobile_operator_info.h [modify] https://crrev.com/113726b43143198337f1951d16b89e6a53420562/cellular/mobile_operator_info_impl.h [modify] https://crrev.com/113726b43143198337f1951d16b89e6a53420562/cellular/mobile_operator_info_impl.cc [modify] https://crrev.com/113726b43143198337f1951d16b89e6a53420562/mobile_operator_db/serviceproviders.prototxt
,
Oct 16 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17 2016
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/49bd9a98d6bda5d803a126884eff7b8c65211e2c commit 49bd9a98d6bda5d803a126884eff7b8c65211e2c Author: Skylar Cook <skylarc@google.com> Date: Thu Oct 13 23:18:59 2016 Add new impl test class and binary files for overrides Exposes a private constructor to testing class to ensure that the overriding database settings take precedence over the default database included afterwards. BUG=b:32114493 BUG= chromium:654149 TEST=Verified continued connectivity, this IS a unit test Change-Id: I6cf5c715c089f90134581a323c66f86651a838a3 Reviewed-on: https://chromium-review.googlesource.com/400944 Commit-Ready: Jonathan Dixon <joth@chromium.org> Tested-by: Skylar Cook <skylarc@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/49bd9a98d6bda5d803a126884eff7b8c65211e2c/cellular/mobile_operator_info_impl.h [add] https://crrev.com/49bd9a98d6bda5d803a126884eff7b8c65211e2c/mobile_operator_db/test_protos/init_test_override_db_init_2.h [modify] https://crrev.com/49bd9a98d6bda5d803a126884eff7b8c65211e2c/cellular/mobile_operator_info_impl.cc [add] https://crrev.com/49bd9a98d6bda5d803a126884eff7b8c65211e2c/mobile_operator_db/test_protos/init_test_override_db_init_1.h [modify] https://crrev.com/49bd9a98d6bda5d803a126884eff7b8c65211e2c/cellular/mobile_operator_info_unittest.cc
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/49bd9a98d6bda5d803a126884eff7b8c65211e2c commit 49bd9a98d6bda5d803a126884eff7b8c65211e2c Author: Skylar Cook <skylarc@google.com> Date: Thu Oct 13 23:18:59 2016 Add new impl test class and binary files for overrides Exposes a private constructor to testing class to ensure that the overriding database settings take precedence over the default database included afterwards. BUG=b:32114493 BUG= chromium:654149 TEST=Verified continued connectivity, this IS a unit test Change-Id: I6cf5c715c089f90134581a323c66f86651a838a3 Reviewed-on: https://chromium-review.googlesource.com/400944 Commit-Ready: Jonathan Dixon <joth@chromium.org> Tested-by: Skylar Cook <skylarc@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/49bd9a98d6bda5d803a126884eff7b8c65211e2c/cellular/mobile_operator_info_impl.h [add] https://crrev.com/49bd9a98d6bda5d803a126884eff7b8c65211e2c/mobile_operator_db/test_protos/init_test_override_db_init_2.h [modify] https://crrev.com/49bd9a98d6bda5d803a126884eff7b8c65211e2c/cellular/mobile_operator_info_impl.cc [add] https://crrev.com/49bd9a98d6bda5d803a126884eff7b8c65211e2c/mobile_operator_db/test_protos/init_test_override_db_init_1.h [modify] https://crrev.com/49bd9a98d6bda5d803a126884eff7b8c65211e2c/cellular/mobile_operator_info_unittest.cc
,
Feb 2 2017
,
Feb 2 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 12 2016