BoringSSL has scopers now. They're much more forward-decl friendly and can be shared with other BoringSSL consumers. Switch everything to them.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d80c12cc3341c364f67c04b1a6153a1ee34be25d commit d80c12cc3341c364f67c04b1a6153a1ee34be25d Author: davidben <davidben@chromium.org> Date: Tue Oct 11 00:13:49 2016 Use BoringSSL scopers in //net. BUG= 654143 Review-Url: https://codereview.chromium.org/2400033005 Cr-Commit-Position: refs/heads/master@{#424298} [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/base/keygen_handler_openssl.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/base/keygen_handler_unittest.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/base/openssl_private_key_store_android.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/cert_database_openssl.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/cert_verify_proc_ios.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/cert_verify_proc_openssl.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/ct_log_verifier.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/ct_objects_extractor.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/internal/verify_name_match.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/internal/verify_signed_data.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/jwk_serializer.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/x509_certificate_ios.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/x509_certificate_openssl.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/cert/x509_util_openssl.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/quic/chromium/crypto/proof_source_chromium.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/quic/core/crypto/channel_id.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/quic/core/crypto/p256_key_exchange.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/quic/core/crypto/p256_key_exchange.h [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/quic/test_tools/crypto_test_utils.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/socket/ssl_client_socket_impl.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/socket/ssl_client_socket_impl.h [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/socket/ssl_client_socket_unittest.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/socket/ssl_server_socket_impl.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/socket/ssl_server_socket_impl.h [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/socket/ssl_server_socket_unittest.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/openssl_client_key_store.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/openssl_client_key_store_unittest.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/openssl_ssl_util.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/openssl_ssl_util.h [delete] https://crrev.com/6be4d9fbc0b33047dfe901e2bbe2c322efda30cd/net/ssl/scoped_openssl_types.h [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/ssl_client_session_cache.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/ssl_client_session_cache.h [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/ssl_client_session_cache_unittest.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/ssl_platform_key_android.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/ssl_platform_key_chromecast.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/ssl_platform_key_mac.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/ssl_platform_key_nss.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/ssl_platform_key_win.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/test_ssl_private_key.cc [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/test_ssl_private_key.h [modify] https://crrev.com/d80c12cc3341c364f67c04b1a6153a1ee34be25d/net/ssl/token_binding.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e7722810efc072552797165546f7f77f245c396 commit 7e7722810efc072552797165546f7f77f245c396 Author: davidben <davidben@chromium.org> Date: Tue Oct 11 00:29:06 2016 Use new BoringSSL scopers in //components. In doing so, switch some heap-allocated things to stack-allocated and avoid needless bouncing on refcounts with EVP_PKEY_get1_*. BUG= 654143 Review-Url: https://codereview.chromium.org/2407633002 Cr-Commit-Position: refs/heads/master@{#424303} [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/gcm_driver/crypto/p256_key_util.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/aes_cbc.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/aes_ctr.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/aes_gcm.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/aes_kw.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/asymmetric_key_util.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/asymmetric_key_util.h [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/ec.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/ecdh.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/ecdsa.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/pbkdf2.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/rsa.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/rsa_oaep.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/rsa_sign.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/sha.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/algorithms/util.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/blink_key_handle.cc [modify] https://crrev.com/7e7722810efc072552797165546f7f77f245c396/components/webcrypto/blink_key_handle.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f165962d15779b07d42d5ecefd304c494a459f1c commit f165962d15779b07d42d5ecefd304c494a459f1c Author: davidben <davidben@chromium.org> Date: Tue Oct 11 20:16:00 2016 Switch remaining scoped_openssl_types uses to BoringSSL scopers. BUG= 654143 Review-Url: https://codereview.chromium.org/2408063002 Cr-Commit-Position: refs/heads/master@{#424523} [modify] https://crrev.com/f165962d15779b07d42d5ecefd304c494a459f1c/android_webview/native/aw_contents_client_bridge.cc [modify] https://crrev.com/f165962d15779b07d42d5ecefd304c494a459f1c/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc [modify] https://crrev.com/f165962d15779b07d42d5ecefd304c494a459f1c/chrome/browser/ui/android/ssl_client_certificate_request.cc [modify] https://crrev.com/f165962d15779b07d42d5ecefd304c494a459f1c/chrome/common/extensions/api/networking_private/networking_private_crypto.cc [modify] https://crrev.com/f165962d15779b07d42d5ecefd304c494a459f1c/crypto/BUILD.gn [delete] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/crypto/auto_cbb.h [delete] https://crrev.com/6805d8ab4296d9033602bad708da31e67e9fff6d/crypto/scoped_openssl_types.h
Comment 1 by bugdroid1@chromium.org
, Oct 11 2016