Harmony - update download recovery dialog |
|||||||||||
Issue descriptionSee top of this doc for a screenshot of this dialog as it currently is: https://docs.google.com/document/d/1M9AvvXafVRSNquKGhzjAqo3Pl7sSATuEECA78pfkpmA/edit#heading=h.bworb42u9xb
,
Jan 23 2017
Also, to summon this dialog: Go to testsafebrowsing.appspot.com. Download from any of the links listed under "Desktop Download Warnings". Go to chrome://downloads and click on "Keep Dangerous File" corresponding to the download.
,
Jan 23 2017
,
Jan 24 2017
Per shrike, unassigning his Harmony bugs for now.
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fba2166ddb709508371545bdb88a9c87929615d commit 5fba2166ddb709508371545bdb88a9c87929615d Author: karandeepb <karandeepb@chromium.org> Date: Wed Jan 25 11:07:44 2017 MacViews: Enable views based Download Recovery dialog behind secondary-ui-md flag. This CL puts the views based Download Recovery dialog behind the secondary-ui-md flag. As a result, the views based version is shown with the flag "secondary-ui- md" enabled and the Cocoa version is shown without it. This CL also does some clean-up in download_danger_prompt_browsertest.cc and parameterizes the test fixture to test it both with and without the secondary- ui-md flag. BUG= 662128 , 654142 Review-Url: https://codereview.chromium.org/2630243003 Cr-Commit-Position: refs/heads/master@{#445995} [modify] https://crrev.com/5fba2166ddb709508371545bdb88a9c87929615d/chrome/browser/download/download_danger_prompt.h [modify] https://crrev.com/5fba2166ddb709508371545bdb88a9c87929615d/chrome/browser/download/download_danger_prompt_browsertest.cc [modify] https://crrev.com/5fba2166ddb709508371545bdb88a9c87929615d/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/5fba2166ddb709508371545bdb88a9c87929615d/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc [modify] https://crrev.com/5fba2166ddb709508371545bdb88a9c87929615d/chrome/browser/ui/views/download/download_danger_prompt_views.cc
,
Aug 9 2017
,
Sep 5 2017
,
Sep 5 2017
,
Sep 21 2017
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eded5d090fe927b25447961e6d61df9859c36531 commit eded5d090fe927b25447961e6d61df9859c36531 Author: Peter Boström <pbos@chromium.org> Date: Mon Oct 30 22:57:41 2017 Add interactive tests for DownloadDangerPrompt. Exposes all current window titles, message bodies and cancel-button text. Also fixing crash when DownloadDangerPromptViews is destructed without triggering an action. This happens at least when browser_tests are run without --interactive, though possibly also when a tab gets closed without closing the dialog first. Bug: chromium:654142 Change-Id: I7339ffec27cb41d50ddc97aece2ca4fdf403cbb5 Reviewed-on: https://chromium-review.googlesource.com/731617 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#512660} [modify] https://crrev.com/eded5d090fe927b25447961e6d61df9859c36531/chrome/browser/download/download_danger_prompt_browsertest.cc [modify] https://crrev.com/eded5d090fe927b25447961e6d61df9859c36531/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc [modify] https://crrev.com/eded5d090fe927b25447961e6d61df9859c36531/chrome/browser/ui/views/download/download_danger_prompt_views.cc
,
Nov 10 2017
The NextAction date has arrived: 2017-11-10
,
Jan 16 2018
Load balancing
,
Jan 26 2018
"ok" and Cancel buttons are backward, here. Suspect it's intentional, but doesn't look right, especially since the default button is marked cancel.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/798e8038bec1f5923134ac43fda5e30a17d7f431 commit 798e8038bec1f5923134ac43fda5e30a17d7f431 Author: Allen Bauer <kylixrd@chromium.org> Date: Fri Feb 02 23:34:40 2018 Make sure the dangerous download dialog is 320px wide. Bug: 654142 Change-Id: I0bd9cd4fcf4337b20809a99329e429f62f14994f Reviewed-on: https://chromium-review.googlesource.com/896165 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#534195} [modify] https://crrev.com/798e8038bec1f5923134ac43fda5e30a17d7f431/chrome/browser/ui/views/download/download_danger_prompt_views.cc
,
Feb 5 2018
Here's the dialog now forced to 320px.
,
Feb 28 2018
Reassigned for UX review
,
Apr 9 2018
Dialog needs to be 448. Otherwise, LGTM |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by karandeepb@chromium.org
, Jan 23 2017111 KB
111 KB View Download
20.1 KB
20.1 KB View Download