New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654142 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug
Launch-M-Target: 64-Beta

Blocking:
issue 630357


Show other hotlists

Hotlists containing this issue:
Harmony-Ready-For-Review


Sign in to add a comment

Harmony - update download recovery dialog

Project Member Reported by shrike@chromium.org, Oct 8 2016

Issue description

See top of this doc for a screenshot of this dialog as it currently is:

https://docs.google.com/document/d/1M9AvvXafVRSNquKGhzjAqo3Pl7sSATuEECA78pfkpmA/edit#heading=h.bworb42u9xb
 
Screenshots for CL https://codereview.chromium.org/2630243003.
[Harmony Download recovery dialog on MacViews]
download_1.png
111 KB View Download
download_2.png
20.1 KB View Download

Comment 2 Deleted

Also, to summon this dialog: Go to testsafebrowsing.appspot.com. Download from any of the links listed under "Desktop Download Warnings". Go to chrome://downloads and click on "Keep Dangerous File" corresponding to the download.


Comment 4 by shrike@chromium.org, Jan 23 2017

Labels: OS-Mac
Owner: ----
Status: Available (was: Assigned)
Per shrike, unassigning his Harmony bugs for now.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fba2166ddb709508371545bdb88a9c87929615d

commit 5fba2166ddb709508371545bdb88a9c87929615d
Author: karandeepb <karandeepb@chromium.org>
Date: Wed Jan 25 11:07:44 2017

MacViews: Enable views based Download Recovery dialog behind secondary-ui-md flag.

This CL puts the views based Download Recovery dialog behind the secondary-ui-md
flag. As a result, the views based version is shown with the flag "secondary-ui-
md" enabled and the Cocoa version is shown without it.

This CL also does some clean-up in download_danger_prompt_browsertest.cc and
parameterizes the test fixture to test it both with and without the secondary-
ui-md flag.

BUG= 662128 , 654142

Review-Url: https://codereview.chromium.org/2630243003
Cr-Commit-Position: refs/heads/master@{#445995}

[modify] https://crrev.com/5fba2166ddb709508371545bdb88a9c87929615d/chrome/browser/download/download_danger_prompt.h
[modify] https://crrev.com/5fba2166ddb709508371545bdb88a9c87929615d/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/5fba2166ddb709508371545bdb88a9c87929615d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/5fba2166ddb709508371545bdb88a9c87929615d/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
[modify] https://crrev.com/5fba2166ddb709508371545bdb88a9c87929615d/chrome/browser/ui/views/download/download_danger_prompt_views.cc

Labels: -M-56
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10

Comment 10 by pbos@chromium.org, Sep 21 2017

Owner: pbos@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eded5d090fe927b25447961e6d61df9859c36531

commit eded5d090fe927b25447961e6d61df9859c36531
Author: Peter Boström <pbos@chromium.org>
Date: Mon Oct 30 22:57:41 2017

Add interactive tests for DownloadDangerPrompt.

Exposes all current window titles, message bodies and cancel-button
text.

Also fixing crash when DownloadDangerPromptViews is destructed without
triggering an action. This happens at least when browser_tests are run
without --interactive, though possibly also when a tab gets closed
without closing the dialog first.

Bug: chromium:654142
Change-Id: I7339ffec27cb41d50ddc97aece2ca4fdf403cbb5
Reviewed-on: https://chromium-review.googlesource.com/731617
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512660}
[modify] https://crrev.com/eded5d090fe927b25447961e6d61df9859c36531/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/eded5d090fe927b25447961e6d61df9859c36531/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
[modify] https://crrev.com/eded5d090fe927b25447961e6d61df9859c36531/chrome/browser/ui/views/download/download_danger_prompt_views.cc

The NextAction date has arrived: 2017-11-10

Comment 13 by bsep@chromium.org, Jan 16 2018

Owner: kylixrd@chromium.org
Load balancing
Cc: abdulsyed@chromium.org bettes@chromium.org
"ok" and Cancel buttons are backward, here. Suspect it's intentional, but doesn't look right, especially since the default button is marked cancel.
DangerousFile.png
6.2 KB View Download
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/798e8038bec1f5923134ac43fda5e30a17d7f431

commit 798e8038bec1f5923134ac43fda5e30a17d7f431
Author: Allen Bauer <kylixrd@chromium.org>
Date: Fri Feb 02 23:34:40 2018

Make sure the dangerous download dialog is 320px wide.

Bug: 654142
Change-Id: I0bd9cd4fcf4337b20809a99329e429f62f14994f
Reviewed-on: https://chromium-review.googlesource.com/896165
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534195}
[modify] https://crrev.com/798e8038bec1f5923134ac43fda5e30a17d7f431/chrome/browser/ui/views/download/download_danger_prompt_views.cc

Here's the dialog now forced to 320px.
DangerousFile320px.png
5.5 KB View Download
Cc: -bettes@chromium.org kylixrd@chromium.org
Owner: bettes@chromium.org
Reassigned for UX review
Cc: -kylixrd@chromium.org
Owner: kylixrd@chromium.org
Dialog needs to be 448. Otherwise, LGTM

Sign in to add a comment