New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654139 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug
Launch-M-Target: 64-Beta

Blocking:
issue 630357
issue 747203



Sign in to add a comment

Harmony - update ask google for suggestions dialog

Project Member Reported by shrike@chromium.org, Oct 8 2016

Issue description

Screenshot of existing dialog:

https://screenshot.googleplex.com/bh2uevSi9rS.png
 
Labels: -Proj-HarmonyDialogs-HardToSummon
How to produce:

1. Go to http://textarea.org/
2. Type anything with a spelling error and wait for the red underline.
3. Right click on the underlined word and select "Ask Google for suggestions".

See attached screenshot.
Screen Shot 2016-11-29 at 11.25.11.png
20.4 KB View Download
Owner: ----
Status: Available (was: Assigned)
Per shrike, unassigning his Harmony bugs for now.
Screenshot for https://codereview.chromium.org/2650583012/ 
[ask google for suggestions dialog on MacViews with Harmony]


Screen Shot 2017-01-25 at 5.08.53 PM.png
24.4 KB View Download

Comment 4 by tapted@chromium.org, Jul 21 2017

Blocking: 747203
Labels: -M-56
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10
Need to make sure that we make changes to 'learn more' link.  
Need to make sure that we make changes to 'learn more' link to an icon.  

Comment 10 by pbos@chromium.org, Sep 21 2017

Owner: pbos@chromium.org
Status: Assigned (was: Available)

Comment 11 by pbos@chromium.org, Oct 30 2017

Owner: ----
Status: Available (was: Assigned)
The NextAction date has arrived: 2017-11-10

Comment 13 by bsep@chromium.org, Jan 16 2018

Owner: kylixrd@chromium.org
Load balancing
What it looks like after the proscribed changes.
AskGoogleForSuggestions.png
7.4 KB View Download
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f6a13da6125b169fb4cc69f58682d9beed3ec80

commit 3f6a13da6125b169fb4cc69f58682d9beed3ec80
Author: Allen Bauer <kylixrd@chromium.org>
Date: Thu Jan 25 14:31:18 2018

Harmonize "Ask Google for suggestions" dialog.

Change link to help (question mark) vector icon.
Removed close (X) button from ConfirmBubbleView dialog bubble.

TBR=lazyboy@chromium.org

Bug: 654139
Change-Id: I99e58f98d449d83b0aaea3aa49acfd71912a6ea5
Reviewed-on: https://chromium-review.googlesource.com/871183
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531895}
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/renderer_context_menu/spelling_bubble_model.cc
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/renderer_context_menu/spelling_bubble_model.h
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/ask_google_for_suggestions_dialog_browsertest.cc
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/cocoa/confirm_bubble_controller.h
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/cocoa/confirm_bubble_controller.mm
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/confirm_bubble_model.cc
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/confirm_bubble_model.h
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/test/test_confirm_bubble_model.cc
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/test/test_confirm_bubble_model.h
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/views/confirm_bubble_views.cc
[modify] https://crrev.com/3f6a13da6125b169fb4cc69f58682d9beed3ec80/chrome/browser/ui/views/confirm_bubble_views.h

Cc: abdulsyed@chromium.org kylixrd@chromium.org
Owner: bettes@chromium.org
Cc: -kylixrd@chromium.org
Owner: kylixrd@chromium.org
body text needs to use the Body 1 secondary. Everything lgtm

Screen Shot 2018-03-08 at 6.30.02 PM.png
83.9 KB View Download
Status: Assigned (was: Available)

Sign in to add a comment