New issue
Advanced search Search tips

Issue 654138 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

DevTools: CPU throttling should disable when DevTools are closed.

Project Member Reported by alph@chromium.org, Oct 8 2016

Issue description

DevTools: CPU throttling should disable when DevTools are closed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94eb2d6a00a578b21a22f5c8cc9e5661d29b2a9e

commit 94eb2d6a00a578b21a22f5c8cc9e5661d29b2a9e
Author: alph <alph@chromium.org>
Date: Sat Oct 08 02:00:01 2016

DevTools: CPU throttling should disable when DevTools are closed.

BUG= 654138 

Review-Url: https://codereview.chromium.org/2399883005
Cr-Commit-Position: refs/heads/master@{#424042}

[modify] https://crrev.com/94eb2d6a00a578b21a22f5c8cc9e5661d29b2a9e/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

Comment 2 by alph@chromium.org, Oct 8 2016

Labels: Merge-Request-54 Merge-Request-55

Comment 3 by dimu@chromium.org, Oct 9 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.

Comment 4 by dimu@chromium.org, Oct 9 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 5 by dimu@chromium.org, Oct 9 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b18f021b28b4505f72f9ee7699e5909f0e9701b

commit 4b18f021b28b4505f72f9ee7699e5909f0e9701b
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Oct 10 18:34:54 2016

DevTools: CPU throttling should disable when DevTools are closed.

BUG= 654138 

Review-Url: https://codereview.chromium.org/2399883005
Cr-Commit-Position: refs/heads/master@{#424042}
(cherry picked from commit 94eb2d6a00a578b21a22f5c8cc9e5661d29b2a9e)

Review URL: https://codereview.chromium.org/2404923003 .

Cr-Commit-Position: refs/branch-heads/2883@{#15}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/4b18f021b28b4505f72f9ee7699e5909f0e9701b/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

Labels: -Merge-Review-54 Merge-Approved-54
This change meets the bar and is approved for M54, please merge than change by 5pm today to make it in time for tonight's stable cut.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 10 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/778c47b7cbf6424faa66e77efc451d39bce02918

commit 778c47b7cbf6424faa66e77efc451d39bce02918
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Oct 10 20:49:42 2016

DevTools: CPU throttling should disable when DevTools are closed.

BUG= 654138 

Review-Url: https://codereview.chromium.org/2399883005
Cr-Commit-Position: refs/heads/master@{#424042}
(cherry picked from commit 94eb2d6a00a578b21a22f5c8cc9e5661d29b2a9e)

Review URL: https://codereview.chromium.org/2407973002 .

Cr-Commit-Position: refs/branch-heads/2840@{#706}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/778c47b7cbf6424faa66e77efc451d39bce02918/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

Comment 9 by alph@chromium.org, Oct 10 2016

Status: Fixed (was: Started)

Comment 10 by alph@chromium.org, Oct 10 2016

Components: Platform>DevTools>Performance

Comment 11 by alph@chromium.org, Oct 11 2016

Steps to verify:
1. Open a page, preferable with an animation, e.g. http://codepen.io/eltonkamami/full/ECrKd/
2. Open DevTools Timeline panel
3. Set CPU throttling to 5x slowdown.
4. Notice the animation gets janky.
5. Close DevTools, the animation should be smooth again.
Labels: TE-Verified-55.0.2883.9
Verified the fix on Windows 7, 10, Mac OSX 10.11.6 and Linux(ubuntu 14.04Lts) with Chrome version 55.0.2883.9 and followed steps from comment#11 and there are no jankyness once Devtools is closed(Animation was smooth again).
Labels: TE-Verified-54.0.2840.59 TE-Verified-M54
Verified the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 54.0.2840.59.Observed animation was smooth when devtools was closed.
Please find the attached screen cast for the same.

Adding TE-Verified labels.
654138.mp4
21.1 MB Download
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b18f021b28b4505f72f9ee7699e5909f0e9701b

commit 4b18f021b28b4505f72f9ee7699e5909f0e9701b
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Oct 10 18:34:54 2016

DevTools: CPU throttling should disable when DevTools are closed.

BUG= 654138 

Review-Url: https://codereview.chromium.org/2399883005
Cr-Commit-Position: refs/heads/master@{#424042}
(cherry picked from commit 94eb2d6a00a578b21a22f5c8cc9e5661d29b2a9e)

Review URL: https://codereview.chromium.org/2404923003 .

Cr-Commit-Position: refs/branch-heads/2883@{#15}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/4b18f021b28b4505f72f9ee7699e5909f0e9701b/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/778c47b7cbf6424faa66e77efc451d39bce02918

commit 778c47b7cbf6424faa66e77efc451d39bce02918
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Oct 10 20:49:42 2016

DevTools: CPU throttling should disable when DevTools are closed.

BUG= 654138 

Review-Url: https://codereview.chromium.org/2399883005
Cr-Commit-Position: refs/heads/master@{#424042}
(cherry picked from commit 94eb2d6a00a578b21a22f5c8cc9e5661d29b2a9e)

Review URL: https://codereview.chromium.org/2407973002 .

Cr-Commit-Position: refs/branch-heads/2840@{#706}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/778c47b7cbf6424faa66e77efc451d39bce02918/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

Sign in to add a comment