New issue
Advanced search Search tips

Issue 654134 link

Starred by 2 users
Status: Fixed
Owner:
kainino@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 345227
Blocking:
issue 295792



Sign in to add a comment

Split off WebGL 2.0 version of EXT_disjoint_timer_query

Project Member Reported by kbr@chromium.org, Oct 8 2016 
In https://github.com/KhronosGroup/WebGL/pull/2076 a separate version of EXT_disjoint_timer_query was defined for WebGL 2.0, re-using the main context's query object type, and eliminating the redundant entry point. This extension is queried under getExtension('EXT_disjoint_timer_query_webgl2'). The WebGL 1.0 version isn't exposed in WebGL 2.0.

This needs to be split off in Chrome's implementation.

Kai, may I assign this to you?

Comment 1 by kainino@chromium.org, Oct 19 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59676aad126fd02505c5d36c4572d7ac46a43774

commit 59676aad126fd02505c5d36c4572d7ac46a43774
Author: kainino <kainino@chromium.org>
Date: Tue Oct 25 02:47:59 2016

Roll WebGL b973c09..fa214ea

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/b973c09..fa214ea

BUG= 654134 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2448743002
Cr-Commit-Position: refs/heads/master@{#427252}

[modify] https://crrev.com/59676aad126fd02505c5d36c4572d7ac46a43774/DEPS

Comment 3 by kainino@chromium.org, Oct 25 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3eba0f99e3841bc85072e9a5a097d0fa54a06532

commit 3eba0f99e3841bc85072e9a5a097d0fa54a06532
Author: kainino <kainino@chromium.org>
Date: Tue Oct 25 17:47:08 2016

Implement EXT_disjoint_timer_query_webgl2

Added in https://github.com/KhronosGroup/WebGL/pull/2076

BUG= 654134 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2437233002
Cr-Commit-Position: refs/heads/master@{#427402}

[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/BUILD.gn
[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp
[add] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.cpp
[add] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.h
[add] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.idl
[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp
[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.h
[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/WebGLExtensionName.h
[modify] https://crrev.com/3eba0f99e3841bc85072e9a5a097d0fa54a06532/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
►

Sign in to add a comment