Is this a replacement for the alert that pops up when uninstalling an extension? I don't think I understand why this dialog was labelled HardToSummon, could you provide some clarification please?

Sorry - it should not have been marked hard to summon.

Per shrike, unassigning his Harmony bugs for now.

Load balancing

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4aaeb134aedda72509ecca96aca5cd3ff25d8bb

commit c4aaeb134aedda72509ecca96aca5cd3ff25d8bb
Author: Peter Boström <pbos@chromium.org>
Date: Fri Nov 03 06:06:33 2017

Update look of extension-uninstall dialog.

* Puts Remove "Extension Name"?' as title instead of "Confirm Removal".
* Removes body text except for extension uninstall by other extensions.
  This kept text is used to attribute which extension tried to uninstall
  it.
* Moves "Report Abuse" checkbox to main dialog.
* Adds which extension to report abuse for in the case of an extension
  uninstalling the other. Before it was ambiguous whether to report the
  extension to be uninstalled or the one trying to uninstall it.

Also adding interactive browser tests for the different variations of
the dialog.

Bug:  chromium:654133 
Change-Id: I6add7318a2585421ade77ea9a5e9d9ebd73e2438
Reviewed-on: https://chromium-review.googlesource.com/742454
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513707}
[modify] https://crrev.com/c4aaeb134aedda72509ecca96aca5cd3ff25d8bb/chrome/app/generated_resources.grd
[modify] https://crrev.com/c4aaeb134aedda72509ecca96aca5cd3ff25d8bb/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
[modify] https://crrev.com/c4aaeb134aedda72509ecca96aca5cd3ff25d8bb/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc

I think this is ready for review now. Here's a screenshot.

Discrepancy from specs:

* When an extension tries to remove another extension we clarify that "ExtensionRemover" would like to remove this extension (this case wasn't covered by specs).
* When extension A tries to remove extension B, we clarify the report abuse button as "Report abuse from B", as "report abuse is ambiguous between the two extensions".
* Does not anchor to the app icon, in this example screenshot you can see that we're removing an extension that does not have a location bar icon that we can anchor to. As such we never anchor to the extension icon because there's no guarantee one exists.
* Instead we show the extension icon in the dialog title.

Deleted: remove-extension.png 41.3 KB

	remove-extension.png 41.3 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0399b583673ea289ac01228073b438a9b4e3a8c

commit d0399b583673ea289ac01228073b438a9b4e3a8c
Author: Peter Boström <pbos@chromium.org>
Date: Wed Nov 08 02:24:16 2017

Update Label style for extension-uninstall dialog.

Text now uses "body 1" and "secondary" as specified by mocks. This only
applies to extension uninstall triggered by another extension.

Bug:  chromium:654133 
Change-Id: I944bb66be36145bab74aec3a95409459aca49d93
Reviewed-on: https://chromium-review.googlesource.com/758039
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514713}
[modify] https://crrev.com/d0399b583673ea289ac01228073b438a9b4e3a8c/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

The NextAction date has arrived: 2017-11-10

* Does not anchor to the app icon, in this example screenshot you can see that we're removing an extension that does not have a location bar icon that we can anchor to. As such we never anchor to the extension icon because there's no guarantee one exists.
* Instead we show the extension icon in the dialog title.


In the event of deletion, why can't we surface the icon in the toolbar? My assumption is that most deletions are made through the context menu so by surfacing the icon, we can guide the user's attention from one anchored dialog to another. In this world, we're jumping from an anchored dialog to a modal dialog.  

+bsep@, wdyt? I don't think we can easily surface the icon in the toolbar during deletion (for extensions that don't have one), should we try to anchor to the toolbar when one exists (not removed from chrome://extensions) ?

Hmm, you might be able to attach to the icon the same way that ExtensionInstalledBubbleView does. If it turns out to be difficult what you have now is fine, since that's how it works currently.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4de8e3ad8a9b72d2464384f708b5b43a57baa01d

commit 4de8e3ad8a9b72d2464384f708b5b43a57baa01d
Author: Peter Boström <pbos@chromium.org>
Date: Fri Jan 12 17:50:20 2018

Anchor extension-uninstall dialog.

Anchors the uninstall dialog to the toolbar item if it's both available
(pre-installed extensions might not have toolbar items) and visible
(normally when not hidden under the Chrome menu).

Also fixes the dialog width down to the expected 448px modal width by
removing margins when calculating preferred size and left pads margin
to align contents with the title.

Bug:  chromium:654133 
Change-Id: I7ee3e601141af7099c1fafb92558289625743784
Reviewed-on: https://chromium-review.googlesource.com/857894
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528990}
[modify] https://crrev.com/4de8e3ad8a9b72d2464384f708b5b43a57baa01d/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

The dialog now anchors to visible icons (not hidden in the Chrome app menu), surfacing the icon as well is out of scope. I'll send a follow-up potential to the extensions team, they said they have some code for surfacing it that may be relevant.