See https://docs.google.com/document/d/13XsbaBz7A2H0PZIdFcytHf5-fVOlAfkLlIUKhxKzs44/edit#heading=h.iice88dk6491 for an overview.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28e4cd6cdb271055f445717508ebea7595fa4676 commit 28e4cd6cdb271055f445717508ebea7595fa4676 Author: dglazkov <dglazkov@chromium.org> Date: Sat Oct 08 04:51:00 2016 Move the setting of bindings code generator up the stack. This opens the path for cleanly switching different types of code generators. Also eliminates the need for IdlCompilerV8 and IdlCompilerDictionaryImpl. R=bashi,yukishiino BUG= 654129 Review-Url: https://codereview.chromium.org/2401043003 Cr-Commit-Position: refs/heads/master@{#424070} [modify] https://crrev.com/28e4cd6cdb271055f445717508ebea7595fa4676/third_party/WebKit/Source/bindings/scripts/idl_compiler.py [modify] https://crrev.com/28e4cd6cdb271055f445717508ebea7595fa4676/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe30a9ea6cfb1ea9e1517ca5de16a8013c5407c8 commit fe30a9ea6cfb1ea9e1517ca5de16a8013c5407c8 Author: dglazkov <dglazkov@chromium.org> Date: Sat Oct 29 01:45:21 2016 Bindings tests should run the same code as prod code. Removed and unified a bunch of code paths (more to go) so that the bindings tests run more of the same code as what's used to build Blink. R=yukishiino, bashi BUG= 654129 Review-Url: https://codereview.chromium.org/2458203002 Cr-Commit-Position: refs/heads/master@{#428584} [modify] https://crrev.com/fe30a9ea6cfb1ea9e1517ca5de16a8013c5407c8/third_party/WebKit/Source/bindings/scripts/idl_compiler.py [modify] https://crrev.com/fe30a9ea6cfb1ea9e1517ca5de16a8013c5407c8/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b0259349e5a2358021cba9d63b1bcbe706a99fc commit 0b0259349e5a2358021cba9d63b1bcbe706a99fc Author: dglazkov <dglazkov@chromium.org> Date: Sat Nov 05 03:59:28 2016 Wrap the comment in bindings codegen template to be more 80-col friendly. Since we're trying to adopt to new style, let's make sure we have plenty of characters left for a filename in the template. Otherwise, names like `web_module_code_generator.py` make it go over the limit, which in turn makes `git cl format` sad. R=yukishiino,bashi BUG= 654129 NOTRY=true Review-Url: https://codereview.chromium.org/2481513002 Cr-Commit-Position: refs/heads/master@{#430146} [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/templates/copyright_block.txt [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceEventInit.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceEventInit.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.h [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp [modify] https://crrev.com/0b0259349e5a2358021cba9d63b1bcbe706a99fc/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9b5677d326f0bd75e2a191d1e1316068518f039 commit e9b5677d326f0bd75e2a191d1e1316068518f039 Author: dglazkov <dglazkov@chromium.org> Date: Sat Nov 12 00:21:55 2016 Add first sketch of the webmodules code generator. This is the beginning of the C++ code generator that will generate the replacemenet for the Web* interfaces (aka WebKit API). There's not much to see here at the moment, just the inklings of the future. R=yukishiino,bashi BUG= 654129 NOTRY=true Review-Url: https://codereview.chromium.org/2458913003 Cr-Commit-Position: refs/heads/master@{#431696} [modify] https://crrev.com/e9b5677d326f0bd75e2a191d1e1316068518f039/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt [add] https://crrev.com/e9b5677d326f0bd75e2a191d1e1316068518f039/third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py [modify] https://crrev.com/e9b5677d326f0bd75e2a191d1e1316068518f039/third_party/WebKit/Source/bindings/scripts/idl_compiler.py [modify] https://crrev.com/e9b5677d326f0bd75e2a191d1e1316068518f039/third_party/WebKit/Source/bindings/scripts/scripts.gni [modify] https://crrev.com/e9b5677d326f0bd75e2a191d1e1316068518f039/third_party/WebKit/Source/bindings/templates/templates.gni [add] https://crrev.com/e9b5677d326f0bd75e2a191d1e1316068518f039/third_party/WebKit/Source/bindings/templates/web_module_interface.cpp.tmpl [modify] https://crrev.com/e9b5677d326f0bd75e2a191d1e1316068518f039/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface3.idl [add] https://crrev.com/e9b5677d326f0bd75e2a191d1e1316068518f039/third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.cpp [add] https://crrev.com/e9b5677d326f0bd75e2a191d1e1316068518f039/third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.h [modify] https://crrev.com/e9b5677d326f0bd75e2a191d1e1316068518f039/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7340622bc0a7c7d613a8ec6e8c63aea934b3503 commit f7340622bc0a7c7d613a8ec6e8c63aea934b3503 Author: dglazkov <dglazkov@chromium.org> Date: Sun Nov 20 00:02:01 2016 Stop using v8_interface.interface_context in Web modules bindings. We should build our own instead of reusing, let's do that. Also, let's start generating something for the header files. R=yukishiino,bashi BUG= 654129 NOTRY=true Review-Url: https://codereview.chromium.org/2495033003 Cr-Commit-Position: refs/heads/master@{#433435} [modify] https://crrev.com/f7340622bc0a7c7d613a8ec6e8c63aea934b3503/third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py [modify] https://crrev.com/f7340622bc0a7c7d613a8ec6e8c63aea934b3503/third_party/WebKit/Source/bindings/templates/web_module_interface.cpp.tmpl [add] https://crrev.com/f7340622bc0a7c7d613a8ec6e8c63aea934b3503/third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl [modify] https://crrev.com/f7340622bc0a7c7d613a8ec6e8c63aea934b3503/third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.cpp [modify] https://crrev.com/f7340622bc0a7c7d613a8ec6e8c63aea934b3503/third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ea86d59d0c3023efd5f0f01b1f7c43056f1a647 commit 9ea86d59d0c3023efd5f0f01b1f7c43056f1a647 Author: dglazkov <dglazkov@chromium.org> Date: Fri Dec 09 04:38:56 2016 Add running unit tests to run-bindings-tests. Following up on the outcome of discussions on https://codereview.chromium.org/2553503002, added a typ runner at the end of run-bindings-tests. Now, every unit test in Source/bindings/scripts will be automatically ran by run-bindings-tests. R=dpranke,bashi,yukishiino BUG= 654129 Review-Url: https://codereview.chromium.org/2554503004 Cr-Commit-Position: refs/heads/master@{#437468} [modify] https://crrev.com/9ea86d59d0c3023efd5f0f01b1f7c43056f1a647/third_party/WebKit/Tools/Scripts/run-bindings-tests [modify] https://crrev.com/9ea86d59d0c3023efd5f0f01b1f7c43056f1a647/third_party/WebKit/Tools/Scripts/test-webkitpy [modify] https://crrev.com/9ea86d59d0c3023efd5f0f01b1f7c43056f1a647/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py [modify] https://crrev.com/9ea86d59d0c3023efd5f0f01b1f7c43056f1a647/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c7a8ec99ddb52ef1e0db1423b7a774f85506bc2 commit 0c7a8ec99ddb52ef1e0db1423b7a774f85506bc2 Author: dglazkov <dglazkov@chromium.org> Date: Tue Dec 13 02:27:36 2016 Add first bindings unit test and enable testing. Also: * Quick refactor of jinja2 context creation into a builder. * Switched Attribute/Method to dicts. * Added a bit more meat more to header template. * Added nicer parameter handling to run-bindings-tests * Added stub helper for unit tests. BUG= 654129 R=bashi,yukishiino,haraken Review-Url: https://codereview.chromium.org/2568693002 Cr-Commit-Position: refs/heads/master@{#437989} [modify] https://crrev.com/0c7a8ec99ddb52ef1e0db1423b7a774f85506bc2/third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py [add] https://crrev.com/0c7a8ec99ddb52ef1e0db1423b7a774f85506bc2/third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py [modify] https://crrev.com/0c7a8ec99ddb52ef1e0db1423b7a774f85506bc2/third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl [modify] https://crrev.com/0c7a8ec99ddb52ef1e0db1423b7a774f85506bc2/third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.cpp [modify] https://crrev.com/0c7a8ec99ddb52ef1e0db1423b7a774f85506bc2/third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.h [modify] https://crrev.com/0c7a8ec99ddb52ef1e0db1423b7a774f85506bc2/third_party/WebKit/Tools/Scripts/run-bindings-tests
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5406d40da936510622cdfe5e64756006ebdc0189 commit 5406d40da936510622cdfe5e64756006ebdc0189 Author: dglazkov <dglazkov@chromium.org> Date: Wed Dec 14 15:22:35 2016 Add inheritance support to Webmodules template. BUG= 654129 R=bashi,peria Review-Url: https://codereview.chromium.org/2573013002 Cr-Commit-Position: refs/heads/master@{#438521} [modify] https://crrev.com/5406d40da936510622cdfe5e64756006ebdc0189/third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py [modify] https://crrev.com/5406d40da936510622cdfe5e64756006ebdc0189/third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py [modify] https://crrev.com/5406d40da936510622cdfe5e64756006ebdc0189/third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5614aacc8b2836a85f9bb93cab08d9fe427684b commit b5614aacc8b2836a85f9bb93cab08d9fe427684b Author: dglazkov <dglazkov@chromium.org> Date: Tue Dec 20 05:20:59 2016 [Webmodules]: Start handling types a bit more intelligently. * Introduce TypeResolver to manage conversion from WebIDL types to C++ types and paths * Add is_void and is_date to IdlType * Add tests R=bashi,peria,yukishiino BUG= 654129 Review-Url: https://codereview.chromium.org/2581373004 Cr-Commit-Position: refs/heads/master@{#439716} [modify] https://crrev.com/b5614aacc8b2836a85f9bb93cab08d9fe427684b/third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py [modify] https://crrev.com/b5614aacc8b2836a85f9bb93cab08d9fe427684b/third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py [modify] https://crrev.com/b5614aacc8b2836a85f9bb93cab08d9fe427684b/third_party/WebKit/Source/bindings/scripts/idl_types.py [add] https://crrev.com/b5614aacc8b2836a85f9bb93cab08d9fe427684b/third_party/WebKit/Source/bindings/scripts/idl_types_test.py [modify] https://crrev.com/b5614aacc8b2836a85f9bb93cab08d9fe427684b/third_party/WebKit/Source/bindings/templates/web_module_interface.cpp.tmpl [modify] https://crrev.com/b5614aacc8b2836a85f9bb93cab08d9fe427684b/third_party/WebKit/Source/bindings/tests/results/core/WebTestInterface3.cpp
Renaming to reflect new terminology.
slangley@, these are the bugs I owned around Web Agents. Please triage/close as you see fit.
Joel, could you triage or close this issue?
Comment 1 by bugdroid1@chromium.org
, Oct 8 2016