Harmony - update extensions new permissions dialog |
|||||||||||||
Issue description
,
Mar 15 2017
,
Mar 16 2017
,
Aug 9 2017
,
Sep 5 2017
,
Sep 5 2017
,
Sep 22 2017
,
Sep 22 2017
This is, believe it or not, also handled by ExtensionInstallDialogView (via ExtensionInstallPrompt::PromptType::RE_ENABLE_PROMPT). But it's so much different than the default version that I think it's worth keeping as a separate item.
,
Sep 22 2017
Same story for the "extension install remotely" dialog (screenshot attached).
,
Oct 6 2017
,
Oct 20 2017
Load balancing
,
Nov 10 2017
The NextAction date has arrived: 2017-11-10
,
Jan 10 2018
Taking this back for now, since it's related to the Extension Install dialog
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56f8225cdd0c19f97cb10d41333da6d646c469db commit 56f8225cdd0c19f97cb10d41333da6d646c469db Author: Bret Sepulveda <bsep@chromium.org> Date: Mon Jan 29 20:05:04 2018 Fix long extension install dialog titles from laying out on one line. Versions of the dialog with long titles, like the "re-enable with new permissions" or the "extension installed externally" dialogs, are affected by this change. Instead of wrapping, their titles would all be on one big line, making the dialog extremely wide. This is fixed. This patch also adds interactive browser tests for "withheld" permissions and for the "re-enable" version of the dialog. Bug: 654124 Change-Id: Iaffdede6a9977952f83a4393425a4df58007d05e Reviewed-on: https://chromium-review.googlesource.com/885104 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#532559} [modify] https://crrev.com/56f8225cdd0c19f97cb10d41333da6d646c469db/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/56f8225cdd0c19f97cb10d41333da6d646c469db/chrome/browser/ui/views/extensions/extension_install_dialog_view.h [modify] https://crrev.com/56f8225cdd0c19f97cb10d41333da6d646c469db/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
,
Jan 31 2018
Depends on the merged CL (0ea59b31b832031f9fdbce7e10e26f6e0c20dbe5) in bug 605657 .
,
Jan 31 2018
Approving this for merge. M65, branch:3325
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e77ba1571e060ccc51b5fbf2706cd153b3b13700 commit e77ba1571e060ccc51b5fbf2706cd153b3b13700 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jan 31 23:20:39 2018 Fix long extension install dialog titles from laying out on one line. Versions of the dialog with long titles, like the "re-enable with new permissions" or the "extension installed externally" dialogs, are affected by this change. Instead of wrapping, their titles would all be on one big line, making the dialog extremely wide. This is fixed. This patch also adds interactive browser tests for "withheld" permissions and for the "re-enable" version of the dialog. TBR=bsep@chromium.org (cherry picked from commit 56f8225cdd0c19f97cb10d41333da6d646c469db) Bug: 654124 Change-Id: Iaffdede6a9977952f83a4393425a4df58007d05e Reviewed-on: https://chromium-review.googlesource.com/885104 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#532559} Reviewed-on: https://chromium-review.googlesource.com/896503 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#217} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/e77ba1571e060ccc51b5fbf2706cd153b3b13700/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/e77ba1571e060ccc51b5fbf2706cd153b3b13700/chrome/browser/ui/views/extensions/extension_install_dialog_view.h [modify] https://crrev.com/e77ba1571e060ccc51b5fbf2706cd153b3b13700/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
,
Jul 25
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by pkasting@chromium.org
, Jan 24 2017Status: Available (was: Assigned)