New issue
Advanced search Search tips

Issue 654124 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug
Launch-M-Target: 64-Beta

Blocking:
issue 630357
issue 702019


Participants' hotlists:
HarmonyFutureP1s


Sign in to add a comment

Harmony - update extensions new permissions dialog

Project Member Reported by shrike@chromium.org, Oct 7 2016

Issue description

Owner: ----
Status: Available (was: Assigned)
Per shrike, unassigning his Harmony bugs for now.

Comment 2 by tapted@chromium.org, Mar 15 2017

Description: Show this description

Comment 3 by tapted@chromium.org, Mar 16 2017

Blocking: 702019
Labels: -M-56
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10

Comment 7 by bsep@chromium.org, Sep 22 2017

Description: Show this description

Comment 8 by bsep@chromium.org, Sep 22 2017

This is, believe it or not, also handled by ExtensionInstallDialogView (via ExtensionInstallPrompt::PromptType::RE_ENABLE_PROMPT). But it's so much different than the default version that I think it's worth keeping as a separate item.

Comment 9 Deleted

Comment 10 by bsep@chromium.org, Sep 22 2017

Same story for the "extension install remotely" dialog (screenshot attached).
remote-extension.png
35.1 KB View Download

Comment 11 by bsep@chromium.org, Oct 6 2017

Labels: -Pri-2 Pri-1

Comment 12 by bsep@chromium.org, Oct 20 2017

Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)
Load balancing
The NextAction date has arrived: 2017-11-10

Comment 14 by bsep@chromium.org, Jan 10 2018

Owner: bsep@chromium.org
Taking this back for now, since it's related to the Extension Install dialog
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56f8225cdd0c19f97cb10d41333da6d646c469db

commit 56f8225cdd0c19f97cb10d41333da6d646c469db
Author: Bret Sepulveda <bsep@chromium.org>
Date: Mon Jan 29 20:05:04 2018

Fix long extension install dialog titles from laying out on one line.

Versions of the dialog with long titles, like the "re-enable with new
permissions" or the "extension installed externally" dialogs, are
affected by this change. Instead of wrapping, their titles would all
be on one big line, making the dialog extremely wide. This is fixed.

This patch also adds interactive browser tests for "withheld"
permissions and for the "re-enable" version of the dialog.

Bug:  654124 
Change-Id: Iaffdede6a9977952f83a4393425a4df58007d05e
Reviewed-on: https://chromium-review.googlesource.com/885104
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532559}
[modify] https://crrev.com/56f8225cdd0c19f97cb10d41333da6d646c469db/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/56f8225cdd0c19f97cb10d41333da6d646c469db/chrome/browser/ui/views/extensions/extension_install_dialog_view.h
[modify] https://crrev.com/56f8225cdd0c19f97cb10d41333da6d646c469db/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

Comment 16 by bsep@chromium.org, Jan 31 2018

Labels: Merge-Request-65
Depends on the merged CL (0ea59b31b832031f9fdbce7e10e26f6e0c20dbe5) in  bug 605657 .
Labels: -Merge-Request-65 Merge-Approved-65
Approving this for merge. M65, branch:3325
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 31 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e77ba1571e060ccc51b5fbf2706cd153b3b13700

commit e77ba1571e060ccc51b5fbf2706cd153b3b13700
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Jan 31 23:20:39 2018

Fix long extension install dialog titles from laying out on one line.

Versions of the dialog with long titles, like the "re-enable with new
permissions" or the "extension installed externally" dialogs, are
affected by this change. Instead of wrapping, their titles would all
be on one big line, making the dialog extremely wide. This is fixed.

This patch also adds interactive browser tests for "withheld"
permissions and for the "re-enable" version of the dialog.

TBR=bsep@chromium.org

(cherry picked from commit 56f8225cdd0c19f97cb10d41333da6d646c469db)

Bug:  654124 
Change-Id: Iaffdede6a9977952f83a4393425a4df58007d05e
Reviewed-on: https://chromium-review.googlesource.com/885104
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532559}
Reviewed-on: https://chromium-review.googlesource.com/896503
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#217}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/e77ba1571e060ccc51b5fbf2706cd153b3b13700/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/e77ba1571e060ccc51b5fbf2706cd153b3b13700/chrome/browser/ui/views/extensions/extension_install_dialog_view.h
[modify] https://crrev.com/e77ba1571e060ccc51b5fbf2706cd153b3b13700/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

Status: Fixed (was: Assigned)
Done per  bug 605657 

Sign in to add a comment