New issue
Advanced search Search tips

Issue 654121 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 654128
Owner: ----
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug
Launch-M-Target: 64-Beta

Blocking:
issue 630357



Sign in to add a comment

Harmony - update extensions NTP dialog

Project Member Reported by shrike@chromium.org, Oct 7 2016

Issue description

Owner: ----
Status: Available (was: Assigned)
Per shrike, unassigning his Harmony bugs for now.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0400d0a14218e82b41e2be64fb3174e70352b4e7

commit 0400d0a14218e82b41e2be64fb3174e70352b4e7
Author: tapted <tapted@chromium.org>
Date: Mon Mar 13 06:09:17 2017

MacViews: Harmony for toolbar actions bubbles.

These are used for
 - DevModeBubbleDelegate
 - NtpOverriddenBubbleDelegate
 - ProxyOverriddenBubbleDelegate
 - SettingsApiBubbleDelegate
 - SuspiciousExtensionBubbleDelegate
 - BlockedActionBubbleDelegate

Adds a ToolbarActionsBarBubbleViewsPresenter for showing the
toolkit-views bubble on a Cocoa browser. It observes the Views bubble
and notifies the Cocoa BrowserActionsController when it closes.

One issue: the Cocoa bubble uses a `BOOL anchoredToAction;` data member
whereas the Views bubble inspects the anchor_view's ID. The latter
doesn't work for a Cocoa browser, so make these consistent by adding the
same data member to the views bubble.

Adds a TestBrowserDialog case for showing the DevModeBubble with Views
on all desktop platforms. These need to be added for the other bubble
types.

Brings up all the views-based toolbar action bubble tests on Mac by
factoring out two functions that depend on whether the Browser window is
Cocoa or toolkit-views.

Screenshot at  http://crbug.com/654128#c5  (it's currently too wide under
Harmony on Mac, but there are framework fixes coming for that).

The interactive bubble test can be invoked with `browser_tests
--gtest_filter=BrowserDialogTest.Invoke --interactive
--dialog=ExtensionMessageBubbleViewBrowserTest.InvokeDialog_devmode_warning`

BUG= 654128 ,  654126 ,  654121 

Review-Url: https://codereview.chromium.org/2630473003
Cr-Commit-Position: refs/heads/master@{#456329}

[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/cocoa/extensions/browser_actions_controller.h
[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
[add] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/cocoa/extensions/extension_message_bubble_views_browsertest_mac.mm
[add] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_views_presenter.h
[add] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_views_presenter.mm
[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h
[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/test/test_browser_dialog.cc
[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
[add] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest_nonmac.cc
[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc
[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h
[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc
[modify] https://crrev.com/0400d0a14218e82b41e2be64fb3174e70352b4e7/chrome/test/BUILD.gn

Description: Show this description
Labels: -M-56
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10

Comment 7 by bsep@chromium.org, Sep 22 2017

Mergedinto: 654128
Status: Duplicate (was: Available)
Handled by the same class as "disable developer mode"
The NextAction date has arrived: 2017-11-10

Sign in to add a comment