New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654117 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug
Launch-M-Target: 64-Beta

Blocking:
issue 630357


Show other hotlists

Hotlists containing this issue:
Harmony-Ready-For-Review


Sign in to add a comment

Harmony - update password sign-in promo dialog

Project Member Reported by shrike@chromium.org, Oct 7 2016

Issue description

Comment 1 by shrike@chromium.org, Oct 11 2016

Owner: bsep@chromium.org
Labels: -M-56
Owner: ----
Status: Available (was: Assigned)
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10
The NextAction date has arrived: 2017-11-10

Comment 8 by bsep@chromium.org, Dec 13 2017

Description: Show this description

Comment 9 by bsep@chromium.org, Dec 13 2017

Owner: pbos@chromium.org
Status: Assigned (was: Available)
Load balancing (though it may be covered under  bug 654115 ).

Comment 10 by pbos@chromium.org, Jan 11 2018

Cc: vasi...@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a793e4b47c8ce97469529892052f3a2af3e0afb1

commit a793e4b47c8ce97469529892052f3a2af3e0afb1
Author: Peter Boström <pbos@chromium.org>
Date: Mon Jan 29 18:26:27 2018

Harmonize password sign-in promo.

* Separates the title from the promotion content (adds a secondary-style
  Label for body content).
* Removes the "no thanks" button (still present in the Cocoa version).

Bug:  chromium:654115 , chromium:654117
Change-Id: I83274934bfff8eaec6e5065233661ddd91447d39
Reviewed-on: https://chromium-review.googlesource.com/887726
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532500}
[modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/app/generated_resources.grd
[modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/browser/ui/views/passwords/password_pending_view.cc
[modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/browser/ui/views/passwords/password_pending_view.h
[modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/browser/ui/views/passwords/password_sign_in_promo_view.cc
[modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/browser/ui/views/passwords/password_sign_in_promo_view.h

Comment 12 by pbos@chromium.org, Jan 29 2018

Cc: pbos@chromium.org
Owner: bettes@chromium.org

Comment 13 by pbos@chromium.org, Jan 29 2018

Screenshot: https://i.imgur.com/Umbh6ft.png

Comment 14 by pbos@chromium.org, Jan 29 2018

Actually, the screenshot is slightly different from submitted behavior, it says "Sign in" not "Sign in to Chrome".
Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tested the issue on Win-10, mac 10.12.6 and ubuntu 14.04 using latest chrome version #66.0.3335.0.
Attached a screen cast and screenshot for reference.

Following are the steps followed to reproduce the issue.
------------
1. Opened gmail.com and logged into it.
2. On clicking the key icon in omnibox, it prompted for password save with "save" and "never" button.
3. Saved the password by clicking on "save" button. Again clicked on the key icon.
4. Observed a dialog box with content as "To get your passwords on all your devices, sign in to chrome." with a "password saved" button.
5. Again clicked on the key icon and observed user id and saved password with a trash icon as in the attached screen cast.

pbos@/bettes@ - Could you please check the screen cast and screenshot and please let us know the expected behaviour and confirm the fix.

Thanks...!!
654117.mp4
2.0 MB View Download
654117.png
494 KB View Download

Comment 16 by pbos@chromium.org, Jan 31 2018

Owner: pbos@chromium.org
Oops, my bad. This was a refactoring done after getting the screenshot. Good catch!

Comment 17 by pbos@chromium.org, Jan 31 2018

Pending CL with fix makes this the current behavior. It's wonky (long title wrapping) because this is signs in from another URL, most usages just see "this site" instead of the URL.

The expected behavior is still that the list of saved passwords show up if you click the passwords (key) icon after this dialog has been dismissed, so that part is correct. I'm only correcting the button label.
wonky-wonk-signin.png
24.2 KB View Download
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dbf954db893a1eee092ecdabb231574f258b02a

commit 6dbf954db893a1eee092ecdabb231574f258b02a
Author: Peter Boström <pbos@chromium.org>
Date: Wed Jan 31 23:47:05 2018

Use correct button for password sign-in promo.

Bug: chromium:654117
Change-Id: I23ef8a2c11fa46ce8a8e66e0c04c72755eb022f6
Reviewed-on: https://chromium-review.googlesource.com/896107
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533474}
[modify] https://crrev.com/6dbf954db893a1eee092ecdabb231574f258b02a/chrome/browser/ui/views/passwords/password_sign_in_promo_view.cc

Comment 19 by pbos@chromium.org, Jan 31 2018

Owner: bettes@chromium.org

Sign in to add a comment