Mock: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview#%2FP%20-%20passwords_01.png%3Fz=width
Updated mock link: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview/06-Passwords#%2F01-Passwords_save.png%3Fz=width
Attaching how it currently looks on mac (the Cocoa dialog). There's some plumbing to do so that the toolkit-views dialog shows instead up on Mac with --secondary-ui-md.
bsep@, mind if I take a look into plumbing the views dialog on Mac? Draft CL at https://codereview.chromium.org/2808823002.
Go ahead, I haven't done anything with this dialog yet.
Issue 669387 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58cb30d4f4a8cd26893f614658f752c9cefb30dd commit 58cb30d4f4a8cd26893f614658f752c9cefb30dd Author: varkha <varkha@chromium.org> Date: Fri Apr 21 07:37:59 2017 MacViews: Allows the toolkit-views Manage Passwords Dialog to be used Both chrome/browser/ui/views/passwords/credentials_selection_view.* and chrome/browser/ui/cocoa/passwords/credentials_selection_view.* are now included in the same build target so the cocoa version is renamed. This CL also enables fake full keyboard access by default on MacOS for the tests based on InProcessBrowserTest, so that tests don't depend on system setting of the test machine. This makes those tests more like on other platforms, similar to how it is done in views_unittests. BUG= 654115 TEST=interactive_ui_test --gtest_filter=ManagePasswordsBubbleViewTest* browser_tests --gtest_filter=ManagePasswordsBubbleDialogViewTest* Review-Url: https://codereview.chromium.org/2808823002 Cr-Commit-Position: refs/heads/master@{#466285} [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/BUILD.gn [rename] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.h [rename] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.mm [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller_unittest.mm [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/tab_dialogs_views_mac.h [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/test/BUILD.gn [modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/test/base/in_process_browser_test.h
Taking this back. I'm starting to convert the password dialogs.
I'm going to combine all the password bugs into this one because the others haven't had any activity and they're all closely related.
Issue 654120 has been merged into this issue.
Issue 654119 has been merged into this issue.
Issue 654118 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/257ee88f3a0e1b02da7814cbc37f693494bad6d3 commit 257ee88f3a0e1b02da7814cbc37f693494bad6d3 Author: bsep <bsep@chromium.org> Date: Wed Jun 28 01:19:58 2017 Allow dialogs to use a custom View as their title. Added a method to DialogDelegate that lets a dialog subclass specify a View that will be used as the dialog's title. As an example, changed the Save Password dialog and removed its ad-hoc title. Also removed SetTitleFontList, as it's not clear how it should interact with a generic View title, and updated the subclasses that were using it. BUG= 654115 ,702196 Review-Url: https://codereview.chromium.org/2907983002 Cr-Commit-Position: refs/heads/master@{#482840} [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/page_info/page_info_bubble_view.cc [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/page_info/page_info_bubble_view.h [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_dialog_delegate.cc [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_dialog_delegate.h [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_dialog_delegate_unittest.cc [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_frame_view.cc [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_frame_view.h [modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/window/dialog_delegate_unittest.cc
Delegating
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbbcc8a6ab97d822d91c07e4b9df2dfaa4bfdfb7 commit dbbcc8a6ab97d822d91c07e4b9df2dfaa4bfdfb7 Author: Peter Boström <pbos@chromium.org> Date: Mon Oct 02 20:48:30 2017 Add trash icon to Harmony password dialog. BUG= chromium:654115 R=bsep@chromium.org Change-Id: Iead94366cb68df77f396d92d1f54bc83677551be Reviewed-on: https://chromium-review.googlesource.com/691178 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#505776} [modify] https://crrev.com/dbbcc8a6ab97d822d91c07e4b9df2dfaa4bfdfb7/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/dbbcc8a6ab97d822d91c07e4b9df2dfaa4bfdfb7/chrome/app/vector_icons/trash_can.icon [modify] https://crrev.com/dbbcc8a6ab97d822d91c07e4b9df2dfaa4bfdfb7/chrome/browser/ui/views/passwords/manage_password_items_view.cc [modify] https://crrev.com/dbbcc8a6ab97d822d91c07e4b9df2dfaa4bfdfb7/chrome/browser/ui/views/passwords/manage_password_items_view.h [modify] https://crrev.com/dbbcc8a6ab97d822d91c07e4b9df2dfaa4bfdfb7/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2999c671325f380b10d90daddc7cbb5547fe12dd commit 2999c671325f380b10d90daddc7cbb5547fe12dd Author: Peter Boström <pbos@chromium.org> Date: Tue Oct 03 00:43:29 2017 Unify password-replacement character. Changes the RenderText default password character to be a bullet on all platforms instead of just Mac, as part of Harmony unification of UI. This changes the ash LoginPasswordView from using the U+2219 bullet operator glyph to the RenderText default bullet glyph. Removes SetPasswordReplacementChar as it is no longer meaningfully used. BUG= chromium:654115 , chromium:770402 Change-Id: Ia323917a7dcf3a4b303d74d3488b3da7bf2d65ca Reviewed-on: https://chromium-review.googlesource.com/693279 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#505890} [modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ash/login/ui/login_password_view.cc [modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/gfx/render_text.cc [modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/gfx/render_text.h [modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/gfx/render_text_unittest.cc [modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/views/controls/textfield/textfield.h [modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/views/controls/textfield/textfield_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ae56a33fdfbec7d7c67a361c9e300a1b5876b7b commit 8ae56a33fdfbec7d7c67a361c9e300a1b5876b7b Author: Peter Boström <pbos@chromium.org> Date: Thu Oct 05 01:18:52 2017 Add context/styles to password dialog items. Removes SetFontList on the undo link as it defaults to the correct style (not CONTEXT_SMALL_DEPRECATED). BUG= chromium:654115 R=bsep@chromium.org Change-Id: Ib49cbd57ced4514a2778ebf0d453cb116ef5f722 Reviewed-on: https://chromium-review.googlesource.com/701263 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#506604} [modify] https://crrev.com/8ae56a33fdfbec7d7c67a361c9e300a1b5876b7b/chrome/browser/ui/views/passwords/manage_password_items_view.cc
The NextAction date has arrived: 2017-11-10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebe803acafc7cc3bd273c529edbba8f45b37b445 commit ebe803acafc7cc3bd273c529edbba8f45b37b445 Author: Peter Boström <pbos@chromium.org> Date: Wed Dec 13 00:48:04 2017 Separate the manage-passwords dialog. Splits up some globals and makes this a stand-alone dialog instead of a child view to a catch-all password dialog. Uses a 6:4 ratio for username/password rows. These ratios are always fixed and will not vary based on content. This keeps the look consistent as the contents inside the dialog changes. Also fixes regression where additional padding is observed on the right-hand side of the manage-passwords dialog. TBR=vasilii@chromium.org Bug: chromium:654115 , chromium:784754 Change-Id: Ic3bc8cee08be90e0f4973fb6752eae355ecd0bb1 Reviewed-on: https://chromium-review.googlesource.com/724126 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#523626} [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/app/generated_resources.grd [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.mm [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_bubble_model.h [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_test.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_test.h [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_view_utils.h [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/extensions/pwa_confirmation_view.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/harmony/chrome_layout_provider.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/harmony/chrome_layout_provider.h [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/harmony/harmony_layout_provider.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/importer/import_lock_dialog_view.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_password_items_view.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_password_items_view.h [add] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.cc [add] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.h [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc [modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/tab_dialogs_views.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e94312307129b5d1cdeeb0c45374ca651e98b80 commit 0e94312307129b5d1cdeeb0c45374ca651e98b80 Author: Peter Boström <pbos@chromium.org> Date: Mon Jan 08 20:36:41 2018 Fix federation label in ManagePasswordItemsView. Inadvertedly got changed to "Sign in with <URL>" with other dialogs. Bug: chromium:654115 , chromium:776653 Change-Id: Ia661f5b491ef0439ca5fc63c2c657f188407ce8c Reviewed-on: https://chromium-review.googlesource.com/764432 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#527742} [modify] https://crrev.com/0e94312307129b5d1cdeeb0c45374ca651e98b80/chrome/browser/ui/views/passwords/manage_password_items_view.cc [modify] https://crrev.com/0e94312307129b5d1cdeeb0c45374ca651e98b80/chrome/browser/ui/views/passwords/manage_password_items_view.h [modify] https://crrev.com/0e94312307129b5d1cdeeb0c45374ca651e98b80/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19b7dd3120bbeeef415947062ef7d3e95461d1db commit 19b7dd3120bbeeef415947062ef7d3e95461d1db Author: Peter Boström <pbos@chromium.org> Date: Fri Jan 12 17:16:05 2018 Split manage-password dialogs into multiple files. Moving the dialogs out into separate files is a first step to untangling them completely into separate dialogs (like the ManagePasswordItemView currently is). There are currently some friend class dependencies in place that allow the subdialogs to access their dialog parent. This should go away as the dialogs are being untangled. Apart from less-entangled code separating the dialogs will allow for using "proper" dialog OK/Cancel buttons instead of a custom button row. This means that these buttons can be ordered matching per-OS preferences. Bug: chromium:654115 Change-Id: I01605b1b8ba537835a39fa024af447ef5e827723 Reviewed-on: https://chromium-review.googlesource.com/862692 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#528981} [modify] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/BUILD.gn [add] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_password_auto_sign_in_view.cc [add] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_password_auto_sign_in_view.h [add] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_password_pending_view.cc [add] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_password_pending_view.h [add] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_password_save_confirmation_view.cc [add] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_password_save_confirmation_view.h [add] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_password_sign_in_promo_view.cc [add] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_password_sign_in_promo_view.h [add] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_password_update_pending_view.cc [add] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_password_update_pending_view.h [modify] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h [modify] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc [modify] https://crrev.com/19b7dd3120bbeeef415947062ef7d3e95461d1db/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67b29c67600a17f2c9fcb1f5437c1f376fa5fa8d commit 67b29c67600a17f2c9fcb1f5437c1f376fa5fa8d Author: Peter Boström <pbos@chromium.org> Date: Wed Jan 17 01:26:22 2018 Make the auto-signin view a standalone dialog. Breaks out ManagePasswordAutoSignInView from ManagePasswordsBubbleView. Bug: chromium:654115 Change-Id: Ic99757b1365eb77d754b8dfb3b079c5efad23783 Reviewed-on: https://chromium-review.googlesource.com/865461 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#529537} [modify] https://crrev.com/67b29c67600a17f2c9fcb1f5437c1f376fa5fa8d/chrome/browser/ui/views/passwords/manage_password_auto_sign_in_view.cc [modify] https://crrev.com/67b29c67600a17f2c9fcb1f5437c1f376fa5fa8d/chrome/browser/ui/views/passwords/manage_password_auto_sign_in_view.h [modify] https://crrev.com/67b29c67600a17f2c9fcb1f5437c1f376fa5fa8d/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.cc [modify] https://crrev.com/67b29c67600a17f2c9fcb1f5437c1f376fa5fa8d/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/67b29c67600a17f2c9fcb1f5437c1f376fa5fa8d/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3770a97413715408a2ff18a7962f3c34b7d06588 commit 3770a97413715408a2ff18a7962f3c34b7d06588 Author: Peter Boström <pbos@chromium.org> Date: Wed Jan 17 18:42:01 2018 Move password promo dialogs into PendingView. Makes promotions child views of the promo dialog instead of direct children of ManagePasswordsBubbleView. This disentangles the three dialogs from ManagePasswordsBubbleView and is a prerequisite for turning the PendingView into a proper dialog (containing the promo subdialogs). Bug: chromium:654115 Change-Id: I621deb6bb28041537aa3b7bfeea7da4dde032997 Reviewed-on: https://chromium-review.googlesource.com/869371 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#529824} [modify] https://crrev.com/3770a97413715408a2ff18a7962f3c34b7d06588/chrome/browser/ui/views/passwords/manage_password_pending_view.cc [modify] https://crrev.com/3770a97413715408a2ff18a7962f3c34b7d06588/chrome/browser/ui/views/passwords/manage_password_pending_view.h [modify] https://crrev.com/3770a97413715408a2ff18a7962f3c34b7d06588/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/3770a97413715408a2ff18a7962f3c34b7d06588/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e2403b253ea4e1a10e3a2f1eb3c5ba3d0ac5b44 commit 0e2403b253ea4e1a10e3a2f1eb3c5ba3d0ac5b44 Author: Peter Boström <pbos@chromium.org> Date: Thu Jan 18 17:43:11 2018 Harmonize password save-confirmation view. Makes ManagePasswordSaveConfirmationView a stand-alone dialog and applies the following changes for Harmony: * Adds optional title casing for dialog title and button. * Removes OK button in favor of showing a standard close button. Bug: chromium:654115 Change-Id: Ie09df62dd03cb4687d2d33df1957fd2426557eb9 Reviewed-on: https://chromium-review.googlesource.com/865536 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#530187} [modify] https://crrev.com/0e2403b253ea4e1a10e3a2f1eb3c5ba3d0ac5b44/chrome/app/generated_resources.grd [modify] https://crrev.com/0e2403b253ea4e1a10e3a2f1eb3c5ba3d0ac5b44/chrome/browser/ui/views/passwords/manage_password_save_confirmation_view.cc [modify] https://crrev.com/0e2403b253ea4e1a10e3a2f1eb3c5ba3d0ac5b44/chrome/browser/ui/views/passwords/manage_password_save_confirmation_view.h [modify] https://crrev.com/0e2403b253ea4e1a10e3a2f1eb3c5ba3d0ac5b44/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.cc [modify] https://crrev.com/0e2403b253ea4e1a10e3a2f1eb3c5ba3d0ac5b44/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/0e2403b253ea4e1a10e3a2f1eb3c5ba3d0ac5b44/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b91bf4e21427fc045839ffb2eec2b5abf7ac9896 commit b91bf4e21427fc045839ffb2eec2b5abf7ac9896 Author: Peter Boström <pbos@chromium.org> Date: Mon Jan 22 18:56:10 2018 Break out the update-pending-password dialog. Untangles the dialog from ManagePasswordsBubbleView and makes it a proper standalone dialog using DialogClientView infrastructure for buttons. This addresses OK/Cancel button ordering per OS. The dialog is not styled for Harmony apart from button ordering. Bug: chromium:654115 Change-Id: I0e697a86130645424826e1b6590280eb3f02df84 Reviewed-on: https://chromium-review.googlesource.com/876762 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#530928} [modify] https://crrev.com/b91bf4e21427fc045839ffb2eec2b5abf7ac9896/chrome/browser/ui/views/passwords/manage_password_update_pending_view.cc [modify] https://crrev.com/b91bf4e21427fc045839ffb2eec2b5abf7ac9896/chrome/browser/ui/views/passwords/manage_password_update_pending_view.h [modify] https://crrev.com/b91bf4e21427fc045839ffb2eec2b5abf7ac9896/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.cc [modify] https://crrev.com/b91bf4e21427fc045839ffb2eec2b5abf7ac9896/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdd220e8b290495f6ae89d83ad66581e100ef1e7 commit cdd220e8b290495f6ae89d83ad66581e100ef1e7 Author: Peter Boström <pbos@chromium.org> Date: Tue Jan 23 16:48:08 2018 Break out the password PendingView dialog. Makes ManagePasswordPendingView a stand-alone dialog and reimplements buttons using the DialogClientView infrastructure, which enables correct OK/Cancel button ordering per OS. This is done both for the main dialog and the promo dialogs it contains (including the iOS promotion dialog as triggered by the bookmarks view). The dialogs have not yet been styled for Harmony apart from fixing button ordering. Bug: chromium:654115 Change-Id: I8c775de0b317125297d8b2caf415052778c2e0e3 Reviewed-on: https://chromium-review.googlesource.com/872096 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#531259} [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.h [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/passwords/manage_password_pending_view.cc [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/passwords/manage_password_pending_view.h [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/passwords/manage_password_sign_in_promo_view.cc [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/passwords/manage_password_sign_in_promo_view.h [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.cc [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h [modify] https://crrev.com/cdd220e8b290495f6ae89d83ad66581e100ef1e7/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54acf91c05d272b62c888ee732cda85ccbf20b95 commit 54acf91c05d272b62c888ee732cda85ccbf20b95 Author: Peter Boström <pbos@chromium.org> Date: Wed Jan 24 06:12:49 2018 Reset inkdrop effect when host gets removed. Fixes bug where the inkdrop hover effect remains active after a dialog OK button is reset + moved (no mouse exit event is triggered). Found when refactoring password promo dialogs to replace existing dialog content. Bug: chromium:654115 Change-Id: If9dd3619292706fd332ff905e6e89bbe2266d9c2 Reviewed-on: https://chromium-review.googlesource.com/875310 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#531458} [modify] https://crrev.com/54acf91c05d272b62c888ee732cda85ccbf20b95/ui/views/animation/ink_drop_host_view.cc [modify] https://crrev.com/54acf91c05d272b62c888ee732cda85ccbf20b95/ui/views/animation/ink_drop_host_view.h [modify] https://crrev.com/54acf91c05d272b62c888ee732cda85ccbf20b95/ui/views/controls/button/button.cc [modify] https://crrev.com/54acf91c05d272b62c888ee732cda85ccbf20b95/ui/views/controls/button/button_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7 commit ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7 Author: Peter Boström <pbos@chromium.org> Date: Wed Jan 24 21:04:25 2018 Remove ManagePasswordsBubbleView. The remaining static code in use moves to PendingView. References are updated to use ManagePasswordsBubbleDelegateViewBase directly. Also removes SINGLE_VIEW_COLUMN_SET in favor of using a FillLayout and cleans up unreferenced ColumnSet enums. Bug: chromium:654115 Change-Id: I54d6ed26132388bd33c3e93e504ce153146f43ec Reviewed-on: https://chromium-review.googlesource.com/882161 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#531682} [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/passwords/manage_password_pending_view.cc [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/passwords/manage_password_pending_view.h [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/passwords/manage_password_save_confirmation_view.cc [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/passwords/manage_password_sign_in_promo_view.cc [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/passwords/manage_password_update_pending_view.cc [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.cc [delete] https://crrev.com/c074d0bd1e3223703f3239c5a2dab8b0ecdce9a2/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [delete] https://crrev.com/c074d0bd1e3223703f3239c5a2dab8b0ecdce9a2/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc [rename] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/passwords/password_bubble_browsertest.cc [rename] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/passwords/password_bubble_interactive_uitest.cc [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/browser/ui/views/tab_dialogs_views.cc [modify] https://crrev.com/ee78a8ecf1e32ba7dcce082a115fd1e55ffad1d7/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530 commit 33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530 Author: Peter Boström <pbos@chromium.org> Date: Thu Jan 25 17:00:57 2018 Drop Manage prefix from password views. This is a cleanup remaining from previous refactoring that renames several dialogs to a shorter/more concise name. TBR=tapted@chromium.org Bug: chromium:654115 Change-Id: Ib404d65fc8b19d42cbcd9f5731a300759badd6e1 Reviewed-on: https://chromium-review.googlesource.com/885001 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#531920} [modify] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm [delete] https://crrev.com/a3ac997c4362fb4073e3f5b603bed76cf34fb20a/chrome/browser/ui/views/passwords/manage_password_auto_sign_in_view.h [delete] https://crrev.com/a3ac997c4362fb4073e3f5b603bed76cf34fb20a/chrome/browser/ui/views/passwords/manage_password_save_confirmation_view.h [delete] https://crrev.com/a3ac997c4362fb4073e3f5b603bed76cf34fb20a/chrome/browser/ui/views/passwords/manage_password_sign_in_promo_view.h [delete] https://crrev.com/a3ac997c4362fb4073e3f5b603bed76cf34fb20a/chrome/browser/ui/views/passwords/manage_password_update_pending_view.h [modify] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc [rename] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_auto_sign_in_view.cc [add] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_auto_sign_in_view.h [modify] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_bubble_browsertest.cc [modify] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_bubble_interactive_uitest.cc [rename] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_bubble_view_base.cc [rename] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_bubble_view_base.h [rename] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_items_view.cc [rename] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_items_view.h [rename] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_pending_view.cc [rename] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_pending_view.h [rename] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_save_confirmation_view.cc [add] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_save_confirmation_view.h [rename] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_sign_in_promo_view.cc [add] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_sign_in_promo_view.h [rename] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_update_pending_view.cc [add] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/passwords/password_update_pending_view.h [modify] https://crrev.com/33d0f6fa4bed0bfb9b2e6147ad7e7595b5c72530/chrome/browser/ui/views/tab_dialogs_views.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43e41f18912dc2cf5445b51b451490ef9d495d62 commit 43e41f18912dc2cf5445b51b451490ef9d495d62 Author: Peter Boström <pbos@chromium.org> Date: Sun Jan 28 20:24:26 2018 Update style of empty manage-passwords dialog. Replaces the dialog showing "Saved passwords for this site:" as title alongside "No passwords saved." in the body. Instead this now shows only "No passwords saved for this site" as title. Bug: chromium:654115 Change-Id: Id8c340991fd22a5406112788ddf24e04b79487b5 Reviewed-on: https://chromium-review.googlesource.com/847908 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532287} [modify] https://crrev.com/43e41f18912dc2cf5445b51b451490ef9d495d62/chrome/app/generated_resources.grd [modify] https://crrev.com/43e41f18912dc2cf5445b51b451490ef9d495d62/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.mm [modify] https://crrev.com/43e41f18912dc2cf5445b51b451490ef9d495d62/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/43e41f18912dc2cf5445b51b451490ef9d495d62/chrome/browser/ui/passwords/manage_passwords_view_utils.cc [modify] https://crrev.com/43e41f18912dc2cf5445b51b451490ef9d495d62/chrome/browser/ui/passwords/manage_passwords_view_utils.h [modify] https://crrev.com/43e41f18912dc2cf5445b51b451490ef9d495d62/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc [modify] https://crrev.com/43e41f18912dc2cf5445b51b451490ef9d495d62/chrome/browser/ui/views/passwords/password_items_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a793e4b47c8ce97469529892052f3a2af3e0afb1 commit a793e4b47c8ce97469529892052f3a2af3e0afb1 Author: Peter Boström <pbos@chromium.org> Date: Mon Jan 29 18:26:27 2018 Harmonize password sign-in promo. * Separates the title from the promotion content (adds a secondary-style Label for body content). * Removes the "no thanks" button (still present in the Cocoa version). Bug: chromium:654115 , chromium:654117 Change-Id: I83274934bfff8eaec6e5065233661ddd91447d39 Reviewed-on: https://chromium-review.googlesource.com/887726 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#532500} [modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/app/generated_resources.grd [modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/browser/ui/views/passwords/password_pending_view.cc [modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/browser/ui/views/passwords/password_pending_view.h [modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/browser/ui/views/passwords/password_sign_in_promo_view.cc [modify] https://crrev.com/a793e4b47c8ce97469529892052f3a2af3e0afb1/chrome/browser/ui/views/passwords/password_sign_in_promo_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8540c482b598d8d9536b3cdbffaa459440352129 commit 8540c482b598d8d9536b3cdbffaa459440352129 Author: Peter Boström <pbos@chromium.org> Date: Wed Jan 31 21:39:55 2018 Add titlecase entries for password bubbles. Adresses adding title casing to all password bubbles except the sign-in promo which is being handled in a separate CL. String content is not updated except for title casing them according to AP style and removing trailing colon characters. IDS_ entries are kept the same to keep the change easier. Bug: chromium:654115 Change-Id: I0022f5d9e5e54c2cac3def66ee75901baa30013a Reviewed-on: https://chromium-review.googlesource.com/890039 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#533422} [modify] https://crrev.com/8540c482b598d8d9536b3cdbffaa459440352129/chrome/app/generated_resources.grd [modify] https://crrev.com/8540c482b598d8d9536b3cdbffaa459440352129/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/317ba6b03b73b9fe7ec0fe8b78273626d08a5b02 commit 317ba6b03b73b9fe7ec0fe8b78273626d08a5b02 Author: Peter Boström <pbos@chromium.org> Date: Thu Feb 01 15:33:43 2018 Add titlecase for password-manager buttons. Bug: chromium:654115 Change-Id: I9aa312a5eeb1041bb5a1c725e22db774d91900c8 Reviewed-on: https://chromium-review.googlesource.com/896325 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#533672} [modify] https://crrev.com/317ba6b03b73b9fe7ec0fe8b78273626d08a5b02/chrome/app/generated_resources.grd [modify] https://crrev.com/317ba6b03b73b9fe7ec0fe8b78273626d08a5b02/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/317ba6b03b73b9fe7ec0fe8b78273626d08a5b02/chrome/browser/ui/views/passwords/password_items_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f83a6e0f3ac1f2f6e6ff957fe9814deb837c1cee commit f83a6e0f3ac1f2f6e6ff957fe9814deb837c1cee Author: Peter Boström <pbos@chromium.org> Date: Fri Feb 02 00:15:12 2018 Left-align credential labels in password dialogs. This left-aligns Username / Password labels for Harmony and also matches mocks for future dialog updates. Bug: chromium:654115 Change-Id: I42efa789a09d6f6845535e94bb65fa789bdc19fa Reviewed-on: https://chromium-review.googlesource.com/898074 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#533865} [modify] https://crrev.com/f83a6e0f3ac1f2f6e6ff957fe9814deb837c1cee/chrome/browser/ui/views/passwords/password_pending_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/125696608d7b1d200f54694c2470666b3d52052e commit 125696608d7b1d200f54694c2470666b3d52052e Author: Peter Boström <pbos@chromium.org> Date: Fri Feb 02 02:15:14 2018 Highlight location-bar password icon. Highlights the location-bar passwords icon even when the dialog is triggered without user interaction (for instance when prompting the user to save credentials). This is done similarly to highlighting the StarView when the bookmark bubble shows. Bug: chromium:654115 Change-Id: Ia8f3a7020336186c83a1aa8ec997c9abd73b8f6a Reviewed-on: https://chromium-review.googlesource.com/898588 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#533919} [modify] https://crrev.com/125696608d7b1d200f54694c2470666b3d52052e/chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc [modify] https://crrev.com/125696608d7b1d200f54694c2470666b3d52052e/chrome/browser/ui/views/passwords/manage_passwords_icon_views.h [modify] https://crrev.com/125696608d7b1d200f54694c2470666b3d52052e/chrome/browser/ui/views/passwords/password_bubble_view_base.cc
bettes@ I think these are in a pretty good state now. bsep@ has taken a look too, screenshots are in the deck.
LGTM. Implementation deck for posterity: https://docs.google.com/presentation/d/1efIBdWozcOXv1hEaIxdcdf4A1-8P8HQu7bRpEokLisI/edit?ts=5a726b6e#slide=id.g328698fce9_0_184
Sweet, marking as fixed. :)
/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview#%2FP%20-%20passwords_01.png%3Fz=width){kind=link}
/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview/06-Passwords#%2F01-Passwords_save.png%3Fz=width){kind=link}
Comment 1 by shrike@chromium.org
, Oct 11 2016