New issue
Advanced search Search tips
Starred by 4 users
Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug
Launch-M-Target: 64-Beta

Blocking:
issue 630357


Participants' hotlists:
HarmonyFutureP1s


Sign in to add a comment
Harmony - update password dialogs
Project Member Reported by shrike@chromium.org, Oct 7 2016 Back to list
Comment 1 by shrike@chromium.org, Oct 11 2016
Owner: bsep@chromium.org
Comment 3 by tapted@chromium.org, Apr 10 2017
Description: Show this description
Comment 4 by tapted@chromium.org, Apr 10 2017
Cc: tapted@chromium.org
Attaching how it currently looks on mac (the Cocoa dialog). There's some plumbing to do so that the toolkit-views dialog shows instead up on Mac with --secondary-ui-md.
Screen Shot 2017-04-10 at 10.28.41 am.png
19.0 KB View Download
Comment 5 by varkha@chromium.org, Apr 12 2017
Cc: bsep@chromium.org
Owner: varkha@chromium.org
Status: Started
bsep@, mind if I take a look into plumbing the views dialog on Mac?
Draft CL at https://codereview.chromium.org/2808823002.
Comment 6 by bsep@chromium.org, Apr 12 2017
Go ahead, I haven't done anything with this dialog yet.
Comment 7 by tapted@chromium.org, Apr 13 2017
Cc: ellyjo...@chromium.org
 Issue 669387  has been merged into this issue.
Project Member Comment 8 by bugdroid1@chromium.org, Apr 21 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58cb30d4f4a8cd26893f614658f752c9cefb30dd

commit 58cb30d4f4a8cd26893f614658f752c9cefb30dd
Author: varkha <varkha@chromium.org>
Date: Fri Apr 21 07:37:59 2017

MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

Both chrome/browser/ui/views/passwords/credentials_selection_view.* and
chrome/browser/ui/cocoa/passwords/credentials_selection_view.* are now
included in the same build target so the cocoa version is renamed.

This CL also enables fake full keyboard access by default on MacOS for the
tests based on InProcessBrowserTest, so that tests don't depend on system
setting of the test machine. This makes those tests more like on other
platforms, similar to how it is done in views_unittests.

BUG= 654115
TEST=interactive_ui_test --gtest_filter=ManagePasswordsBubbleViewTest*
     browser_tests --gtest_filter=ManagePasswordsBubbleDialogViewTest*

Review-Url: https://codereview.chromium.org/2808823002
Cr-Commit-Position: refs/heads/master@{#466285}

[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/BUILD.gn
[rename] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.h
[rename] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller_unittest.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/tab_dialogs_views_mac.h
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/test/BUILD.gn
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/test/base/in_process_browser_test.h

Comment 9 by bsep@chromium.org, May 26 2017
Cc: varkha@chromium.org
Owner: bsep@chromium.org
Taking this back. I'm starting to convert the password dialogs.
Comment 10 by bsep@chromium.org, May 26 2017
Summary: Harmony - update password dialogs (was: Harmony - update password save dialog)
I'm going to combine all the password bugs into this one because the others haven't had any activity and they're all closely related.
Comment 11 by bsep@chromium.org, May 26 2017
 Issue 654120  has been merged into this issue.
Comment 12 by bsep@chromium.org, May 26 2017
 Issue 654119  has been merged into this issue.
Comment 13 by bsep@chromium.org, May 26 2017
 Issue 654118  has been merged into this issue.
Project Member Comment 14 by bugdroid1@chromium.org, Jun 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/257ee88f3a0e1b02da7814cbc37f693494bad6d3

commit 257ee88f3a0e1b02da7814cbc37f693494bad6d3
Author: bsep <bsep@chromium.org>
Date: Wed Jun 28 01:19:58 2017

Allow dialogs to use a custom View as their title.

Added a method to DialogDelegate that lets a dialog subclass specify a
View that will be used as the dialog's title. As an example, changed the
Save Password dialog and removed its ad-hoc title. Also removed
SetTitleFontList, as it's not clear how it should interact with a generic
View title, and updated the subclasses that were using it.

BUG=654115,702196

Review-Url: https://codereview.chromium.org/2907983002
Cr-Commit-Position: refs/heads/master@{#482840}

[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/page_info/page_info_bubble_view.h
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_dialog_delegate.h
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_dialog_delegate_unittest.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_frame_view.h
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/window/dialog_delegate_unittest.cc

Labels: -M-56
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10
Owner: pbos@chromium.org
Status: Assigned
Delegating
Project Member Comment 20 by bugdroid1@chromium.org, Oct 3
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2999c671325f380b10d90daddc7cbb5547fe12dd

commit 2999c671325f380b10d90daddc7cbb5547fe12dd
Author: Peter Boström <pbos@chromium.org>
Date: Tue Oct 03 00:43:29 2017

Unify password-replacement character.

Changes the RenderText default password character to be a bullet on all
platforms instead of just Mac, as part of Harmony unification of UI.

This changes the ash LoginPasswordView from using the U+2219 bullet
operator glyph to the RenderText default bullet glyph.

Removes SetPasswordReplacementChar as it is no longer meaningfully used.

BUG=chromium:654115, chromium:770402

Change-Id: Ia323917a7dcf3a4b303d74d3488b3da7bf2d65ca
Reviewed-on: https://chromium-review.googlesource.com/693279
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505890}
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/gfx/render_text.cc
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/gfx/render_text.h
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/views/controls/textfield/textfield.h
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/views/controls/textfield/textfield_unittest.cc

Project Member Comment 21 by bugdroid1@chromium.org, Oct 5
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ae56a33fdfbec7d7c67a361c9e300a1b5876b7b

commit 8ae56a33fdfbec7d7c67a361c9e300a1b5876b7b
Author: Peter Boström <pbos@chromium.org>
Date: Thu Oct 05 01:18:52 2017

Add context/styles to password dialog items.

Removes SetFontList on the undo link as it defaults to the correct
style (not CONTEXT_SMALL_DEPRECATED).

BUG=chromium:654115
R=bsep@chromium.org

Change-Id: Ib49cbd57ced4514a2778ebf0d453cb116ef5f722
Reviewed-on: https://chromium-review.googlesource.com/701263
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506604}
[modify] https://crrev.com/8ae56a33fdfbec7d7c67a361c9e300a1b5876b7b/chrome/browser/ui/views/passwords/manage_password_items_view.cc

Labels: -Pri-2 Pri-1
Status: Started
The NextAction date has arrived: 2017-11-10
Project Member Comment 24 by bugdroid1@chromium.org, Yesterday (33 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebe803acafc7cc3bd273c529edbba8f45b37b445

commit ebe803acafc7cc3bd273c529edbba8f45b37b445
Author: Peter Boström <pbos@chromium.org>
Date: Wed Dec 13 00:48:04 2017

Separate the manage-passwords dialog.

Splits up some globals and makes this a stand-alone dialog instead of a
child view to a catch-all password dialog. Uses a 6:4 ratio for
username/password rows. These ratios are always fixed and will not vary
based on content. This keeps the look consistent as the contents inside
the dialog changes.

Also fixes regression where additional padding is observed on the
right-hand side of the manage-passwords dialog.

TBR=vasilii@chromium.org

Bug: chromium:654115,  chromium:784754 
Change-Id: Ic3bc8cee08be90e0f4973fb6752eae355ecd0bb1
Reviewed-on: https://chromium-review.googlesource.com/724126
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523626}
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/app/generated_resources.grd
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.mm
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_test.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_test.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_view_utils.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/extensions/pwa_confirmation_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/harmony/chrome_layout_provider.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/harmony/chrome_layout_provider.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/importer/import_lock_dialog_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_password_items_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_password_items_view.h
[add] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.cc
[add] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/tab_dialogs_views.cc

Sign in to add a comment