Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 4 users
Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux, Windows, Chrome, Mac
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment
Harmony - update password dialogs
Project Member Reported by shrike@chromium.org, Oct 7 2016 Back to list
Comment 1 by shrike@chromium.org, Oct 11 2016
Owner: bsep@chromium.org
Description: Show this description
Cc: tapted@chromium.org
Attaching how it currently looks on mac (the Cocoa dialog). There's some plumbing to do so that the toolkit-views dialog shows instead up on Mac with --secondary-ui-md.
Screen Shot 2017-04-10 at 10.28.41 am.png
19.0 KB View Download
Cc: bsep@chromium.org
Owner: varkha@chromium.org
Status: Started
bsep@, mind if I take a look into plumbing the views dialog on Mac?
Draft CL at https://codereview.chromium.org/2808823002.
Go ahead, I haven't done anything with this dialog yet.
Cc: ellyjo...@chromium.org
 Issue 669387  has been merged into this issue.
Project Member Comment 8 by bugdroid1@chromium.org, Apr 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58cb30d4f4a8cd26893f614658f752c9cefb30dd

commit 58cb30d4f4a8cd26893f614658f752c9cefb30dd
Author: varkha <varkha@chromium.org>
Date: Fri Apr 21 07:37:59 2017

MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

Both chrome/browser/ui/views/passwords/credentials_selection_view.* and
chrome/browser/ui/cocoa/passwords/credentials_selection_view.* are now
included in the same build target so the cocoa version is renamed.

This CL also enables fake full keyboard access by default on MacOS for the
tests based on InProcessBrowserTest, so that tests don't depend on system
setting of the test machine. This makes those tests more like on other
platforms, similar to how it is done in views_unittests.

BUG= 654115
TEST=interactive_ui_test --gtest_filter=ManagePasswordsBubbleViewTest*
     browser_tests --gtest_filter=ManagePasswordsBubbleDialogViewTest*

Review-Url: https://codereview.chromium.org/2808823002
Cr-Commit-Position: refs/heads/master@{#466285}

[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/BUILD.gn
[rename] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.h
[rename] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller_unittest.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/tab_dialogs_views_mac.h
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/test/BUILD.gn
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/test/base/in_process_browser_test.h

Cc: varkha@chromium.org
Owner: bsep@chromium.org
Taking this back. I'm starting to convert the password dialogs.
Summary: Harmony - update password dialogs (was: Harmony - update password save dialog)
I'm going to combine all the password bugs into this one because the others haven't had any activity and they're all closely related.
 Issue 654120  has been merged into this issue.
 Issue 654119  has been merged into this issue.
 Issue 654118  has been merged into this issue.
Project Member Comment 14 by bugdroid1@chromium.org, Jun 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/257ee88f3a0e1b02da7814cbc37f693494bad6d3

commit 257ee88f3a0e1b02da7814cbc37f693494bad6d3
Author: bsep <bsep@chromium.org>
Date: Wed Jun 28 01:19:58 2017

Allow dialogs to use a custom View as their title.

Added a method to DialogDelegate that lets a dialog subclass specify a
View that will be used as the dialog's title. As an example, changed the
Save Password dialog and removed its ad-hoc title. Also removed
SetTitleFontList, as it's not clear how it should interact with a generic
View title, and updated the subclasses that were using it.

BUG=654115,702196

Review-Url: https://codereview.chromium.org/2907983002
Cr-Commit-Position: refs/heads/master@{#482840}

[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/page_info/page_info_bubble_view.h
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_dialog_delegate.h
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_dialog_delegate_unittest.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/bubble/bubble_frame_view.h
[modify] https://crrev.com/257ee88f3a0e1b02da7814cbc37f693494bad6d3/ui/views/window/dialog_delegate_unittest.cc

Labels: -M-56
Sign in to add a comment