Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 654115 Harmony - update password save dialog
Starred by 4 users Project Member Reported by shrike@chromium.org, Oct 7 Back to list
Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux, Windows, Chrome, Mac
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment
Owner: bsep@chromium.org
Description: Show this description
Cc: tapted@chromium.org
Attaching how it currently looks on mac (the Cocoa dialog). There's some plumbing to do so that the toolkit-views dialog shows instead up on Mac with --secondary-ui-md.
Screen Shot 2017-04-10 at 10.28.41 am.png
19.0 KB View Download
Cc: bsep@chromium.org
Owner: varkha@chromium.org
Status: Started
bsep@, mind if I take a look into plumbing the views dialog on Mac?
Draft CL at https://codereview.chromium.org/2808823002.
Go ahead, I haven't done anything with this dialog yet.
Cc: ellyjo...@chromium.org
Issue 669387 has been merged into this issue.
Project Member Comment 8 by bugdroid1@chromium.org, Apr 21 (6 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58cb30d4f4a8cd26893f614658f752c9cefb30dd

commit 58cb30d4f4a8cd26893f614658f752c9cefb30dd
Author: varkha <varkha@chromium.org>
Date: Fri Apr 21 07:37:59 2017

MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

Both chrome/browser/ui/views/passwords/credentials_selection_view.* and
chrome/browser/ui/cocoa/passwords/credentials_selection_view.* are now
included in the same build target so the cocoa version is renamed.

This CL also enables fake full keyboard access by default on MacOS for the
tests based on InProcessBrowserTest, so that tests don't depend on system
setting of the test machine. This makes those tests more like on other
platforms, similar to how it is done in views_unittests.

BUG= 654115
TEST=interactive_ui_test --gtest_filter=ManagePasswordsBubbleViewTest*
     browser_tests --gtest_filter=ManagePasswordsBubbleDialogViewTest*

Review-Url: https://codereview.chromium.org/2808823002
Cr-Commit-Position: refs/heads/master@{#466285}

[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/BUILD.gn
[rename] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.h
[rename] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller_unittest.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/tab_dialogs_views_mac.h
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/test/BUILD.gn
[modify] https://crrev.com/58cb30d4f4a8cd26893f614658f752c9cefb30dd/chrome/test/base/in_process_browser_test.h

Sign in to add a comment