New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654111 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 344052



Sign in to add a comment

VP9 decoding hanging.

Project Member Reported by jbau...@chromium.org, Oct 7 2016

Issue description

https://www.youtube.com/watch?v=cU-nK4V5idY (in 1080p60) seems to be pretty consistently hanging my browser on an Intel Kaby Lake with hardware VP9 decoding.

The driver is crashing, and the VP9 HMFT seems to be catching that and converting it into a hang. We may have to blacklist this driver version - I'm on 21.20.16.4494.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71db4b38d8f024424439f79df0e88caa0c0f3250

commit 71db4b38d8f024424439f79df0e88caa0c0f3250
Author: jbauman <jbauman@chromium.org>
Date: Mon Oct 10 23:37:20 2016

Disable VPx hardware decoding on Intel drivers.

It seems to be hanging on some videos.

BUG= 654111 
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2402143002
Cr-Commit-Position: refs/heads/master@{#424287}

[modify] https://crrev.com/71db4b38d8f024424439f79df0e88caa0c0f3250/gpu/config/software_rendering_list_json.cc

Labels: Merge-Request-54
This should be a safe patch (just blacklisting some GPUs), so ideally we'd be able to get it into M54 soon.
Labels: -Merge-Request-54 Merge-Approved-54
SGTM, approving for M54
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 11 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef5bf685fdb8f98f6355fe9c34b5ccdf5b1854c5

commit ef5bf685fdb8f98f6355fe9c34b5ccdf5b1854c5
Author: John Bauman <jbauman@chromium.org>
Date: Tue Oct 11 20:43:24 2016

Disable VPx hardware decoding on Intel drivers.

It seems to be hanging on some videos.

BUG= 654111 
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2402143002
Cr-Commit-Position: refs/heads/master@{#424287}
(cherry picked from commit 71db4b38d8f024424439f79df0e88caa0c0f3250)

Review URL: https://codereview.chromium.org/2414493002 .

Cr-Commit-Position: refs/branch-heads/2840@{#721}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ef5bf685fdb8f98f6355fe9c34b5ccdf5b1854c5/gpu/config/software_rendering_list_json.cc

Labels: M-55 Merge-Request-55
Could you send me more URL's in which you see this hanging on.  I am unable to reproduce this on the URL provided in this CL.  I am using a pre-release OS build OS build 14926.1000 and version 1607 with the supplied driver for this build 21.20.16.4506.  I may have to go back to your supplied configuration.  
https://www.youtube.com/watch?v=79ImZE0K7xc also seems to do it. It may be related to preroll ads, so there's some randomness. I've been finding videos by searching "1080p60 youtube" on google.
VP9 hardware acceleration is disabled on canary, so you'll have to add the --ignore-gpu-blacklist command-line flag to use it.
Blocking: 344052
Do you have access to driver 16.4506?  If not let me see if I can get it to you.  I am unable to reproduce it with that version and I rolled back to an older version and may have seen it once out of several times trying but haven't seen it since.  I tried both videos and did notice that they are 1080 at 60 FPS.  I have been using my own build of Chromium but will try Canary --ignore-gpu-blacklist and see what I can see.
I found a way to duplicate it on 16.4506.  Do a fast refresh a couple of times as the video loads on my machine and I can get it to lock.  I will submit a bug to the graphics driver team now that it is reliably reproduced here.  I will let you know.

Comment 11 by dimu@chromium.org, Oct 12 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 12 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/652e5fb950d422612ba00ec3d063bf4ccf30da13

commit 652e5fb950d422612ba00ec3d063bf4ccf30da13
Author: John Bauman <jbauman@chromium.org>
Date: Wed Oct 12 20:56:45 2016

Disable VPx hardware decoding on Intel drivers.

It seems to be hanging on some videos.

BUG= 654111 
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2402143002
Cr-Commit-Position: refs/heads/master@{#424287}
(cherry picked from commit 71db4b38d8f024424439f79df0e88caa0c0f3250)

Review URL: https://codereview.chromium.org/2415573003 .

Cr-Commit-Position: refs/branch-heads/2883@{#74}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/652e5fb950d422612ba00ec3d063bf4ccf30da13/gpu/config/software_rendering_list_json.cc

Comment 13 by ajha@chromium.org, Oct 13 2016

Cc: ajha@chromium.org
Tried a verification of the merge in 2883 branch on Windows-10, chrome versions: 55.0.2883.11(build with fix) and 55.0.2883.9(build without the fix) on Intel corporation driver version: 10.18.15.4278. Didn't observe much of difference when playing the video URL listed in C#0 with the available driver version

Disable of 'VPx hardware decoding on Intel drivers' is reflected under chrome://gpu. Attached is the screen-shot of the same.

Requesting to help in verifying this with there driver version where issue was reproducible.   
654111_Disable.png
667 KB View Download
Labels: TE-Verified-55.0.2883.11
Verified the fix and haven't observed any "not responding" or video hangs with Chrome version 55.0.2883.11 on Windows 10(Intel Kaby Lake with hardware VP9 decoding)
For reference, it seems to be easiest to repro this if I go to https://www.google.com/webhp?sourceid=chrome-instant&rlz=1C1CHFX_enUS585US585&ion=1&espv=2&ie=UTF-8#q=skiing%20through%20trees%20with%20the%20pack then go back and forth between the search result page and the youtube video. I can generally hit this within 5 times or so.
Cc: ericde@chromium.org
Cc: crouleau@chromium.org
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/652e5fb950d422612ba00ec3d063bf4ccf30da13

commit 652e5fb950d422612ba00ec3d063bf4ccf30da13
Author: John Bauman <jbauman@chromium.org>
Date: Wed Oct 12 20:56:45 2016

Disable VPx hardware decoding on Intel drivers.

It seems to be hanging on some videos.

BUG= 654111 
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2402143002
Cr-Commit-Position: refs/heads/master@{#424287}
(cherry picked from commit 71db4b38d8f024424439f79df0e88caa0c0f3250)

Review URL: https://codereview.chromium.org/2415573003 .

Cr-Commit-Position: refs/branch-heads/2883@{#74}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/652e5fb950d422612ba00ec3d063bf4ccf30da13/gpu/config/software_rendering_list_json.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef5bf685fdb8f98f6355fe9c34b5ccdf5b1854c5

commit ef5bf685fdb8f98f6355fe9c34b5ccdf5b1854c5
Author: John Bauman <jbauman@chromium.org>
Date: Tue Oct 11 20:43:24 2016

Disable VPx hardware decoding on Intel drivers.

It seems to be hanging on some videos.

BUG= 654111 
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2402143002
Cr-Commit-Position: refs/heads/master@{#424287}
(cherry picked from commit 71db4b38d8f024424439f79df0e88caa0c0f3250)

Review URL: https://codereview.chromium.org/2414493002 .

Cr-Commit-Position: refs/branch-heads/2840@{#721}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ef5bf685fdb8f98f6355fe9c34b5ccdf5b1854c5/gpu/config/software_rendering_list_json.cc

So thid is a workarround but when will kaby lake users have a real solution?

I now have battery drains...
You can try installing Intel driver 15.45.10.4542 and then run Chrome with --ignore-gpu-blacklist and it should work.

I'm working on a patch to re-enable it by default when using that driver, but it'll take a while for that to roll out to users.
So this is a workarround but when will kaby lake users have a real solution?

I now have battery drains...

See screenshot
Battery drain Chrome on windows 10 ver 1607 on Kaby lake CPU since HW acceleration is off (VP9 OFF).png
86.1 KB View Download
Thanks, I'll wait for your patch and thank you very hard for your work and commitment ;-)
Status: Fixed (was: Assigned)
Filed  bug 666512  for re-enabling.
Project Member

Comment 25 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68789eefe6a1250a15c44268ae27ed5c7a06b6c9

commit 68789eefe6a1250a15c44268ae27ed5c7a06b6c9
Author: jbauman <jbauman@chromium.org>
Date: Fri Nov 18 05:35:29 2016

Re-enable VP9 hardware decoding on new Intel drivers.

Intel GPU drivers 21.20.16.4542 and above have a fix for the hang bug.

BUG= 654111 , 666512 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2508063002
Cr-Commit-Position: refs/heads/master@{#433121}

[modify] https://crrev.com/68789eefe6a1250a15c44268ae27ed5c7a06b6c9/gpu/config/software_rendering_list_json.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 22 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14e7b517d706623cd221898f561f15f3b12a0700

commit 14e7b517d706623cd221898f561f15f3b12a0700
Author: John Bauman <jbauman@chromium.org>
Date: Tue Nov 22 00:15:07 2016

Re-enable VP9 hardware decoding on new Intel drivers.

Intel GPU drivers 21.20.16.4542 and above have a fix for the hang bug.

BUG= 654111 , 666512 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2508063002
Cr-Commit-Position: refs/heads/master@{#433121}
(cherry picked from commit 68789eefe6a1250a15c44268ae27ed5c7a06b6c9)

Review URL: https://codereview.chromium.org/2520093004 .

Cr-Commit-Position: refs/branch-heads/2924@{#45}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/14e7b517d706623cd221898f561f15f3b12a0700/gpu/config/software_rendering_list_json.cc

Sign in to add a comment