New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 654110 link

Starred by 2 users
Status: Fixed
Owner:
█ zhaobin@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[Presentation API] (blink) PresentationConnection should have url attribute

Project Member Reported by zhaobin@chromium.org, Oct 7 2016 
PresentationConnection.idl does not have url attribute. Need to add it to match latest spec:

https://w3c.github.io/presentation-api/#interface-presentationconnection

interface PresentationConnection : EventTarget {
    readonly attribute DOMString                   id;
    readonly attribute DOMString                   url;
    readonly attribute PresentationConnectionState state;
...
}

Comment 1 by mfo...@chromium.org, Oct 7 2016

Labels: PresentationAPI OS-All

Comment 2 by zhaobin@chromium.org, Oct 14 2016

Owner: zhaobin@chromium.org

Comment 3 by sko...@chromium.org, Oct 26 2016

Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894

commit ad0eb0fa0ba570b4e41e28383dda35d1aca0a894
Author: zhaobin <zhaobin@chromium.org>
Date: Tue Jan 17 21:25:47 2017

[Presentation API] Adds DOMString[] constructor to PresentationRequest.

Applying https://codereview.chromium.org/2148643002/

This updates the Blink and platform layers of the Presentation API to support multiple URLs per PresentationRequest.  Until support is plumbed through to the service layer, only the first URL in the array will be passed through the PresentationService API.

This also:

- Updates layout tests to exercise the new constructor
- Adds a unit test to PresentationRequest
- Updates PresentationAvailabilityTest
- Adds a 'url' attribute to PresentationConnection
- Moves mixed-content check to PresentationRequest ctor

BUG= 627655 , 673942 , 654110 

Review-Url: https://codereview.chromium.org/2552343009
Cr-Commit-Position: refs/heads/master@{#444148}

[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/chrome/test/media_router/resources/common.js
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/content/renderer/presentation/presentation_dispatcher.cc
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/content/renderer/presentation/presentation_dispatcher.h
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/content/renderer/presentation/presentation_dispatcher_unittest.cc
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/presentation/presentation-api.html
[add] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/presentation/presentation-navigation-multipleurls.html
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/presentation/presentation-reconnect.html
[add] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/presentation/presentation-start.html
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/presentation/presentationrequest.html
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/Presentation.cpp
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.h
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationConnection.h
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationConnection.idl
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationController.cpp
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationController.h
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationRequest.h
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl
[add] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/Source/modules/presentation/PresentationRequestTest.cpp
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/public/platform/modules/presentation/WebPresentationAvailabilityObserver.h
[modify] https://crrev.com/ad0eb0fa0ba570b4e41e28383dda35d1aca0a894/third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h

Comment 5 by zhaobin@chromium.org, Jan 18 2017

Status: Fixed (was: Started)

Comment 6 by mfo...@chromium.org, Mar 24 2017

Labels: -PresentationAPI
►

Sign in to add a comment