It contains only the core files, not those in ui/wm/public, it should contain both (we can have a separate public target if need be in ui/wm).
aura uses one file in ui/wm/public: window_types. I think the right thing is move window_types.h into ui/aura/client. Then aura should no longer depend upon ui/wm or build it. At that point ui/wm can become it's own build target.
OK, will move ui/wm/public/window_types.h into ui/aura/client/ first.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/627fba95585a7604a2caa6be8d300d164934affc commit 627fba95585a7604a2caa6be8d300d164934affc Author: Thiago Farina <tfarina@chromium.org> Date: Thu May 25 04:45:29 2017 move window_types.h from ui/wm/public to ui/aura/client aura uses one file in ui/wm/public: window_types.h. By moving it onto ui/aura/client, then aura should no longer depend upon ui/wm or build it. At that point ui/wm can become it's own build target. Which will be done in the next patch. BUG=654078 TBR=jochen@chromium.org,reveman@chromium.org Change-Id: I231964a6eda7078b82ad777fd6fd955a81858a33 Reviewed-on: https://chromium-review.googlesource.com/513947 Reviewed-by: Thiago Farina <tfarina@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Thiago Farina <tfarina@chromium.org> Cr-Commit-Position: refs/heads/master@{#474552} [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/display/screen_position_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/drag_drop/drag_drop_tracker.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/root_window_controller.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/root_window_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/shell/window_watcher.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/shell/window_watcher_shelf_item_delegate.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/shell_port.h [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/shell_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/system/tray/tray_event_filter.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/test/ash_test_base.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/test/ash_test_base.h [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/utility/screenshot_controller.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/window_user_data_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/always_on_top_controller.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/ash_focus_rules_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/container_finder.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/default_state.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/drag_details.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/drag_window_controller.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/drag_window_resizer_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/immersive_fullscreen_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/panels/panel_window_resizer_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/stacking_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/system_gesture_event_filter_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/system_modal_container_layout_manager.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/system_modal_container_layout_manager_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/toplevel_window_event_handler_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/video_detector_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/window_dimmer.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/window_manager_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/window_positioner.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/window_state.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/wm_toplevel_window_event_handler.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/workspace/backdrop_controller.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/workspace/multi_window_resize_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/workspace/workspace_event_handler_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/workspace/workspace_window_resizer.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/workspace/workspace_window_resizer_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm/workspace_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm_window.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ash/wm_window.h [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/chrome/browser/ui/views/tabs/tab_drag_controller.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/chrome/test/base/test_browser_window_aura.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/components/exo/notification_surface.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/components/exo/surface.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/content/browser/web_contents/web_contents_view_aura.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/aura/BUILD.gn [rename] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/aura/client/window_types.h [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/aura/mus/property_utils.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/aura/test/test_windows.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/aura/test/test_windows.h [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/aura/window.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/aura/window.h [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/views/cocoa/bridged_native_widget.mm [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/views/controls/native/native_view_host_aura.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/views/corewm/tooltip_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/views/widget/desktop_aura/desktop_screen_position_client.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/views/widget/native_widget_aura.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/views/widget/widget_aura_utils.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/views/widget/widget_aura_utils.h [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/wm/core/focus_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/wm/core/shadow_controller.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/wm/core/shadow_controller_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/wm/core/transient_window_manager_unittest.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/wm/core/visibility_controller.cc [modify] https://crrev.com/627fba95585a7604a2caa6be8d300d164934affc/ui/wm/core/window_animations.cc
I got a big change in progress on https://chromium-review.googlesource.com/518042
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b086a00604e32aae95f66c058cd3f5946a2484d commit 3b086a00604e32aae95f66c058cd3f5946a2484d Author: Thiago Farina <tfarina@chromium.org> Date: Wed May 31 15:51:16 2017 ui: extract ui/wm/public from aura target The intent is to consolidate a lot of code spread across ui/aura/client, ui/views/corewm, and test files, into a single location, for the purpose of simplifying aura further. BUG=654078, 308710 TBR=alokp@chromium.org,avi@chromium.org,rkc@chromium.org,reveman@chromium.org Change-Id: I1a8b0540c7e6a49f616c237b35e2511df8a598c1 Reviewed-on: https://chromium-review.googlesource.com/518042 Commit-Queue: Thiago Farina <tfarina@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#475923} [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/ash_touch_exploration_manager_chromeos.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/display/window_tree_host_manager_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/drag_drop/drag_drop_tracker.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/extended_desktop_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/metrics/desktop_task_switch_metric_recorder.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/metrics/desktop_task_switch_metric_recorder.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/mus/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/mus/move_event_handler.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/mus/move_event_handler.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/mus/window_manager.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/root_window_controller.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/shelf/shelf_window_watcher.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/shell.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/shell.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/system/tray/system_tray.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/test/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/test/test_activation_delegate.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/test/test_activation_delegate.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/tooltips/tooltip_controller_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/drag_details.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/drag_details.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/drag_window_resizer_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/immersive_focus_watcher_aura.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/mru_window_tracker.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/mru_window_tracker_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/overview/window_selector.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/panels/panel_layout_manager.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/panels/panel_window_resizer_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/toplevel_window_event_handler.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/toplevel_window_event_handler.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/toplevel_window_event_handler_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/window_manager_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/window_resizer.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/window_resizer.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/window_state.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/window_state.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/window_util.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/wm_toplevel_window_event_handler.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/wm_toplevel_window_event_handler.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/workspace/multi_window_resize_controller.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/workspace/workspace_event_handler_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/workspace/workspace_layout_manager.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/workspace/workspace_window_resizer.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/workspace/workspace_window_resizer_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm/workspace_controller_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ash/wm_window.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/chromeos/arc/boot_phase_monitor/arc_instance_throttle.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/chromeos/login/ui/login_display_host_impl.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/memory/tab_manager_delegate_chromeos.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/memory/tab_manager_delegate_chromeos.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/ash/chrome_new_window_client.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/ash/launcher/app_window_launcher_controller.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/ash/launcher/app_window_launcher_controller.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/ash/launcher/browser_status_monitor.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/ash/launcher/browser_status_monitor.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/views/extensions/extension_popup_aura.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/views/extensions/extension_popup_aura.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chromecast/graphics/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chromecast/graphics/cast_focus_client_aura.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chromecast/graphics/cast_focus_client_aura.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/chromecast/graphics/cast_window_manager_aura.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/components/exo/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/components/exo/shell_surface.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/components/exo/wm_helper_ash.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/components/exo/wm_helper_ash.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/components/exo/wm_helper_mus.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/components/exo/wm_helper_mus.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/content/browser/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/content/browser/media/capture/aura_window_capture_machine.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/content/browser/media/capture/cursor_renderer_aura.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/extensions/shell/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/extensions/shell/browser/shell_desktop_controller_aura.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/mash/simple_wm/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/mash/simple_wm/simple_wm.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/aura/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/aura/DEPS [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/message_center/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/controls/menu/menu_pre_target_handler.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/controls/menu/menu_pre_target_handler.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/corewm/tooltip_controller.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/corewm/tooltip_controller.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/corewm/tooltip_controller_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/mus/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/desktop_aura/desktop_native_widget_aura.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/desktop_aura/x11_desktop_window_move_client.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/native_widget_aura.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/native_widget_aura.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/native_widget_aura_interactive_uitest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/native_widget_aura_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/tooltip_manager_aura.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/views/widget/widget_interactive_uitest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/base_focus_rules.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/compound_event_filter_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/default_activation_client.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/default_activation_client.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/focus_controller.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/focus_controller.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/focus_controller_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/shadow_controller.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/shadow_controller.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/shadow_controller_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/window_animations.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/window_animations_unittest.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/core/window_util.cc [add] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/BUILD.gn [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/activation_change_observer.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/activation_change_observer.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/activation_client.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/activation_client.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/activation_delegate.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/activation_delegate.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/animation_host.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/animation_host.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/scoped_drag_drop_disabler.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/scoped_drag_drop_disabler.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/scoped_tooltip_disabler.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/scoped_tooltip_disabler.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/tooltip_client.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/tooltip_client.h [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/window_move_client.cc [modify] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/window_move_client.h [add] https://crrev.com/3b086a00604e32aae95f66c058cd3f5946a2484d/ui/wm/public/wm_public_export.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9fe91c0781437bc1119c5dfdccb87d696256858 commit e9fe91c0781437bc1119c5dfdccb87d696256858 Author: Thiago Farina <tfarina@chromium.org> Date: Thu Jun 01 06:06:28 2017 ui/wm: rename wm_export.h to wm_core_export.h With the introduction of wm_public_export.h by commit 3b086a00604e: ("ui: extract ui/wm/public from aura target"), it now makes sense to have a more specific name for this export file. BUG=654078, 308710 Change-Id: I5ebbb50b09a7129b1ac23d1b0da877171551f3d3 Reviewed-on: https://chromium-review.googlesource.com/520762 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Thiago Farina <tfarina@chromium.org> Cr-Commit-Position: refs/heads/master@{#476205} [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/BUILD.gn [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/accelerator_filter.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/base_focus_rules.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/capture_controller.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/compound_event_filter.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/coordinate_conversion.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/cursor_manager.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/default_activation_client.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/default_screen_position_client.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/easy_resize_window_targeter.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/focus_controller.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/focus_rules.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/ime_util_chromeos.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/masked_window_targeter.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/native_cursor_manager.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/native_cursor_manager_delegate.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/shadow.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/shadow_controller.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/shadow_types.cc [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/shadow_types.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/transient_window_controller.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/transient_window_manager.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/transient_window_observer.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/transient_window_stacking_client.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/visibility_controller.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/window_animations.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/window_modality_controller.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/window_util.h [add] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/wm_core_export.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/wm_core_switches.h [modify] https://crrev.com/e9fe91c0781437bc1119c5dfdccb87d696256858/ui/wm/core/wm_state.h [delete] https://crrev.com/59fa2d9df6df0450d142cea1364b1fb73eb535d0/ui/wm/wm_export.h
Comment 1 by tfarina@chromium.org
, May 11 2017Owner: tfarina@chromium.org
Status: Assigned (was: Untriaged)