+sadrul, jshin, any idea?

The message of a notification is displayed using a message_center::BoundedLabel that uses a BreakIterator w/ BREAK_LINE. What in this text is causing it to break more often, and is it wrong?

+msw@

msw -> stevenjb for message_center OWNERS triage; this may be a defect in ui/message_center/views/bounded_label.h
(added by dharcourt, reviewed by mukai, neither are currently active on Chrome, and I'm not active in this area)

I don't know much about the message center behavior on Windows. Also, I haven't worked on message center code for a while. We should probably find an owner for non-cros message center behavior.

+jamescook@, +sky@ for triage.

+yoshiki

This also affects Chrome OS, so it's probably all views platforms.

Do we have a triage process for message center? Does this component have an owner?

assigning to sky for triage

sky@ - friendly ping

The message center is part of the UI>Notifications label, which is triaged by our team in London.

BoundLabel decides the title's lines by calling gfx::ElideRectangleText() with an |available_pixel_height| of 51. This returns the following two lines:

[
    บลจ.แอสเซทพลัส นอขายครั้ง
    แรก(ครั้งเดียว) กองทุนตราส…
]

The height is then decided through gfx::Canvas::SizeStringInt(), given these two lines joined by a literal newline ("\n") and the following flags:

    - gfx::Canvas::MULTI_LINE
    - gfx::Canvas::CHARACTER_BREAK
    - gfx::Canvas::TEXT_ALIGN_TO_HEAD

Which returns 100. (Accounting for the additional newlines.) The text is then rendered through gfx::Canvas::DrawStringRectWithFlags().

It seems like the gfx::Canvas::* methods are accounting for additional in-text linebreaks, whereas gfx::ElideRectangleText() is not. Is there a function that we should be using instead of gfx::ElideRectangleText()?

Sorry, I'm not a good owner for this code either. Maybe asvitkine@ can help?

Sorry, I don't work on this anymore. :(

Not sure if msw@ is the right owner, but I can't think of anyone better.

And around in circles we go!

My best suggestion is to avoid BoundedLabel altogether and remove that code. views::Label has a number of features that should hopefully support message center's use case (and likely do so more efficiently), including SetMaxWidth, SizeToFit, SetMaxLines (brand new with support for tail-eliding for multi-line labels), etc. I'll review any work to extend views::Label support as needed, but this one-off BoundedLabel class probably shouldn't exist.

peter@, since you conducted some investigation, maybe you'd be available for this task?
(I'm not actively working in this area, and probably couldn't address this anytime soon)

Thanks for the additional info! I'm fine having this on my plate, but it's going to be part of the not-anytime-soon bucket too I'm afraid :(

 Issue 566186  has been merged into this issue.

Archiving old bugs that have only received trivial updates for some time.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!